From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 596CE434CA for ; Thu, 14 Jul 2022 08:58:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 77A6E68BA1F; Thu, 14 Jul 2022 11:58:55 +0300 (EEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 04EB368B5D6 for ; Thu, 14 Jul 2022 11:58:48 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657789134; x=1689325134; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1iZk0TcGTRgq6oQmaC57nREheC7cEZ3mjDs/uL14840=; b=DbY4zGVYnd2/RW0YfOldict1heKhO/4dAXwI2tuY+YNhvMyL2Zynd+O1 USJ4vyGYxexfTC5BcTjWliwxDeCBek6Q5HCEZcwDUNpkancw+db5hGXuO w256wQLboGKKZUVgj/sxJFE6OpzwPfBJUJidri+RFeQQ0ZQ6sqIhNFa4w S+Xd2DP2gun4uxOj5z9cAQcJV4znJoxdCVbRnUO/JzYEjS1KXR03oGKqJ fJbkrUtuYlMAOazC1T336b7/8qLcmM7vuiiCPX1e4P7O3ArOrM38YI49L GGxaGzgg6YmOgD3Tyg5IjLilHZZGcFyjp0rOWmV7sE8TRmS64r+bMzMJJ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="265246233" X-IronPort-AV: E=Sophos;i="5.92,269,1650956400"; d="scan'208";a="265246233" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 01:58:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,269,1650956400"; d="scan'208";a="663709697" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 14 Jul 2022 01:58:47 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Jul 2022 01:58:46 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 14 Jul 2022 01:58:46 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 14 Jul 2022 01:58:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqC0ALBeSSq+md347KEvBYuhE09d1BFV/5WEqJkAzaSl8lLObJu/GhlQ38xMFa4CadMHkSiPXqldZ54YcRdLyvrNlE6lH1sObcq5Z5ySVfgaTXPcc7BRadklmVjGvjY+WPk3ZmAsZttQMJJVEagVNbzphTNvRg2bZsHGwWSclo9n5ssbTTqPXt77Qfhgo1wnAjCLqrevQ+cEPzux+xihu2nNKxDNB83jLL4bCwCZzp5HKN9OAw7NvTC/d40uyl+h7FpmgSAs0Hyxnx/od4YECz+1EU9/QTJgru3uDcz0h2LwiKyoNniKxQTw2jZyaKMufidvLBTRJZAYNDJnfpUvFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1iZk0TcGTRgq6oQmaC57nREheC7cEZ3mjDs/uL14840=; b=fHmqYu7RzOXLDUccA1Bl4d7VNnbS+zjJvreRop9x4F2Sol+lX62VinTekGZwKin4RPNKXCyJCvh22uHNDGurlPvFBSl12PI+bVIAJYU/36NseoYe7Hj6CMqdXwTXG8caF8isaC0SuVGOivxXVdN9Ig1xyRRuZ7Ab4YYG/N8WAnI578izzijjuiJf7vksBMyDawyOY+by0VUH0Nlo2uBY2A8H1OXXKHtzpW7/CFO/G0mQ4cHqrzYRbYs6733uWEtL4H89WcHDn2H0wlS7bD9PgPKKmBE/qqlyZSf7FMfvGArw+KIvksGcftCgENbsJ94sLS7J41eoMZ1YQDvcWA+uuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by IA1PR11MB6348.namprd11.prod.outlook.com (2603:10b6:208:3af::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Thu, 14 Jul 2022 08:58:45 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce%5]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 08:58:45 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 1/4] lavc/hevc_refs: fix dpb logical for IRAP Thread-Index: AQHYf45VCFo2pA893UCyUmMTW6PADq19wLmA Date: Thu, 14 Jul 2022 08:58:44 +0000 Message-ID: <35e7e42223e64315117d9eb41ba26f0bab784d13.camel@intel.com> References: <20220614012302.2808428-1-fei.w.wang@intel.com> In-Reply-To: <20220614012302.2808428-1-fei.w.wang@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67b1b0e7-3dea-4b5e-4a87-08da65770ed6 x-ms-traffictypediagnostic: IA1PR11MB6348:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /GDeFTMHI468zb0g5yXo2uz63XMVorCFEA60jKk0bezvK6NBr4xm9tDBPyuyTRZ7oq9bwhcfiX+6pJBM0ZVUPcK2oND1ksG5K5HEQQ+3q7FFG3xksb76jTeCECGuMqaWEncRNZmcFcZ7wEVl88pMD/Rw1sHMArGdzatzohEeYMrGjHUEHvDakroD1VRRYgYSQ4n1qR0rdL6Jsdp2BHl41sdIWq61qQSvzcNIy+6jNv4MyTChroqJgxFpLdwKyUBklsMo9glfsKepA7Kb8ROh8Og1BF7kjeAz0rVb2TgY/LNHKzGL6BsVqabpWu+ibYgUi2hcKwa6d28zKCDuQZ0X+ueiJnoODNaWYYIZ6oUteacPDWUqv6+1yJvy7gWJsgLCpklffX5olWJDtt5ZSeFYr6o0hVB3W7/Wuj3xPq2RlhrzOj8SaHjzn/WjjS92Jns9IC0zMZQak28qKEnTqMzojWHY95suT2LTPhA8taP2HrRjFo8IHfrvlUFBDFB6x/HspYEwk+IK1UnXy+f+1IknvzC+eRbcP6V2BsyX13suu4cuiB1V3qoo9ppNbmpXd3thWlf7cazwUyBkt1wtucB7dnZ4BaDmVt8csKWXtW9p5YXMyE1xdGSCVYeT4KRw4dvwuxXAaOik7GXG/QMN58AE5FIZYADT0400vWr4dDjl74XBwY0hAhzMsmTDM9/g0uj8XLg1McldE+11jxgy+Q568eMwGwoCv18H0+1V97IjP97jkA14MaIonZSQihcUqpY6B/cQtli1Rr4ol7Vg8UG7PL7yccNesjKNlZUl0PXiOnq1W07dTIoMyi8SQC8nIftL0hzWmU31YJEdSsbkYNj9Pg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(39860400002)(376002)(346002)(136003)(6506007)(186003)(478600001)(82960400001)(107886003)(66946007)(66476007)(26005)(122000001)(41300700001)(38100700002)(38070700005)(6512007)(2616005)(83380400001)(4326008)(2906002)(6916009)(5660300002)(8936002)(86362001)(91956017)(6486002)(66446008)(76116006)(36756003)(316002)(8676002)(71200400001)(66556008)(54906003)(64756008)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R1d2MGVBZERCMCt0RDM5NDY3cmpyM0hvK1dEYTN4SkIzTEFKcGxGYy9NdDhH?= =?utf-8?B?Mi83SllSZWRLb21TMHA2ZDJOQXErdVgzYlFkNEFldWlLVXZVUUNpb3JFeEx5?= =?utf-8?B?cjlPVXprdDIvNk5Pd0piY0d3UnBoVkNubFFaaHRKOEJqM1VsMzcwd2hHS2U5?= =?utf-8?B?a2o2Rk4rRHJPVjliYkd2VEtKM2QvclBXd3FRem1iQkh1QmEyOGZDOEhNci9p?= =?utf-8?B?SjdKVnljenc5U2NQWU5TUWdkM21mcWZDL3NKTFMrK05HQTdBNUxla0JMckYw?= =?utf-8?B?WmRDaEJtTFhHcVNVdmxPMWRoLzFIOGdzQVo5a3JvbWdaVEpobUtPSUp1V2Nx?= =?utf-8?B?SVR2UDhKZ2FiRXZMMFZKWDdRYXFtUUdLQVYvZDMrQVBTZDE5bkpRS09TaEdT?= =?utf-8?B?d29xRGkvQTAxWEhvaGZkeS9xY1c5SER1K2NQa0FlL3NBR3h4Ly9nUUJIQ1N1?= =?utf-8?B?L0JWNHpMckdsUVREV0x4S04yQXRKUytkb1ZRUkowbXZLWXpUbWhWdThKQjkw?= =?utf-8?B?REcyQVNJU3FlTFRMeGxTVjV2dUVUY2tocDM1TWp0bXFrbXl6TTJhQkxaODVR?= =?utf-8?B?R05yV0MzUGpHeEs0UUJ1SlQ2MlF1cUx6TkJIVC9keFpJUTMrcVczUHBNRlVy?= =?utf-8?B?NkRWYmxmaERndUpSQVQ1VlNZU1B1SFdzMGZScDFKSzI1L0hycGcxVVp6emk1?= =?utf-8?B?UndWV3J2TlZPSUpXQ01Pb1VxeUpoZjRoZHFKZ01qNGt0VlNPWWFoNXFrYTlu?= =?utf-8?B?eWYvZ3YvazlDb201dmdXbm9SRWluRnFYbEpHdDdZRUFQamptQjg4ZlZaL1Bv?= =?utf-8?B?VFVQQnV4NnUrdHJEaTdLVDIxOFRlVUF5ckw2azlpYWZudEFGRWdGL3U2cDhU?= =?utf-8?B?UjMrenpRTmE2UjFXcWxSdUZUK1Juak52Y01wbFNKUDhMclhFeUowbmUxWEta?= =?utf-8?B?aU1YRDluYmlVaHlsTXRIVUpBa2lzWEkwQ0ZPdUp0ZUZXWUhrbUkyNEFwT3oz?= =?utf-8?B?b3B0ZjVVMGtxVW8va0tBdVBsMm5aTExKSkwyT3FFWUZ6SW4rdm1NSFdBbUFE?= =?utf-8?B?QXQrVDZOam1BQkUvR2w1aVRjejE5ay9CdDZWcm4wdXoxb1pxcS94ZUFJd3g1?= =?utf-8?B?emloOU5xd0FYTmV3dUVUVWZjMzZBUTJTSzJxbGpFbWZWWnhGVC9lWCt1UUVi?= =?utf-8?B?cXNSeHA2eW1uWndlVXNiTDlLdGVpR3NmVFAzQ0xFRjZSazFha081OWM4R3Qr?= =?utf-8?B?V2tjV29qZkNGeFNPclI1YU5iUFpJQjZVTUhERFdRVGg1cU1YL21YeFltaGhp?= =?utf-8?B?aEhFcEQ1YjNFZHBzaSt5eXRUV2p3M2IxQ3ZzZHA4REE4M0x5aWVZSHRCdlFi?= =?utf-8?B?NWk5Y3J3Vld0R1dkSjdTY0E1Q1Mya1FXdHppRk9QWXl0aDVONncyemNKYUQw?= =?utf-8?B?dGFYU1NSVzdnZFgwUG8yMXJmY0l0WmlSOStSdnp6MVRtVWhEMWRRMHhwM1dI?= =?utf-8?B?TXJ1UnM4dklLUmQ0TG1NZTRWNWc3UXFhWnVlMHg2b0F6M1h4TnRDU1VsS0hT?= =?utf-8?B?c1dnTW00QzJ2RDJML3dERThkMDkzQlJNNUpWaHlPQUJmNm1LdVZIeFpzYXVK?= =?utf-8?B?ZlZtckNuT0FyLys4dE45RzhOVXVNYmNXdkhNcXR6dTQ3S2tNZU1GODhPWmpM?= =?utf-8?B?WldsYTAyOVNYOXhuYnhVQlc4eUQ1dWswd1M3NVdlQUcwREljM0lseGlsajVL?= =?utf-8?B?VVRNcnpvenlndkRrUHY2Kzk3cWxXMGQzdUVwd3RTQjBEb0l2SW9zTlZtVE1O?= =?utf-8?B?aWx6QnU0Q2pLSnFYVDBsUFNVQTYwaTdWSDBXQlp4NzB5Q1ZUU3drdmtRZVdo?= =?utf-8?B?dzB4R3pJckkzelI3RWJpMGlsN0ovNTgyVXNWcmhNNkxqN3l1YmZmZVZIL3Av?= =?utf-8?B?T0UyUVg2TjgwREh6SGZ2WVpzS0xtNXJBN1Fnc3JPSFVYRkhHdXBDZFNOMnpn?= =?utf-8?B?RXlEWEJOVFpFU3ZBMncvdi9aa2piMzhqZXlZdlhiVENISFpLRjBVUnIyajVT?= =?utf-8?B?SmU1R3JQU2paSExySkU1UEZ4UVRsVElUV3BZWVZ3eHhTUDFzUXkrZ0pkN3p3?= =?utf-8?B?ZlExVU80aXAvazNUTWthVEZTZFBsNXZ4MmZCUW1abHRtZURyQ2xzck5BWXpu?= =?utf-8?B?Mmc9PQ==?= Content-ID: <30C0669A21803248A177086E2CA3EC9B@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67b1b0e7-3dea-4b5e-4a87-08da65770ed6 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 08:58:45.0148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VMAd8WpyWE9mKBx+q/HMQwjI4KuaLHuF1E2Grpl5VuXC5l3YknQXK1pQbHPDZJPJsVVRG8caf/dXCaT0quUtsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6348 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] lavc/hevc_refs: fix dpb logical for IRAP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xu, Guangxin" , "Wang, Fei W" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-06-14 at 09:22 +0800, Fei Wang wrote: > From: Xu Guangxin > > According to C.5.2.2, item 2. When we got an IRAP, and the > NoOutputOfPriorPicsFlag = 0, we need bump all outputable frames. > > Tested-by: Fei Wang > Signed-off-by: Xu Guangxin > --- > Update: > 1. fixed segment fault for some special clip in 2nd patch. > > libavcodec/hevc_refs.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/libavcodec/hevc_refs.c b/libavcodec/hevc_refs.c > index fe18ca2b1d..3f8fe1ef18 100644 > --- a/libavcodec/hevc_refs.c > +++ b/libavcodec/hevc_refs.c > @@ -174,21 +174,24 @@ int ff_hevc_set_new_ref(HEVCContext *s, AVFrame **frame, > int poc) > > int ff_hevc_output_frame(HEVCContext *s, AVFrame *out, int flush) > { > + if (IS_IRAP(s) && s->no_rasl_output_flag == 1) { > + const static int mask = HEVC_FRAME_FLAG_BUMPING | > HEVC_FRAME_FLAG_OUTPUT; > + for (int i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > + HEVCFrame *frame = &s->DPB[i]; > + if ((frame->flags & mask) == HEVC_FRAME_FLAG_OUTPUT && > + frame->sequence != s->seq_decode) { > + if (s->sh.no_output_of_prior_pics_flag == 1) > + ff_hevc_unref_frame(s, frame, HEVC_FRAME_FLAG_OUTPUT); > + else > + frame->flags |= HEVC_FRAME_FLAG_BUMPING; > + } > + } > + } > do { > int nb_output = 0; > int min_poc = INT_MAX; > int i, min_idx, ret; > > - if (s->sh.no_output_of_prior_pics_flag == 1 && s->no_rasl_output_flag > == 1) { > - for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > - HEVCFrame *frame = &s->DPB[i]; > - if (!(frame->flags & HEVC_FRAME_FLAG_BUMPING) && frame->poc > != s->poc && > - frame->sequence == s->seq_output) { > - ff_hevc_unref_frame(s, frame, HEVC_FRAME_FLAG_OUTPUT); > - } > - } > - } > - > for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > HEVCFrame *frame = &s->DPB[i]; > if ((frame->flags & HEVC_FRAME_FLAG_OUTPUT) && LGTM -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".