From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 814F746C30 for ; Mon, 7 Aug 2023 12:40:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA1E068C5E6; Mon, 7 Aug 2023 15:40:31 +0300 (EEST) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3B88F68C0FC for ; Mon, 7 Aug 2023 15:40:25 +0300 (EEST) Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-6bca66e6c44so3848726a34.0 for ; Mon, 07 Aug 2023 05:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691412023; x=1692016823; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=0i4FH0pYkyofe90FRthL0i/1S50RjVjZh5ouaVu1pGo=; b=E/4htirZ1+DdO3yFr6PU1/eyRgYjCXuRyl7n1/04GdhFPETi35tp5XtX37BlYoZJdF 4f8FyUp8ggNI0gUho2XEPjqYsoZPpTIEn550vVwBfy/XjW9YYiC3l4t0dedXmIV9bfns ghaUSPRjUG1QzpWgCclPNVL/qX6+3/khM4l8kkJ3nnM9M3KHHVKDYjNJ/h2h91AS/7Su 288qK+g2iMbErXq1aZBygh8TEsxplYkndeIu6YjXCiHSsIdwyX1yyowcoPu2MZo3HzZH 2enT6ROaDAOLu13FtIySuOZHGN7qzi6JMGAjRpfsE1cIFyCJZnzn/DfOhlARljpd3uDi NzHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691412023; x=1692016823; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0i4FH0pYkyofe90FRthL0i/1S50RjVjZh5ouaVu1pGo=; b=P9b9MamgYcaujAgpXoTcf0G/2edBUFI5kHXLSTfBk2D0vBMMsWpdPwXxlkbPaVR5bF LuVryOQuKK/dySczvFMl3J4kZcv3ZlBma3GiEYgknPtc0VHL5DoWjHyLQVYHGFEEI/xM Sp6HTPTG0oGGAGa72tAdhIE4GcXrhyBa2zFg1ip6NDowmFqW1gb2wapbGpk2GdvJAg1b I1qy2A4wMrkM+WIAwNLyx5esSTSQl1G4LZgLHaYr5JrEw7ahGLwBO0IZP+euuLHxTYqO n+yFuFd/3y+Ad25PNw3jzUXw7KdwOc4ncG7E89t8NnVE3oMal4OADK3kvAifcumxpX0h XR7w== X-Gm-Message-State: AOJu0Yw7Fv4QxL4Jt77k2cNrNgsbtSEsbeWuXzRxGwf/7U6SZ86hiMLR Wql7QUC5Kq04b2BIZvI60/pQH39/V90= X-Google-Smtp-Source: AGHT+IEFmOlD7+YC2W6dg8u2nO4dWJ4s5R99xRarfvIYVRFbJSf7aWK1x/xZViBbdoNUBHLAGuMoGQ== X-Received: by 2002:a9d:6387:0:b0:6b9:ed64:1423 with SMTP id w7-20020a9d6387000000b006b9ed641423mr8359472otk.2.1691412022691; Mon, 07 Aug 2023 05:40:22 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id g20-20020a9d6194000000b006b9d237ea0bsm4722506otk.34.2023.08.07.05.40.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 05:40:22 -0700 (PDT) Message-ID: <35b888e3-6e1d-1b43-428c-23a002720139@gmail.com> Date: Mon, 7 Aug 2023 09:40:23 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 To: ffmpeg-devel@ffmpeg.org References: <20230803060132.501741-1-fei.w.wang@intel.com> <20230803060132.501741-2-fei.w.wang@intel.com> Content-Language: en-US From: James Almer In-Reply-To: <20230803060132.501741-2-fei.w.wang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v3 2/6] lavc/av1: Add common code and unit test for level handling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/3/2023 3:01 AM, fei.w.wang-at-intel.com@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- > update: > 1. Rename libavcodec/av1_levels*. > 2. Use array instead of handle for AV1LevelDescriptor.name. > 3. Compile libavcodec/av1_levels* only when enable vaapi av1 encoder. > > libavcodec/Makefile | 1 + > libavcodec/av1_levels.c | 92 +++++++++++++++++++++++++ > libavcodec/av1_levels.h | 58 ++++++++++++++++ > libavcodec/tests/.gitignore | 1 + > libavcodec/tests/av1_levels.c | 124 ++++++++++++++++++++++++++++++++++ > tests/fate/libavcodec.mak | 5 ++ > 6 files changed, 281 insertions(+) > create mode 100644 libavcodec/av1_levels.c > create mode 100644 libavcodec/av1_levels.h > create mode 100644 libavcodec/tests/av1_levels.c > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 3c16b51462..a6b2ecbb22 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -1319,6 +1319,7 @@ TESTPROGS = avcodec \ > jpeg2000dwt \ > mathops \ > > +TESTPROGS-$(CONFIG_AV1_VAAPI_ENCODER) += av1_levels This encoder does not exist at the point this patch would be applied. It's introduced in patch 6/6. Squash libavcodec/av1_levels.c into patch 6/6 (Its first user), and then add the test in a new patch 7. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".