From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A7D93451AC for ; Mon, 13 Mar 2023 11:08:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1E5FB68BB04; Mon, 13 Mar 2023 13:08:42 +0200 (EET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B3230689E1F for ; Mon, 13 Mar 2023 13:08:35 +0200 (EET) Received: by mail-pl1-f182.google.com with SMTP id y11so12526905plg.1 for ; Mon, 13 Mar 2023 04:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obe-tv.20210112.gappssmtp.com; s=20210112; t=1678705714; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uqHKT3H+ENVpkinI23W78UbkGJYJ5qQWIOoiYW6/OAk=; b=wiS43EUDw4gq4fpz5MowXPhdFbj5e+8gB6EDJAkkouSXXTBlDzm7mwGwZgvNEImR7q x1wFCCaXImiEP/Eg1Q3H+6O/bdQqJVhtT96PbaPTjLQHYUy6W7m6IOMLQGuTgcUKCHYs UzGzgENvMN23bva2yyfwEgZLQmpZ6m9u9JWZdfP5zV4Pf1rR/diBl6oVId9XWu0AdJIQ qd+i5nPOa3VHwwZPTZap/RswiU42/NjcsZa3ym4aE3Ep34YY8MV/et3AYYOVoBW0qDrC 8EMFlGaIFct9vR1Jgf6BN4s2EvRNNTe5qcHab+q+FkoDEHouadksBnLlYaX7B69P3dlT 41uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678705714; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uqHKT3H+ENVpkinI23W78UbkGJYJ5qQWIOoiYW6/OAk=; b=NsfjHFvjBicj7TDxNQcR5bbEloHJnIcBxn8b5el/MjdaTHapCNfFDUhXZyKxRrnj/+ 3AvJ8Y6rAu9ogVCJrgxBGgm1pD0vUKw7EZ7xHd4k9nt+tJ+sL84ae6PXB81moSuK/7TG dUQn0cr0+N4t5oNyksU0z3L2iPq4a2wO79IUe7NHOpQnxUg/SpynbXN7bURTEVdBh/TX gqEzhrHqQp2iqo0eQGe4o9DfVEvnlb+Ey+no0iBnwIUG83SmcDHfRbGvXaja3Te7uk4s /sE2ANZhocKTrGjD+PcZaMrDMJ+24FskIZxYrnEC+34a1k+9Hu7LvD/LZLk3Jpck+aq0 fBog== X-Gm-Message-State: AO0yUKWu9uhchQ/3KyLY++Cl7dolCvhBlV1WTRQUEu2tqmfM0xcr9z/L 8SfPpJ16r3k4tUAyKXQJHGY7gHV+eWDp12lAWjY= X-Google-Smtp-Source: AK7set/dxm91sEWNlYixb8HkakUF0jCfPz0k8JbBxqCO+TgQcAmP5lVHAVkslOZYjtm9SXD4hfWgew== X-Received: by 2002:a17:902:db11:b0:19d:7a4:4063 with SMTP id m17-20020a170902db1100b0019d07a44063mr39686903plx.46.1678705713797; Mon, 13 Mar 2023 04:08:33 -0700 (PDT) Received: from [192.168.5.22] (d51A44418.access.telenet.be. [81.164.68.24]) by smtp.gmail.com with ESMTPSA id bd6-20020a170902830600b0019e21d2ecf8sm4455088plb.293.2023.03.13.04.08.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 04:08:33 -0700 (PDT) Message-ID: <35a9d676-2e58-a1ec-528a-7b243ec15776@obe.tv> Date: Mon, 13 Mar 2023 12:08:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230220195703.1297421-1-jdarnley@obe.tv> <20230220195703.1297421-3-jdarnley@obe.tv> From: James Darnley In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 3/3] avfilter: add avx2 filter_line function for bwdif X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/11/23 17:14, Thomas Mundt wrote: >> + %if mmsize == 32 >> + vpbroadcastd m12, DWORD clip_maxm >> > > I get a green pattern at bit depths > 8. > Looks good with: > vpbroadcastw m12, WORD clip_maxm > > + %else >> movd m12, DWORD clip_maxm >> SPLATW m12, m12, 0 >> + %endif Of course it should be a word broadcast! But why doesn't my checkasm test catch it? >> bwdif->filter_line = ff_bwdif_filter_line_sse2; >> if (EXTERNAL_SSSE3(cpu_flags)) >> bwdif->filter_line = ff_bwdif_filter_line_ssse3; >> + if (ARCH_X86_64 && EXTERNAL_AVX2(cpu_flags)) >> + bwdif->filter_line = ff_bwdif_filter_line_avx2; >> } else if (bit_depth <= 12) { >> if (EXTERNAL_SSE2(cpu_flags)) >> bwdif->filter_line = ff_bwdif_filter_line_12bit_sse2; >> if (EXTERNAL_SSSE3(cpu_flags)) >> bwdif->filter_line = ff_bwdif_filter_line_12bit_ssse3; >> + if (ARCH_X86_64 && EXTERNAL_AVX2(cpu_flags)) >> + bwdif->filter_line = ff_bwdif_filter_line_12bit_avx2; >> } >> } I was intending to only modify/write the 8-bit function so this is a mistake. Thanks. I'll be back with a version 2. [re-sending to list] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".