From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3D0EA4579D for ; Sun, 23 Apr 2023 10:06:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 47CF668BF95; Sun, 23 Apr 2023 13:06:34 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8E63668BE80 for ; Sun, 23 Apr 2023 13:06:27 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id A9121E8610 for ; Sun, 23 Apr 2023 12:05:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W9RYRFZLUhy0 for ; Sun, 23 Apr 2023 12:05:52 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id E1554E847E for ; Sun, 23 Apr 2023 12:05:51 +0200 (CEST) Date: Sun, 23 Apr 2023 12:05:51 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <168224350165.3843.7618353870792865075@lain.khirnov.net> Message-ID: <3587873f-7b50-a98c-70ce-443aeb93b9ae@passwd.hu> References: <168217824856.3843.12078608174603704828@lain.khirnov.net> <2154f93d-aa9-21da-966-a18399b33bf1@passwd.hu> <168224247972.9711.2598182970187678748@lain.khirnov.net> <168224350165.3843.7618353870792865075@lain.khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg_mux: fix reporting muxer EOF as error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 23 Apr 2023, Anton Khirnov wrote: > Quoting Marton Balint (2023-04-23 11:42:48) >> On Sun, 23 Apr 2023, Anton Khirnov wrote: >>> Quoting Marton Balint (2023-04-23 11:12:38) >>>> This seems like yet another clash of AVERROR_EOF error codes coming from >>>> different places with different semantics. For >>>> av_interleaved_write_frame(), AVERROR_EOF is an error condition, so >>>> file encoding should fail, >>> >>> Why should it fail? I'd think a muxer returning EOF is the way to signal >>> non-error muxer-side termination. >> >> That would be an API change. AVERROR_EOF is not special in any way from >> other error codes for av_interleaved_write_frame. A muxer cannot signal >> non-error muxer side termination with existing API. > > All error codes (should) have a specific meaning. I cannot think of a > good reason for a muxer to return AVERROR_EOF to signal an error. > Can you? Previously, we expeced users to treat any negative error code as error for av_interleaved_write_frame(). This is what is documented. ffmpeg.c followed this approach. Don't you see the slightest problem if we suddenly change this? Here is a real case of av_interlaved_write_frame() returning EOF: https://ffmpeg.org/pipermail/ffmpeg-devel/2023-February/306247.html Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".