From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 270F648E0B for ; Sun, 28 Jan 2024 23:52:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B823F68D1AE; Mon, 29 Jan 2024 01:52:09 +0200 (EET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 566DF68D147 for ; Mon, 29 Jan 2024 01:52:03 +0200 (EET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d76671e5a4so16650465ad.0 for ; Sun, 28 Jan 2024 15:52:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706485920; x=1707090720; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=849p8iLquo6llK81n6WltucWYuSVAqa4sa7+0QV1Dzg=; b=MXhCCSox1st+pwgaBPSScM7KO8YFyEnI1KKT0u5l0wAEbQahzmUXze+KsMqst5jtSg 5GQtMYuPUrxeSgWLIV4Ikbg5T8bX3QAijeRundBJOBJf3+eL6Kd21uj+jQnK9O46+nbT VB0tFcimGNKT7OGB+mwE2VcNjgMciafmGcLGAu4d8Dfn88rR5dQ+3T73Cng0zh7gWqZu QDD1dg1Fah2VPTsmmWR3wm7soiRi2cPIDpbn6MMBzSolDc7/Ugbr7wPZoQfu007N42e5 JpQ0D1tn/jl/YHhfC4GzKxdoPhPPtp0NzHOLMIELBIoYtSyXrNt87h2MwrMop8DIggey cDeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706485920; x=1707090720; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=849p8iLquo6llK81n6WltucWYuSVAqa4sa7+0QV1Dzg=; b=IaGzQzMNUnVl3FQdTOjqf7ZLBhufbPhlciVeXsF/jXmkIQdS/RzuN6L1cem+ynU0B5 9qV/vHtfBJ94ONU6CWO3FrWNwGGrKPGgoTXbJYlFfDQl1ZATiKoKJc0hLNQBZbuPSyya UFZGOvF1jZhldf54TWibbqW9lV79Xj8qGvtgCjBkEL3QR3NgtB5C7Cwn/L3s/roV3N6W 09Q1/7ju84UknOequOO2avo0VHQHnparuKhcw7GEaSv8PGFvJbCOYVlotQebn4veh55G ZDdziRekOIcwAQWlwfLJuTsuGra3eXjF9idtl/iVEQ9ZkgdviR6kShaOLwXHA4BRcdsn SLgg== X-Gm-Message-State: AOJu0Yz46XIt0RIvG41A1YUafPl6heASbBgwCij3IGJ4bSTN9aupsTB0 DMOy9f/oIq/XX7PgDzefG94OlF0+qeRxqsNkkLrjQuY55mVFQvX/jVrnfFpu X-Google-Smtp-Source: AGHT+IH49zZnSCdmAxvRwpZ3Lk+/DpACBmyo9hROLTtVMYnvnvk1nUBbYKIbFiO1EmMd0l9gt/MgvA== X-Received: by 2002:a17:903:a90:b0:1d8:8cd6:efba with SMTP id mo16-20020a1709030a9000b001d88cd6efbamr4691621plb.32.1706485920453; Sun, 28 Jan 2024 15:52:00 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id e4-20020a170902744400b001cf59ad964asm1246227plt.140.2024.01.28.15.51.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jan 2024 15:52:00 -0800 (PST) Message-ID: <35759608-96f9-4247-84aa-18bef03b864c@gmail.com> Date: Sun, 28 Jan 2024 20:52:20 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240128224141.GT6420@pb2> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20240128224141.GT6420@pb2> Subject: Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec: Rename ff_kbd_window_init() as it will be needed from outside libavcodec" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/28/2024 7:41 PM, Michael Niedermayer wrote: > On Sun, Jan 28, 2024 at 02:49:26PM +0100, Andreas Rheinhardt wrote: >> This reverts commits fd5aa93a37b3fa21195c6d7b22ef655124020e09 >> and cf00f60bab1f79213c274a6cd4357b32bd5c0101 >> ("avcodec/kbdwin: Support arbitrary sized windows"). >> >> The change in question has only been made for libavradio. >> in anticipation of merging it into the main tree. This has >> not happened, so this commit reverts the changes to kbdwin >> that are not used for anything else. In particular, these >> functions are no longer exported (as avpriv functions); >> notice that the fixed-point function has been exported >> despite having never been used outside of lavc. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/aacdec_template.c | 8 ++++---- >> libavcodec/aactab.c | 4 ++-- >> libavcodec/ac3dec.c | 2 +- >> libavcodec/ac3enc_fixed.c | 2 +- >> libavcodec/ac3enc_float.c | 2 +- >> libavcodec/dolby_e.c | 4 ++-- >> libavcodec/kbdwin.c | 23 ++++++++--------------- >> libavcodec/kbdwin.h | 10 ++++------ >> 8 files changed, 23 insertions(+), 32 deletions(-) > > I still intend to work on SDR either within what people agreed to > (that is a separate library) or in form of a fork. > > For both it is easier if the functions it needs are accessible > > thx Renaming an ff_ symbol into avpriv_ can happen at any time. Renaming an avpriv_ symbol to ff_ can only happen during a bump. So this patch is IMO ok. There's no warranty that whatever happens with SDR will happen before the next bump, so better remove as many exposed symbols as possible. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".