From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BE19740695 for ; Tue, 29 Mar 2022 12:43:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23B0168B23B; Tue, 29 Mar 2022 15:43:12 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE13168B151 for ; Tue, 29 Mar 2022 15:43:05 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 22TCh5wR022437-22TCh5wS022437; Tue, 29 Mar 2022 15:43:05 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 40FF8A143A; Tue, 29 Mar 2022 15:43:05 +0300 (EEST) Date: Tue, 29 Mar 2022 15:43:05 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220325185257.513933-2-bavison@riscosopen.org> Message-ID: <3569a5ec-6caa-361a-b3d6-b15b7c4f4190@martin.st> References: <20220317185819.466470-1-bavison@riscosopen.org> <20220325185257.513933-1-bavison@riscosopen.org> <20220325185257.513933-2-bavison@riscosopen.org> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 01/10] checkasm: Add vc1dsp in-loop deblocking filter tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Ben Avison Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 25 Mar 2022, Ben Avison wrote: > Note that the benchmarking results for these functions are highly dependent > upon the input data. Therefore, each function is benchmarked twice, > corresponding to the best and worst case complexity of the reference C > implementation. The performance of a real stream decode will fall somewhere > between these two extremes. > > Signed-off-by: Ben Avison > --- > tests/checkasm/Makefile | 1 + > tests/checkasm/checkasm.c | 3 ++ > tests/checkasm/checkasm.h | 1 + > tests/checkasm/vc1dsp.c | 94 +++++++++++++++++++++++++++++++++++++++ > tests/fate/checkasm.mak | 1 + > 5 files changed, 100 insertions(+) > create mode 100644 tests/checkasm/vc1dsp.c Actually, this test already paid off - thanks! It caught a real issue with the existing x86 loopfilter assembly. The stride parameter is 'int', but the assembly uses it as a full register without clearing/sign extending the upper half. Instead of complicating the assembly, the usual remedy is to change the parameter to ptrdiff_t, to avoid the issue altogether - I'll send a patch for that. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".