From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 583D947793
	for <ffmpegdev@gitmailbox.com>; Fri, 22 Dec 2023 09:48:00 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D09768D297;
	Fri, 22 Dec 2023 11:47:59 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E78C68CF6E
 for <ffmpeg-devel@ffmpeg.org>; Fri, 22 Dec 2023 11:47:52 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 3BM9lpJk020207-3BM9lpJl020207
 for <ffmpeg-devel@ffmpeg.org>; Fri, 22 Dec 2023 11:47:51 +0200
Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144])
 by mail9.parnet.fi (Postfix) with ESMTPS id AE5FFA146B
 for <ffmpeg-devel@ffmpeg.org>; Fri, 22 Dec 2023 11:47:51 +0200 (EET)
Date: Fri, 22 Dec 2023 11:47:51 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <CAEa-L+vXvgvtE_tKuSoA_Zvmx2jSMFMTCaPiQ3iur7vkc-uSMA@mail.gmail.com>
Message-ID: <3535b8e5-e2b-6a9f-3233-b36c2039fca0@martin.st>
References: <CAEa-L+vXvgvtE_tKuSoA_Zvmx2jSMFMTCaPiQ3iur7vkc-uSMA@mail.gmail.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH 2/6] checkasm/takdsp: add decorrelate_sr
 test
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/3535b8e5-e2b-6a9f-3233-b36c2039fca0@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 18 Dec 2023, flow gg wrote:

>

> +static void test_decorrelate_sr(TAKDSPContext *s) {
> +#define BUF_SIZE 1024
> +    declare_func(void, int32_t *, int32_t *, int);
> +
> +    if (check_func(s->decorrelate_sr, "decorrelate_sr")) {
> +        LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
> +        LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
> +        LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]);
> +
> +        randomize(p1, BUF_SIZE);
> +        randomize(p2, BUF_SIZE);
> +        memcpy(p2_2, p2, BUF_SIZE);
> +
> +        call_ref(p1, p2, BUF_SIZE);
> +        call_new(p1, p2_2, BUF_SIZE);
> +
> +        if (memcmp(p2, p2_2, BUF_SIZE) != 0){
> +            fail();
> +        }

This function mutates p1, not p2, so p1 is the one that needs to be copied 
and checked, and memcpy/memcmp need a *sizeof().

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".