From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 79AED4953E for ; Wed, 13 Mar 2024 23:44:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E9D9068CFDA; Thu, 14 Mar 2024 01:44:02 +0200 (EET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C836E68CF55 for ; Thu, 14 Mar 2024 01:43:56 +0200 (EET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dde2c0f769so617425ad.3 for ; Wed, 13 Mar 2024 16:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710373434; x=1710978234; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q4ircb1LJG17iQjwWKcvOp7nftzMLAOQQ2yEFcQ+5f4=; b=Kl5oHlTRe0tEIWCTBk45jKXcPCuBxXt8Pq+j2tQSWfobCUc7eptSP8e7ZxFbiJOFjr 1bwPyFq+0xlWKsZ3+vZN8kHkThKzPcytUgFQSjLxw3RptbqGkcAa/zZ1VoxZ43zIeldO GwsMp9urtnRDdOBnQp1g4A0YLaoJCvF3b524/uuMutgT/Re8T/yLRX5cfrcjRAyD6tdF NB7sMZaVOl4riZWXhWXeXf8CmnjaYQIA3vEm42G06s0d6jkV9JYHsO23h96N0dBolEBZ F0q5X/pXuNLvV7yZHiyMERgs6opOLnO+61rO8y7scQ5+E+2envs0FdCCYwJm8OFSSfn4 g+Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710373434; x=1710978234; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q4ircb1LJG17iQjwWKcvOp7nftzMLAOQQ2yEFcQ+5f4=; b=OOJPVZghg7m7iygn2tZyw5ybOYwD+iqlwdxzDC0cTgyqRnF2qdtc6GzscDuefLJs/m UAFUghPhAL8e7CzPbHqOyz+HVl8jiW9hJfcSubFLiJLT3J+P1at5DkVGR6VlZlt07mQZ vDSOKQYdi00pLXfln/9Cxmk0ua2xeMyr/uDDCzoyrs2lLCCJEdqsUFoWaUpjVXXcBnEl 5xJs0uOcy0pQf+9RWQXRzFAVJvyDUEgWUDb/kLC5mCxA3hNwhUeHKMUsGuqeLi8N/5nP Xfct03zbphk6zaha+L1Kma69Pv5LnAKgVpeGzgto0XQxS24smsU8GchvA7vdENzMahcA pMhQ== X-Gm-Message-State: AOJu0YxJDEV403gUKdX06zL9kE8fVMbIJ0mMnOsBD7hYAezFYwpoHtik aUHZ0XGrcMFdv8/tLa0vJmJaCDPdKaEAmEL4S82IFNpLvs2C6n6Bx5gj2Gxh X-Google-Smtp-Source: AGHT+IEhUrgBJ0v+yKTVpFOPet57nt0z0Ca3B4DYlDTCmqEgeuY6lO2c51lkDJIrjAbuBXRRz5VFbA== X-Received: by 2002:a17:903:8cb:b0:1dd:b739:de40 with SMTP id lk11-20020a17090308cb00b001ddb739de40mr367298plb.19.1710373434221; Wed, 13 Mar 2024 16:43:54 -0700 (PDT) Received: from [192.168.0.10] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id u7-20020a170902b28700b001dbcfb23d6csm172588plr.267.2024.03.13.16.43.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 16:43:53 -0700 (PDT) Message-ID: <35250a40-88fb-4337-b237-81e6c50a25f0@gmail.com> Date: Wed, 13 Mar 2024 20:43:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240313122425.92457-1-ffmpeg@haasn.xyz> <20240313122425.92457-2-ffmpeg@haasn.xyz> <20240313234126.GZ6420@pb2> From: James Almer In-Reply-To: <20240313234126.GZ6420@pb2> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/13/2024 8:41 PM, Michael Niedermayer wrote: > On Wed, Mar 13, 2024 at 01:24:25PM +0100, Niklas Haas wrote: >> From: Niklas Haas >> >> This filter's existing design has a number of issues: >> >> - There is no guarantee whatsoever about the order in which frames are >> pushed onto the main and ref link, due to this being entirely >> dependent on the order in which downstream filters decide to request >> frames from their various inputs. As such, there is absolutely no >> synchronization for ref streams with dynamically changing resolutions >> (see e.g. fate/h264/reinit-*). >> >> - For some (likely historical) reason, this filter outputs its ref >> stream as a second ref output, which is in principle completely >> unnecessary (complex filter graph users can just duplicate the input >> pin), but in practice only required to allow this filter to >> "eventually" see changes to the ref stream (see first point). In >> particular, this means that if the user uses the "wrong" pin, this >> filter may break completely. >> >> - The default filter activation function is fundamentally incapable of >> handling filters with multiple inputs cleanly, because doing so >> requires both knowledge of how these inputs should be internally >> ordered, but also how to handle EOF conditions on either input (or >> downstream). Both of these are best left to the filter specific >> options. (See #10795 for the consequences of using the default >> activate with multiple inputs). >> >> Switching this filter to framesync fixes all three points: >> >> - ff_framesync_activate() correctly handles multiple inputs and EOF >> conditions (and is configurable with the framesync-specific options) >> - framesync only supports a single output, so we can (indeed must) drop >> the redundant ref output stream >> >> Update documentation, changelog and tests to correspond to the new usage >> pattern. >> >> Fixes: https://trac.ffmpeg.org/ticket/10795 >> --- >> Changelog | 2 + >> doc/filters.texi | 10 +- >> libavfilter/vf_scale.c | 130 ++++++++++++----------- >> tests/filtergraphs/scale2ref_keep_aspect | 3 +- >> 4 files changed, 76 insertions(+), 69 deletions(-) > > this causes > ./ffplay --help > to segfault Unrelated to this crash, but why does that command line output every single option from every single filter? It's several thousand printed lines. Shouldn't that be the output of --longhelp or similar, and leave --help to print some basic non filter specific options? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".