From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 59E924500A for ; Thu, 19 Jan 2023 12:11:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A422268BA8C; Thu, 19 Jan 2023 14:11:34 +0200 (EET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D99D968B080 for ; Thu, 19 Jan 2023 14:11:27 +0200 (EET) Received: by mail-wm1-f45.google.com with SMTP id d4-20020a05600c3ac400b003db1de2aef0so1111880wms.2 for ; Thu, 19 Jan 2023 04:11:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=IQIilFSQBOdSzXFuEyiZgV2e7lTf4Tw2el6y13h+Vjs=; b=i/Q1ctb5UlaUclmD9gtY3IC/focLWKDTDGW02gzSthVN2amuCX5HXxo7BzezccntxQ B19l60smxtNtKie7PEC12jYWWy83Vvg+Hpn8PfyJj0MrTAM8nf0Djn/oheuKXgOCiA69 2KUxJ9UEYAChC0Yoc4HAnhPq2z5RoCPLu3qK9fuHy77io91J6shGRYISC5yo2pY6a8TN idTz80aLlGBxS09QRqbVM1q5cl2jR7PNZmOeFpIv8iL958gtn/6+xl5ZYHBQolkk50ZD F+by4I8SyOz8HbZwfk4klsklvml3x3rvngPtH74rJzmDCJrlx/Bjj2UmFOutSiSwxK10 NG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IQIilFSQBOdSzXFuEyiZgV2e7lTf4Tw2el6y13h+Vjs=; b=PG57nzvhPbfVSZ52CxirjyZVEBC1dtfkdxY63vfAGo7FJKPSDGLQtm8mUuX+HozqBF OZDZsSDYJKklUQVWAWDz4rZeydJyR3EfvHXwOuj1C3uZJ3AtroGXh4kfI5AnTuvCsgFG sIF8wPqEYBYVqaISExAf0elI9dTPJ79UV6HsqxN58wiYGnb1gcysBYVSLkqN+rFVn8Xj McZakakPNIj70SnVGPckawS7cVD9X62V7Q4twqd543IHpPvJHvKbnXVSoNFFTm2g/ej4 sm7dd9VUeRRh3rHZG84ceyzqdhrPc4Kdt9dkeoRI8JK4Jt/ogH5MOPI9bBy5WGoDYFHA A7tw== X-Gm-Message-State: AFqh2krfPo3cm7tAB5GXLFGOPRoezto+nSaBLVet9dcRztPTRKi2w5db raghcVZ8njnSAr7KGES9VtxoA5b4NbI= X-Google-Smtp-Source: AMrXdXsXJUPv+BmQTQZJfC+sRVws6eH3aIpX5LkITNURjaf3xn6KJKdoD93rFW2wd++/BfoNmdtDfw== X-Received: by 2002:a05:600c:2116:b0:3d6:10e:68a8 with SMTP id u22-20020a05600c211600b003d6010e68a8mr6187300wml.0.1674130286631; Thu, 19 Jan 2023 04:11:26 -0800 (PST) Received: from ?IPV6:2a01:cb1d:88e0:1200:5c5c:6815:d7aa:c572? ([2a01:cb1d:88e0:1200:5c5c:6815:d7aa:c572]) by smtp.gmail.com with ESMTPSA id n19-20020a05600c4f9300b003d1d5a83b2esm5215811wmq.35.2023.01.19.04.11.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 04:11:26 -0800 (PST) Message-ID: <34c27bec-ba11-f58e-565b-b6522b95cc76@gmail.com> Date: Thu, 19 Jan 2023 13:11:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: ffmpeg-devel@ffmpeg.org References: <8b03bd15-63ce-db34-65b5-596661cb5e3b@gmail.com> <50954f7b-5494-12ff-2821-32ce4c74bda9@gmail.com> <8d91da73-f51f-f864-1504-822cac76e209@gmail.com> <6594f837-39ba-6d5a-6cf5-576944011045@gmail.com> Content-Language: en-US From: Jeffrey Chapuis In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 17/01/2023 19:11, Paul B Mahol wrote: > On 1/17/23, Jeffrey Chapuis wrote: >> I'm getting there, don't give up on me. >> >> Now 'limit_upscaled' become the variable used in filter_frame() and >> 'limit' is never change, unless by user >> We only have to update 'limit_upscaled' if 'limit' really changes. > > probably ok >- if (s->limit < 1.0) >- s->limit *= (1 << desc->comp[0].depth) - 1; >+ s->bitdepth = desc->comp[0].depth; >+ s->limit_upscaled = s->limit; >+ if (s->limit_upscaled < 1.0) >+ s->limit_upscaled *= (1 << s->bitdepth) - 1; Is it better like this? we avoid a double assignment. - if (s->limit < 1.0) - s->limit *= (1 << desc->comp[0].depth) - 1; + s->bitdepth = desc->comp[0].depth; + + if (s->limit_upscaled < 1.0) + s->limit_upscaled = s->limit * (1 << s->bitdepth) - 1; + else + s->limit_upscaled = s->limit; The full patch without this change is in the previous reply (https://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305806.html), let me know if there is other change to make with formatting/renaming. I really appreciate your patience with this patch. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".