[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Check creation of new program

[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Check creation of new program

[Andreas Rheinhardt]

Fixes Coverity issue #1512413.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 fftools/ffmpeg_opt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 8128dcf9fb..aec94dc0f4 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -2769,6 +2769,8 @@ static void of_add_programs(AVFormatContext *oc, const OptionsContext *o)
         }
 
         program = av_new_program(oc, progid);
+        if (!program)
+            exit_program(1);
 
         p = o->program[i].u.str;
         while(*p) {
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Check creation of new program

[Gyan Doshi]

On 2022-08-26 02:45 am, Andreas Rheinhardt wrote:
> Fixes Coverity issue #1512413.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   fftools/ffmpeg_opt.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 8128dcf9fb..aec94dc0f4 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -2769,6 +2769,8 @@ static void of_add_programs(AVFormatContext *oc, const OptionsContext *o)
>           }
>   
>           program = av_new_program(oc, progid);
> +        if (!program)
> +            exit_program(1);

Needs a log for the user why ffmpeg exits.

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".