From: Gyan Doshi <ffmpeg@gyani.pro> To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] ffbuild: use response files only if ar accepts them Date: Mon, 17 Mar 2025 23:00:01 +0530 Message-ID: <34ad06cb-4e8c-42bc-89bb-d3013d7e0cdd@gyani.pro> (raw) In-Reply-To: <tencent_0E1CE84713EE936335C82901CEBDC547D305@qq.com> On 2025-03-17 09:44 pm, Zhao Zhili wrote: > >> On Mar 17, 2025, at 23:16, Gyan Doshi <ffmpeg@gyani.pro> wrote: >> >> This is to not break linking with toolchains that don't support reading >> args from a 'response file'. >> --- >> I've assumed that ld on a system will have same support as ar. >> >> configure | 7 +++++++ >> ffbuild/library.mak | 8 ++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/configure b/configure >> index f6964c4ee1..d84e32196d 100755 >> --- a/configure >> +++ b/configure >> @@ -5230,6 +5230,12 @@ else >> ar_o='$@' >> fi >> >> +if $ar 2>&1 | grep -qi "@.*file"; then >> + ar_objs="true" >> +else >> + ar_objs="" >> +fi > Works for me. Good. Let's wait for another report. Regards, Gyan > >> + >> add_cflags $extra_cflags >> add_cxxflags $extra_cxxflags >> add_objcflags $extra_objcflags >> @@ -8133,6 +8139,7 @@ DEPX86ASM=$x86asmexe >> DEPX86ASMFLAGS=\$(X86ASMFLAGS) >> AR=$ar >> ARFLAGS=$arflags >> +AR_OBJS=$ar_objs >> AR_O=$ar_o >> AR_CMD=$ar >> NM_CMD=$nm >> diff --git a/ffbuild/library.mak b/ffbuild/library.mak >> index 72e3872157..7e1871b74c 100644 >> --- a/ffbuild/library.mak >> +++ b/ffbuild/library.mak >> @@ -35,8 +35,12 @@ OBJS += $(SHLIBOBJS) >> endif >> $(SUBDIR)$(LIBNAME): $(OBJS) $(STLIBOBJS) >> $(RM) $@ >> +ifeq ($(AR_OBJS),true) >> $(Q)echo $^ > $@.objs >> $(AR) $(ARFLAGS) $(AR_O) @$@.objs >> +else >> + $(AR) $(ARFLAGS) $(AR_O) $^ >> +endif >> $(RANLIB) $@ >> -$(RM) $@.objs >> >> @@ -68,8 +72,12 @@ $(SUBDIR)$(SLIBNAME): $(SUBDIR)$(SLIBNAME_WITH_MAJOR) >> >> $(SUBDIR)$(SLIBNAME_WITH_MAJOR): $(OBJS) $(SHLIBOBJS) $(SLIBOBJS) $(SUBDIR)lib$(NAME).ver >> $(SLIB_CREATE_DEF_CMD) >> +ifeq ($(AR_OBJS),true) >> $(Q)echo $$(filter %.o,$$^) > $$@.objs >> $$(LD) $(SHFLAGS) $(LDFLAGS) $(LDSOFLAGS) $$(LD_O) @$$@.objs $(FFEXTRALIBS) >> +else >> + $$(LD) $(SHFLAGS) $(LDFLAGS) $(LDSOFLAGS) $$(LD_O) $$(filter %.o,$$^) $(FFEXTRALIBS) >> +endif >> $(SLIB_EXTRA_CMD) >> -$(RM) $$@.objs >> >> -- >> 2.46.1 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-17 17:30 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-03-17 15:16 Gyan Doshi 2025-03-17 16:14 ` Zhao Zhili 2025-03-17 17:30 ` Gyan Doshi [this message] 2025-03-18 9:57 ` Martin Storsjö 2025-03-18 10:04 ` Gyan Doshi 2025-03-18 10:06 ` Gyan Doshi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=34ad06cb-4e8c-42bc-89bb-d3013d7e0cdd@gyani.pro \ --to=ffmpeg@gyani.pro \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git