From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B0BB4331E for ; Fri, 1 Jul 2022 13:30:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8147868B7CF; Fri, 1 Jul 2022 16:30:44 +0300 (EEST) Received: from mail.acc.umu.se (mail.acc.umu.se [130.239.18.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9600A68B7B3 for ; Fri, 1 Jul 2022 16:30:37 +0300 (EEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by amavisd-new (Postfix) with ESMTP id F2BC644B99 for ; Fri, 1 Jul 2022 15:30:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1656682236; bh=FiVNMSqrtckrQUudpVppUd+8qDjdmkKP5rNdpfFQlRw=; h=Subject:From:To:Date:In-Reply-To:References:From; b=khispOxgQZ1aTxO+OK3J3H/iXAfKClfS1RmAIj9Jp/eUP8kYmSk7S4Vtz1Nj4YoFK Yq1W+xFPGodQzOuOe/1mOMiigXwmRGUIIvFPez0xm2HO0HV9AW0wT/WfdE0BLcmjO0 KOdVcuVaKIUqefVfaOF2aK2ijI+HOsyOiz9wK42NOXvXWRUmilcIPa9Qc9hlS7ep1T FGgYF+2bdT0CCthWR8OKZuwFR5CBFxKvmOBdpFmnuj40mx1JvKSgGtGN6Iotw2gNYF lJ3ZBqaEnIyevkrvDsPhXFHmCyhU+HOdoupjTl0rDP5eMf2ZzHXOhMvWXD74Ekzg9L kYeFtmY52QK6w== Received: from debian.lan (unknown [IPv6:2a00:66c0:a::72c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tjoppen) by mail.acc.umu.se (Postfix) with ESMTPSA id 399B944B98 for ; Fri, 1 Jul 2022 15:30:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1656682236; bh=FiVNMSqrtckrQUudpVppUd+8qDjdmkKP5rNdpfFQlRw=; h=Subject:From:To:Date:In-Reply-To:References:From; b=khispOxgQZ1aTxO+OK3J3H/iXAfKClfS1RmAIj9Jp/eUP8kYmSk7S4Vtz1Nj4YoFK Yq1W+xFPGodQzOuOe/1mOMiigXwmRGUIIvFPez0xm2HO0HV9AW0wT/WfdE0BLcmjO0 KOdVcuVaKIUqefVfaOF2aK2ijI+HOsyOiz9wK42NOXvXWRUmilcIPa9Qc9hlS7ep1T FGgYF+2bdT0CCthWR8OKZuwFR5CBFxKvmOBdpFmnuj40mx1JvKSgGtGN6Iotw2gNYF lJ3ZBqaEnIyevkrvDsPhXFHmCyhU+HOdoupjTl0rDP5eMf2ZzHXOhMvWXD74Ekzg9L kYeFtmY52QK6w== Message-ID: <3491d39085a1efedb586dee966b6fa957ed2cb2b.camel@acc.umu.se> From: Tomas =?ISO-8859-1?Q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Fri, 01 Jul 2022 15:30:35 +0200 In-Reply-To: References: User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 01/18] avcodec/pthread_slice: Don't reinitialise initialised mutex X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: tor 2022-06-30 klockan 23:48 +0200 skrev Andreas Rheinhardt: > It results in undefined behaviour. Instead initialize the mutexes > and condition variables once during init (and check these > initializations). > > Also combine the corresponding mutex and condition variable > into one structure so that one can allocate their array > jointly. > Makes the code simpler to boot. Nice! Passes FATE and works with the threading patch I have on here as well. THREAD_TYPE=slice THREADS=4 and THREAD_TYPE=slice THREADS=1 /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".