From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 55AE943008 for ; Thu, 13 Jan 2022 07:08:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0E45D68BB4D; Thu, 13 Jan 2022 09:08:25 +0200 (EET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2229C68B9EE for ; Thu, 13 Jan 2022 09:08:16 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642057702; x=1673593702; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=KhFlaaWXZzIcygucFn4OQA8mxNPgmsWlp2u5coPnMys=; b=YGCz2xHYiFzDR9D89lK9VQqGRfCguPVC5unCLeAjUAJn1u2PHJ85AjD0 LUUw+Vfms1npckganTMjta/XFatUv2B07ohj+A731Cad6FWlss8YC5UIk ex0xPRMmSKG//clJX74oWF6HPZUOWPKvTnvyx9nbmTb/kiufAraR8xVqk eB/vhj3B/rnfJqJTF52Vd7rfIllV+88nvtv3XdcsU89lAWdcarepyrkae yZvpgIimsCPWN4Xi6vyd86dr4hwQ1PKgJKayfiBFm7GRbr7nihp4plTAV hLe8xAxk9st+ALtX77IS/A7WRvsLNNN4ClwxIqw7EqZxL/TjakBHf+TFq A==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="268298091" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="268298091" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 23:08:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="763179182" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 12 Jan 2022 23:08:14 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 23:08:13 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 23:08:13 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 23:08:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lUGXtsRrsYR5bOVO9v8+64bg4F6mwgwE0GuvLDc7BZBFoTc4uU0S6q1FZjojZn9ebwlCKxQKE2cRttJbCLPWp5yzdvxPWiatskML6i0DttL/PxBLSP3crFXg6gXspnQeQxmmLbsDqWU+MehZewPyMvnT3Y66vY4JzB/IWvGO7dEi+I2o1jnCKh2plrQTCO9gNmwap3aPvcvIhxCAdloTbLvV4qz0Hauaj9MUO2q8E+x00IIv79sOT4Mxi+FwBx2nv2X6PXcgd2w5bNYtN4nRCnmj5HmOpZ+4u6DjSFoy0bD2mBR+Mc5XqXPITT2FBtusQwUpv/TamCmwQy8oHDnwIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KhFlaaWXZzIcygucFn4OQA8mxNPgmsWlp2u5coPnMys=; b=VXk3n2asStW6rvKCrSwmR+aUnRrx7hVEBdRv6+QLx+8VDl+eR4gMAORrMhCexjsjGshJQavnc0y08fMVe0yFkRuP00NJXi0D5jjPJk8aat38pjA2rIyKR37iLTLliBZPPqSpU64n/0zUWo91h+8qBAPEEq6DGNlIsTv60+5uEas2bhWdUbr8QzG9o5HPOkWSmefMgDEBHqVj2RqzhoUGvqejbis1QPJHzfiM1walhB3TuKB42Tw56gBW7Je9dAtFzSi61iVaiqUwbheo38CdlQxA0FTF07YoahUC5uNP/7XB2TS2MhpExV3peUcDJE848ANFSWo7MH2ic9qLzyf/WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR11MB1666.namprd11.prod.outlook.com (2603:10b6:405:4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 07:08:12 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%6]) with mapi id 15.20.4867.012; Thu, 13 Jan 2022 07:08:12 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH V3 2/4] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv Thread-Index: AQHYCDxzf+epEy/8E0yZwj4M22oLV6xgiCsA Date: Thu, 13 Jan 2022 07:08:12 +0000 Message-ID: <348ef3698f0d335d24bf86e47f7f83163ab2ec8f.camel@intel.com> References: <20220113051221.66453-1-wenbin.chen@intel.com> <20220113051221.66453-2-wenbin.chen@intel.com> In-Reply-To: <20220113051221.66453-2-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4b935a9c-ddde-43d0-ecd8-08d9d663765b x-ms-traffictypediagnostic: BN6PR11MB1666:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SEkndNZcF6tE1CsPztcJsJD6xyIy7hgjOdNu40flPQC1qrVT0FKrU5HKtsDDssHjdreSjCr+zpptca7TR8AZFZ30Q8OSgJPOHZAYlTM0tfofKFyGEVZbul2VNo8Tp+8hp2sRr+pZQTEvUwm6YNAdH0Oi+TaZ7DwRVk0TZBrnw4OEciExEr6ksAVPHmOE8ZJWVglglH/3/8Q2ynTjgxIvnpTA1MMnCH3V/3Mrji2OKOzLAvVbgFtibUnQjeO/pmfPfQTfUoFQGIro9Q3drsLOUDJhM8PikBJoV+N4Z8nk3Hr29dizPkthLoCiOsOMKSJxczB77bTm0qO2ak1DSN7W1q2DQm3nOjjll8vlsZcnKxusGsfm+Kwec6CUk6YblOsdktg8Hzl17e0swxThtk5g9IWDbKcpITMSSRosYXSQXEugUs0gx2FYmUq/+iIYB3LoI+WXSe8SEQYOiUvcVBYSPEoEYZ7dCsKVS1msdLOeFmv451W/ZWxRwbPHV2J0YFm9uJB4rYaxqVn8e7q0Pe5IjMjLrIfCLmSyVp4fIQIo+blHQVK3VDk7oX2+fZPAnzW0cMd+uKQVfGclyezhyXkr6cNEm80GChnpl6Sci8/sEKpL2pA6PyBQSLZJ/LWrPG/QoTj335dJRnbURHVDzuN3iUG7U7xNe5f9I1hMEAWcmQLuwyJyvlaSguvynHVVEEHlBCHDwNMhO3Sww1SORbgjXIHTI0xA67U0dCJWIpn+tXo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6512007)(38100700002)(122000001)(91956017)(38070700005)(76116006)(6486002)(66946007)(508600001)(66476007)(64756008)(66556008)(2616005)(66446008)(2906002)(8936002)(316002)(26005)(5660300002)(186003)(6506007)(83380400001)(6916009)(36756003)(71200400001)(86362001)(82960400001)(8676002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bXBFQmtydkVMWTdTU1h1RHJValRpVW9hZyt0WGNNdEZrbE4zU2s3Y3plZGsz?= =?utf-8?B?OE9MM3U5Y0ZWY1Zvc3haRXBldElrRFJLTnkzUFpuVkRZWUtFMGlhR1loR2Vp?= =?utf-8?B?UExmYWNlNE93QW9PNWx3MEgwODQ2TFlBVlc2NUk0cDJVMWkzYmk1Qks5ejBF?= =?utf-8?B?ZUFIZkZwNVZaL1poS2IvNmZpemFqQXF4QldKVC9KbHFoUlplc25LSTAxVUhF?= =?utf-8?B?QnJTTHhpaXpqc2pBOVVUdUpXVERjL1lpNnFOV1U2S3dGdFBEbDhOOE8wekVy?= =?utf-8?B?QlVNM0lIazdtU1pBcHNrMWNSMm5FOXl1SEY0OUdWcGhnajB1czUyMzRzeXpG?= =?utf-8?B?ckpPdjNkVmNPQS8vdEp4K1QweDZ5dWp3NWhZMk9naU1sREtmYW56S3VNUXkv?= =?utf-8?B?WUZBVU1mY1VlUDdCMEExTDF3dnZLOEJzT1RqUTBpSHRmaUxaaVdUekhjUW5R?= =?utf-8?B?cG4wL05Sc0Z4SEsyaUZPTGhqQWREdjFQL29meW5vTkM3alRETVVIMU1Wd2t6?= =?utf-8?B?R0pQell0OHBSS0J6NHVtRXdSNkozN0lETzRVc3FQSHdFWmRjd1AyRmN2dk9D?= =?utf-8?B?YzVXbS9hdTJUR0NPWGN1amxHMGQxSXdPVVZMdlRQc2JVd0lIaDNucXNjTURV?= =?utf-8?B?bGVTWG4wbzFaU3pBRUtTQkVjeEtUYVZpaUVKNmU2RkZBWTRsaWhnOE1LSXF2?= =?utf-8?B?K2dHcStIK25XSU5EUFRuTU5qMHNZcUpWSFZQdzlRQldhbkhmNTBFL1k4Q3dl?= =?utf-8?B?QXpJSFVaZGlMbE4xUDFXUVFQQkt3ZmJiSis5Nmw5dnFGR3lwU2ZFQi9MNDha?= =?utf-8?B?YlJlNXVycmhiUk5rSEttMXkxY054QWN0WmYvYWg2SHk0Z2xPWE5IREFERU9B?= =?utf-8?B?Q05jdExDR3o2bkQzWFNjS3d5dlU4T0dhdUtOSkgrZGdXU3ZGV3F1cVVJdWFR?= =?utf-8?B?QTVhVlB2LzZReXcvL2w5dEwzK1BNZ29hRnlDUExZbktha2xUaG9Wdm9VWUg3?= =?utf-8?B?N1hSSHNiNUFmaUFQTUFGb2IrdzVXeVlGeGp5RWRTTHJ3VTVWL2d0bDAwNE5S?= =?utf-8?B?b2VBU0NCQUEzWW05MGdOeEV0TWFZOWhVL3lNY2ZDQjJpQkxxZGgvY0p5VlhB?= =?utf-8?B?bFBrVDRWTmpyRVFXUXlKa2xtVXFFL3dDZEQzYWJEV0dPQTJiQVhyZlZsbUR4?= =?utf-8?B?bnUzOUhrQ0o3TEoyZnBoKzUyWE1JT01pSm53cmtVV2MwNFdycWdURWZJSXNX?= =?utf-8?B?bGhUeVoxcnB1bFp0RW9FaWYvSHRERHM0ZGtxbXNaejJlRVgzbmVSd01oWWJE?= =?utf-8?B?MWtGMWc3eUc3Y0VzcUxwZk5iaFlEc3Arbk5qUGRhdUtGV0JsTHR1cHp5RmxL?= =?utf-8?B?MFp2K2tFTVVJdlNTdzlaQWxkb3MzSmd2ajVIemlsak84OG1lZnZwNjdobTZI?= =?utf-8?B?NHNuSS84UCszRnBLU1FmMW9uTWo5bURlNHlxVm81OG5vU2l0MVdGQnNySGsr?= =?utf-8?B?OTIwcVFqVTdpL1NHeENWZ3pIZm10T1RvbG15a3NNc1BQUmwzbndab2dnbERJ?= =?utf-8?B?c0ZiZzBmaFFBUzVCTnZBOHNmOCsrZ055aitDZDNNdkh3N3NUWjdOdk0ybjFC?= =?utf-8?B?UjZFbndBekxuM085TDVVQU5hcGJkSmorMnhydjZPcG1ySFllN3JMVlRuQWxI?= =?utf-8?B?R2ZFZGVpMzZVOS8ydzAwQ3VQMzNzOU5Xa3E5cmkzc1U0cFNOT2xlUVVjUkRG?= =?utf-8?B?ZnBRQ0FPK3lVZGhqZkJWZHNZYk9mVnRjK2RFem5paFc3K2pBQVI5OVdGM0RQ?= =?utf-8?B?VzNncGFPQUpUQ0NGV2tlMTIwS3VnR3prallBVk1RY0VEU0lJRFR3V1lvVUJj?= =?utf-8?B?UUJ4YXZ3YmsvWXFyUFNhUEhLcGl3bWQvcDVjWEVoR2IzT3l3OG90RS9xU2hi?= =?utf-8?B?Nm1CQysyMWk5RXgzanVGc3g3Uk5tQ0V4YmJydk9rQnQ0ekxSZTlkcjlLZmc1?= =?utf-8?B?czdISFVTWTl1Yi8ya0hHS1YrR3ZCSUxHZDBlZkpiRm5McjJVTDZsalQyTUtU?= =?utf-8?B?WG9XVEdPL1lNdW1NR2l1RHhzZmFWWnVLUEVwK1hHUzFKQmNVTjh1Zk8vMm1a?= =?utf-8?B?cEdERVF2VWprcEZ0VFZFKzVXSUpVYlN5UUVWQ3R0clE5eFpOMHpNREdoRElP?= =?utf-8?Q?DyHHWOMFHMozPr2p+MPMnQw=3D?= Content-ID: <19BF9A1494A8DB46983B0E262E78FB39@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b935a9c-ddde-43d0-ecd8-08d9d663765b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 07:08:12.4853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hXP09d5G/w4g7UStuxF92sZPM/P9y3kFa/Z7GrxSZqJATmioO/XuJ7AYKWnQH+qw6r4NWErOFPCuQndDAao5gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1666 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V3 2/4] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-01-13 at 13:12 +0800, Wenbin Chen wrote: > Add dblk_idc option to 264_qsv and hevc_qsv. Turining on this opion can > disable deblocking. > > Signed-off-by: Wenbin Chen > --- > doc/encoders.texi | 6 ++++++ > libavcodec/qsvenc.c | 8 ++++++++ > libavcodec/qsvenc.h | 3 +++ > 3 files changed, 17 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 68921fbd40..6fc94daa11 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -3299,6 +3299,9 @@ This flag controls changing of frame type from B to P. > @item @var{b_strategy} > This option controls usage of B frames as reference. > > +@item @var{dblk_idc} > +This option disable deblocking. It has value in range 0~2. > + > @item @var{cavlc} > If set, CAVLC is used; if unset, CABAC is used for encoding. > > @@ -3391,6 +3394,9 @@ Enable rate distortion optimization. > @item @var{max_frame_size} > Maximum encoded frame size in bytes. > > +@item @var{dblk_idc} > +This option disable deblocking. It has value in range 0~2. > + > @item @var{idr_interval} > Distance (in I-frames) between IDR frames. > @table @samp > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index b3728d28d5..e87b69369a 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -346,6 +346,10 @@ static void dump_video_param(AVCodecContext *avctx, > QSVEncContext *q, > av_log(avctx, AV_LOG_VERBOSE, "FrameRateExtD: %"PRIu32"; FrameRateExtN: > %"PRIu32" \n", > info->FrameInfo.FrameRateExtD, info->FrameInfo.FrameRateExtN); > > +#if QSV_HAVE_DISABLEDEBLOCKIDC > + av_log(avctx, AV_LOG_VERBOSE, "DisableDeblockingIdc: %"PRIu32" \n", co2- > >DisableDeblockingIdc); > +#endif > + > } > > static void dump_video_vp9_param(AVCodecContext *avctx, QSVEncContext *q, > @@ -889,6 +893,10 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco2.ExtBRC = q->extbrc ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > if (q->max_frame_size >= 0) > q->extco2.MaxFrameSize = q->max_frame_size; > +#if QSV_HAVE_DISABLEDEBLOCKIDC > + if(q->dblk_idc >= 0) > + q->extco2.DisableDeblockingIdc = q->dblk_idc; > +#endif > > #if QSV_VERSION_ATLEAST(1, 9) > if (avctx->qmin >= 0 && avctx->qmax >= 0 && avctx->qmin > avctx- > >qmax) { > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index 31516b8e55..aa49b35f07 100644 > --- a/libavcodec/qsvenc.h > +++ b/libavcodec/qsvenc.h > @@ -44,6 +44,7 @@ > > #define QSV_HAVE_TRELLIS QSV_VERSION_ATLEAST(1, 8) > #define QSV_HAVE_MAX_SLICE_SIZE QSV_VERSION_ATLEAST(1, 9) > +#define QSV_HAVE_DISABLEDEBLOCKIDC QSV_VERSION_ATLEAST(1, 9) > #define QSV_HAVE_BREF_TYPE QSV_VERSION_ATLEAST(1, 8) > > #define QSV_HAVE_LA QSV_VERSION_ATLEAST(1, 7) > @@ -97,6 +98,7 @@ > { "b_strategy", "Strategy to choose between I/P/B-frames", > OFFSET(qsv.b_strategy), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 1, VE > }, \ > { "forced_idr", "Forcing I frames as IDR > frames", OFFSET(qsv.forced_idr), AV_OPT_TYPE_BOOL,{ .i64 = > 0 }, 0, 1, VE }, \ > { "low_power", "enable low power mode(experimental: many limitations by mfx > version, BRC modes, etc.)", OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, { .i64 = > -1}, -1, 1, VE},\ > +{ "dblk_idc", "This option disable deblocking. It has value in range > 0~2.", OFFSET(qsv.dblk_idc), AV_OPT_TYPE_INT, { .i64 = -1 }, - > 1, 2, VE}, \ The range is 0~2 in the help string, however the minimal value is -1, which will confuse user. We may set both the default and minimal values to 0 here. Thanks Haihao > > extern const AVCodecHWConfigInternal *const ff_qsv_enc_hw_configs[]; > > @@ -169,6 +171,7 @@ typedef struct QSVEncContext { > int rdo; > int max_frame_size; > int max_slice_size; > + int dblk_idc; > > int tile_cols; > int tile_rows; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".