Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: Krzysztof Pyrkosz via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Cc: Krzysztof Pyrkosz <ffmpeg@szaka.eu>
Subject: Re: [FFmpeg-devel] [PATCH] swscale/aarch64/hscale.S Refactor hscale_16_to_15__fs_4
Date: Sun, 2 Mar 2025 01:03:44 +0200 (EET)
Message-ID: <34183bb-28d2-c340-bbf-dba42d724a87@martin.st> (raw)
In-Reply-To: <20250301125859.113969-2-ffmpeg@szaka.eu>

On Sat, 1 Mar 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote:

> Before/after:
>
> A78
> hscale_16_to_15__fs_4_dstW_8_neon:                      86.8 ( 1.72x)
> hscale_16_to_15__fs_4_dstW_24_neon:                    147.5 ( 2.73x)
> hscale_16_to_15__fs_4_dstW_128_neon:                   614.0 ( 3.14x)
> hscale_16_to_15__fs_4_dstW_144_neon:                   680.5 ( 3.18x)
> hscale_16_to_15__fs_4_dstW_256_neon:                  1193.2 ( 3.19x)
> hscale_16_to_15__fs_4_dstW_512_neon:                  2305.0 ( 3.27x)
>
> hscale_16_to_15__fs_4_dstW_8_neon:                      86.0 ( 1.74x)
> hscale_16_to_15__fs_4_dstW_24_neon:                    106.8 ( 3.78x)
> hscale_16_to_15__fs_4_dstW_128_neon:                   404.0 ( 4.81x)
> hscale_16_to_15__fs_4_dstW_144_neon:                   451.8 ( 4.80x)
> hscale_16_to_15__fs_4_dstW_256_neon:                   760.5 ( 5.06x)
> hscale_16_to_15__fs_4_dstW_512_neon:                  1520.0 ( 5.01x)
>
> A72
> hscale_16_to_15__fs_4_dstW_8_neon:                     156.8 ( 1.52x)
> hscale_16_to_15__fs_4_dstW_24_neon:                    217.8 ( 2.52x)
> hscale_16_to_15__fs_4_dstW_128_neon:                   906.8 ( 2.90x)
> hscale_16_to_15__fs_4_dstW_144_neon:                  1014.5 ( 2.91x)
> hscale_16_to_15__fs_4_dstW_256_neon:                  1751.5 ( 2.96x)
> hscale_16_to_15__fs_4_dstW_512_neon:                  3469.3 ( 2.97x)
>
> hscale_16_to_15__fs_4_dstW_8_neon:                     151.2 ( 1.54x)
> hscale_16_to_15__fs_4_dstW_24_neon:                    173.4 ( 3.15x)
> hscale_16_to_15__fs_4_dstW_128_neon:                   660.0 ( 3.98x)
> hscale_16_to_15__fs_4_dstW_144_neon:                   735.7 ( 4.00x)
> hscale_16_to_15__fs_4_dstW_256_neon:                  1273.5 ( 4.09x)
> hscale_16_to_15__fs_4_dstW_512_neon:                  2488.2 ( 4.16x)
> ---
>
> This patch removes the use of stack for temporary state and replaces
> interleaved ld4 loads with ld1.
> I'm aware the component is being deprecated, however in my use case
> (screen recording) the total time spent in this function is roughly 15%,
> the improvement is significant and worth sharing.

The patch looks good. I didn't follow it in exact detail, but it overall 
looks reasonable, and looks much better than the previous form. This 
description of what the patch does and why also is worth keeping in the 
final commit message, but as there's no need to repost the patch, I could 
just adjust the message myself before pushing it.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-03-01 23:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-01 12:59 Krzysztof Pyrkosz via ffmpeg-devel
2025-03-01 23:03 ` Martin Storsjö [this message]
2025-03-01 23:21   ` Martin Storsjö

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34183bb-28d2-c340-bbf-dba42d724a87@martin.st \
    --to=martin@martin.st \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=ffmpeg@szaka.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git