From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 22E5B4445D for ; Sat, 10 Sep 2022 19:17:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7509C68BB28; Sat, 10 Sep 2022 22:17:13 +0300 (EEST) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2FE4D68BB14 for ; Sat, 10 Sep 2022 22:17:07 +0300 (EEST) Received: by mail-ot1-f47.google.com with SMTP id p15-20020a056830130f00b006544f5228e3so3210973otq.2 for ; Sat, 10 Sep 2022 12:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ExsuIqekE5jvV/6W25uCn4FxuzEXh5rwhAHKm0wgyzQ=; b=lP042vv77uqGxtKldBMP5CQn6k8brgQVOYePaFaR3YLroMqwVUUtFvDjTfAWV9lL3W k6dsQtDjNr+vb0xaTYMF4DqAM90dQJ6YVTQBTc98Fq8F8M77FXQJKkIb3ovoeZu18VS5 aFMZX8xi1/3Dw8LE+6nFQJilW2SAx8q8biBQjuDHoUkogzipfjTVnoTf8q+a79xOaD7N xqJXI3uYsc6HKT29Rc8VmU65K2u1rdl+hGWIqkluJ9puxxLszSjdxyogPOI7nTDvmEhC SwoCJ8qIVSF1bA7Gzyh6T+Y5gsP3jlnXRAak/sEGhKzFHKr3OUv6uWb9nY8KYJTWdQ6X EE8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ExsuIqekE5jvV/6W25uCn4FxuzEXh5rwhAHKm0wgyzQ=; b=S6MOt+J3rBRhKyEGXZkDQb111WvrRSl9H89/vPx5gVWwjYbt0S1v65CttimTua1EXc eFVyPgk+y6joKmfKImKd/pQ1u1vevGx5W5f+b5YtY1FK3itMc7H5H0M4Jw4xw47q/e/X I1w1kvdCuDiG7O9LZBrNGw1hK4DqdnBCjyIQFYTV55wHuoL63CGRWbS2rp3GOVZYUlDz xCUcTH+myyTcw2oSUmC1Pc/PY+kvBHToEpSAdBRsIUDeaE9hvYuI7GhuGEuXzg7RpcCE u9K/gef975oSksSLib90jT9xIAbHhjWeV+755sKftxxWz2iIljLLjcxACny9/Jm1yd0w O+TQ== X-Gm-Message-State: ACgBeo1XXYRU7ucKIATNxde50sdB9O6yGyWcIC6djp2vG3Eldim+Kp3e lypd5qreVmT608EPOwSeNDemEQT3cbE= X-Google-Smtp-Source: AA6agR5qHZ/fZJUq+5Rr8vVzqrSPZR1bhpxaK9G1pm1nmPD5sjZNTweZwkXktbiDLxByqf3c7SWzIQ== X-Received: by 2002:a9d:f43:0:b0:638:c3c4:73ee with SMTP id 61-20020a9d0f43000000b00638c3c473eemr7533921ott.186.1662837425630; Sat, 10 Sep 2022 12:17:05 -0700 (PDT) Received: from [192.168.0.13] ([191.97.187.183]) by smtp.gmail.com with ESMTPSA id p13-20020a056830130d00b006391adb6034sm1730617otq.72.2022.09.10.12.17.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Sep 2022 12:17:05 -0700 (PDT) Message-ID: <3404efdf-af40-201a-ad29-3e5c0e2028ee@gmail.com> Date: Sat, 10 Sep 2022 16:17:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <75911db2-2335-ec54-02c7-7ef77f7b5649@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec: Micronas SC-4 decoder and parser X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/10/2022 4:11 PM, Paul B Mahol wrote: > On 9/10/22, James Almer wrote: >> On 9/10/2022 3:27 PM, Paul B Mahol wrote: >>> Patches attached. >> >> This looks like it would fit in adpcm.c as an ADPCM codec. > > Nope nibble, step, prediction. All terminology taken straight out of adpcm, down to the decoding process. The entire decoder can surely be implemented in adpcm.c and named adpcm_msc4, and unless you have a good reason not to I'd really like you doing so, because once the AVCodecID is added renaming it becomes a PITA. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".