From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec: Micronas SC-4 decoder and parser
Date: Sat, 10 Sep 2022 16:17:05 -0300
Message-ID: <3404efdf-af40-201a-ad29-3e5c0e2028ee@gmail.com> (raw)
In-Reply-To: <CAPYw7P6XQciXWXfAcC+0zf7L2fUTaDGY1Bg76Ba-dOssg=PPdA@mail.gmail.com>
On 9/10/2022 4:11 PM, Paul B Mahol wrote:
> On 9/10/22, James Almer <jamrial@gmail.com> wrote:
>> On 9/10/2022 3:27 PM, Paul B Mahol wrote:
>>> Patches attached.
>>
>> This looks like it would fit in adpcm.c as an ADPCM codec.
>
> Nope
nibble, step, prediction. All terminology taken straight out of adpcm,
down to the decoding process.
The entire decoder can surely be implemented in adpcm.c and named
adpcm_msc4, and unless you have a good reason not to I'd really like you
doing so, because once the AVCodecID is added renaming it becomes a PITA.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-10 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 18:27 Paul B Mahol
2022-09-10 19:08 ` James Almer
2022-09-10 19:11 ` Paul B Mahol
2022-09-10 19:17 ` James Almer [this message]
2022-09-10 19:43 ` Paul B Mahol
2022-09-10 19:46 ` Paul B Mahol
2022-09-15 17:14 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3404efdf-af40-201a-ad29-3e5c0e2028ee@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git