From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1716140047 for ; Tue, 18 Jan 2022 08:08:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACDAD68B0A8; Tue, 18 Jan 2022 10:08:47 +0200 (EET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 59DBF68AEE4 for ; Tue, 18 Jan 2022 10:08:39 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642493325; x=1674029325; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=w66qQNUzi0v5snt19Bcx/aL6R3lhuHGzwpOehp8fFH4=; b=gnHCELFOOqao6ko6DKxGjDENCBhUaCaGHsYoEBcZSZ6uWlSX1ieRGv7v Bz/o1QBTa0iWJJI5+Nvfn0FPc+pNJJRJVaoUBH7FRi0aFcDNQgv8AloDh M3GDHmYDK5tqe/qj0bIwbNOle4vpuutPjW3azasDIPdv/wMd/0k8ZoI+t 6rWVBN2X7tf2h1pxKGjRYQCPeKKyKKHZ0EGTZ1dTKYZpxwQ8KZsjZ76Wd 9Dkur8c1eplNyKUEgbGfnfryY1wrrVj8gkqfjjuDKpb9vxspSBVBWehGO fjHc+o93OZlV6xhYPANRfKITtyRyuY5OGlMEjP9mQVqNlljnmxhcOjmse A==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="331112973" X-IronPort-AV: E=Sophos;i="5.88,296,1635231600"; d="scan'208";a="331112973" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 00:08:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,296,1635231600"; d="scan'208";a="474687709" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 18 Jan 2022 00:08:35 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 00:08:34 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 18 Jan 2022 00:08:34 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 18 Jan 2022 00:08:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIXer4qErr6Q/B4Zf4BLL2YC9jn//YIBz8O/rO+jSf0CvDbBB8NHpNfiq9YpCywCPAIHCynrTo4lt+i0xw3jUnyO1v/71+HuSqYhudm2M6kHMuxjkUwk1I4M/Cj7dTKgNleDS9qH9Jyql2VzNEsqJes0++CAjDjDiHPCUtHSZOYYaNlEVE2Ps1cBVLZRBOIc1lg8xhxXIujaWWIh2tmc4iXhqnpkCvxoLsYBaNv4pIrhjpLuITg1Zfi4aS5EkFAlLwGzNdVAikAOGt51W1RP0iWN9wDXrIrPawoll4tayndbdHJYeKuRBSKw4KZiu9jcxnU4yr0m2ylihGTj1+aUSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w66qQNUzi0v5snt19Bcx/aL6R3lhuHGzwpOehp8fFH4=; b=d5sgaXEfuTD+4UA1jv3qARjNVUqA1wWr/fTqS0eb+OIHvGfBXLgyDDxTaih5XG/zMz6gzsniET2SPl5Ap6hbI8iz7CWGW0QO0wHSWN1IqHQP/WhyAM2gTrRnn80pscx9dvoyIgxaAKLy0GqS0ncdO+D7VwoPAcsrPUGk5D+/2ekJAV9FpmpPHkuB3VwcvLDkSKTDFdNISGRD1ntq7dtbIKdhB32BXcsgDL28QXpvS9uaQFD+RuHeeXIDWCJRv6sKjKjexSri4z8C0GL4k/XZru0n/1pQC1uH4tVGZ0JYE54QlnlOM5kCCpTKryfHvJFCsE/cKLOHD1FPWc809U54Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DM6PR11MB2570.namprd11.prod.outlook.com (2603:10b6:5:ce::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Tue, 18 Jan 2022 08:08:32 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%5]) with mapi id 15.20.4888.014; Tue, 18 Jan 2022 08:08:32 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9 Thread-Index: AQHYCEDYbxvbrcgxykCDVV/OtIl66qxm6FKAgAAjO4CAAAX8AIAAFPqAgAFOIwA= Date: Tue, 18 Jan 2022 08:08:31 +0000 Message-ID: <33176c6889d9e77298ceefcf7ab049edafff00d2.camel@intel.com> References: <20220113054525.14057-1-haihao.xiang@intel.com> <2de74c97e30007697825af8d68df3fdf5270350c.camel@intel.com> <1c674eab-97ba-b054-f12b-4bf6ad091cc9@gmail.com> In-Reply-To: <1c674eab-97ba-b054-f12b-4bf6ad091cc9@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc9b0162-4c6f-40d0-6e5c-08d9da59b7e2 x-ms-traffictypediagnostic: DM6PR11MB2570:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5qJrw2kO8wDdRx4Tkr6dVvPgvccVL6jBJWmOS++5AZR4EswKWlj89eXvKka1mZtyB0XIsDwDK9DkTHhbMJJ8e9KvWGrQhKi1wRYb310l0jzOnLP4KLhjgXAvWjTbvOrUoN7uvJyXNVtVhttzovkL5ezJg+6qF1otYjJKcwABwxQlg8d4+hsAQwvWklJHyIk9jGEdXBbK7GyYd5I6T5sCHmO+07fNbeMztNiKJnrxoU3VV3xmikvzdMD+4o+QMhjyM6HaYBoSxz4QF0Fpz/caZbU/f1Ed+mNl5pRV+JxqOAdkX97zlEuTgg2lSi9cfIBIShcwBwgGd2z+xnJRtqbGQQiZJtM4P3d9sdMVyRg/zVhyi8wQ4Gp6G1e6oDv3RnNj+KIjbYiU1aUHUwH+8lZZUnQwau2gtYgBbZTK0Bz/kBA5k2QKf+IY+KmTO8iKHM+2J08HiC9RFxv4REVgviY83MRAGZsntvaDSYNIjCI+6zAmFzNUW7/zO2oC4STAcdFSHaF0bzB0Iy3gyNrzHJkr84gqZ1Cd3Ly/WuWeha1N/j/ilVkJZPJuNQ9vVqPHp33WMuTjOvWSktwX0BruHKRLHJA6VZowSJCEFoKh3d/9II+I1NZDLdqNL1663uIy6xaplF30H4GvcbkBWPkj6TCb6yXqPO1ah+d0lstN2Iwk2YOaHNnlg9FONKIMrOwaMiE75aoiyqCeApy5l0EpY3royqL4crMasc0sHt1aNrnXNuvJ0pupWjYyRlSXdCT3V2DhdB99cIm4bdxR7oXaGAkokJd9T+Y/t9S+NxkNun9oCzyS9xM1PZCavzzwnTacxoBR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(38070700005)(53546011)(26005)(91956017)(186003)(76116006)(8936002)(508600001)(6506007)(38100700002)(6916009)(8676002)(66476007)(122000001)(6486002)(6512007)(66946007)(2906002)(316002)(2616005)(66446008)(82960400001)(64756008)(966005)(86362001)(66556008)(5660300002)(36756003)(71200400001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SzVkS2N6MnJWTXRMR0FpSCtSY2d5Q3NBeVRUcG5JQWxndmpCTGMveWprMHd2?= =?utf-8?B?UUhMa2Z3SXE1VmpvVktuV0hOMlVNeExwQ0ZiNzQyRVg5T3NaYU9FVkN4dmxa?= =?utf-8?B?aTNxdHJiVHNYN2VrMlNJUjhNdThGOEVCZEtXZ0NPb09Oekt6T2loZ3FZcStZ?= =?utf-8?B?TTNkYUluMUdnNjh0SXM5VXlEQlNFOFIzUzg5NktvNnRoY1ZQZ1cwMVhkL0VF?= =?utf-8?B?T3ZUVHNQSXZ1YUlBYlJTZXVQZWhrYjRHZTBwd09KRC9hYXFWMDVZcDljRkJu?= =?utf-8?B?ejJuMFpWM1haRUx1Y3JWdmo2VFZrTjVqcjZGbzVhOTVxVGZsR3JxM09QR09q?= =?utf-8?B?RGVRcDYyRU9XdFVhcWpCT3Q1NCtabW5ROGVuMlRLc2VFWE1uWll4d0NIaUdp?= =?utf-8?B?dUFLd21FWjZDMDlyVFRwNHlOc1ZCcDNFSHhnTm9lR3BNc3Q0RmNpemhZMG5G?= =?utf-8?B?VlVWWjkrSlpvcC90bFZ5MUpLY1VhcFB0NVdqTG1nbWZqWVg2TmExV0Uxd01p?= =?utf-8?B?VTN0ZEJML1lMb1hTRkVRZ3hMQ0toYlJVZ1IveWpPN3IrU0VxYmRtRkVERlRE?= =?utf-8?B?Y0FMcEVraUJNbjUwcFAwbGppc21GNlg1NEh3MlZ2WWlHWFZCclNOUE9NNXFV?= =?utf-8?B?M0dDWFlDbDh4Rzh0YzdnNlgzSjAvakNqNE16dzZHMndRUEluTGI5Nnp1dG9n?= =?utf-8?B?S1IvMGt2Nmo5OXBDMmlyck03TithaUNaRXd0MFVZWS9tbU9jbjdWclhsVUpH?= =?utf-8?B?SzNoelZSWVZvODFCWC81M0MwWGgyaHRRMUtnWTVQNTh0dFFMdjVTNWJCM1lV?= =?utf-8?B?aGpteFpFWHM1Z205TXhhZHUraXJzTEkra1E0LzQwVDVtVThCQ25IbThRV0xJ?= =?utf-8?B?RjJoZ2JXdmNkUGg3eDljaVY2WW56TTlJRm9sQ2lDV3lxMFZPOERHVENNaFQ0?= =?utf-8?B?Z1VVZTcycE1hOTVYelpiZkx2eHRhdFM1RVo3MmZRZVdnVFBNTG44ZnM3YWZ2?= =?utf-8?B?WmgvV1hqSDJ5MVJHMzBkSEo3OFJsaEN0cS9naGk4VVlmMkFDVkJLMmxnYWNK?= =?utf-8?B?RlE5SEFHL3pTeWxLdWxrRUQrbnFsQ1M4YVgxa0tBbXFiTWVoUExGc0QvbEla?= =?utf-8?B?M1o3d3hKdHoxa1h6Tzl5K01YU2VqVWN2dG95RGF3VjNkV3pOYWRNODk3OXQ5?= =?utf-8?B?eXZYSHdrRTlBdXNKVDRvVFRWb211czkxbFlrSENSbGt3cVdPdUgyRDV1aFNW?= =?utf-8?B?WjEyRzV4UWEyRTJ5cTNMNUM1dnJDaHU4RUtzODNQdE01V2lhUFR1ZGE4YXRL?= =?utf-8?B?cThDTUFzUlgzYlBBWU9mWmVDc3BsWng3QW9QelpzTkpoS3RrTjBmM2VOTXVx?= =?utf-8?B?MmN6RzlwSTM3eXppL29Rc1FadDJwbGhDT0JmVjlSazl4L1dBSU1SbGQvQVZW?= =?utf-8?B?SEd5RGxvK1dMM0lURCtZanBGSjAxbXJEVzhjY0JqN1BqeDN3RC9HMDB0N1lL?= =?utf-8?B?eUllT05qbWxtQXY5VC9IRGIzWWtLM0VlOGlkNGd2UUszU1BoQzdOYTRhQWJv?= =?utf-8?B?bGlVcDJneGEvWDI2N1B6UW4yYlhPSlIrV2hlelArN2pTN0FlSnVSaTdKOWpu?= =?utf-8?B?d3BxQWl1MWxROGRuSWNLR0dJbHFZb3hwaWgxTTZ4aWx3WjhpWHV1Tm5VaE1p?= =?utf-8?B?b1c5QlZHL2Y3S05OU0pIRk9OS2E2bDh5QlZJVzI3Zk5MdWNWK3lCaWJmTk1a?= =?utf-8?B?d1VTckJYUHJJd3J4MGFCcll3U20vajZYUGNPOEM3UjRGQ05GTlZZR3hYY3or?= =?utf-8?B?ZFA2YlhHLzFJUmp6d2xROWxoVERmMU1CckxZdmt6SUFXUzc5UGxsNTJaREl2?= =?utf-8?B?czNnZEpVU1ZwV0tQU2hrNlY4aEpBY0piRWpFbjY4VEZpV1JNaktSdVpPeVhI?= =?utf-8?B?eW1JUlpEazArYnZ6TnV5cUZvOFM1MWcyK2ZCNHRTblBuTFlJQVRWNUkvVi9L?= =?utf-8?B?VGxrWkJ4NFFNMHI4bHI5MS92cllNQ3BwRHNldEhwbit1Rm1ZbEpVeUZuclV1?= =?utf-8?B?V2VtdW1XTE84Wm9tWGZTNXZsc1BMVUhvdUF2SzkrNGFhWFZWM256czJCb3Vh?= =?utf-8?B?dEFyQnA0aCthVzl3R0UySWl1Wko4bVQvb3gzaFdobDJEOHVZdThCWVFHYnRV?= =?utf-8?Q?SkHV1QB2zDenqt8l/JeqBdk=3D?= Content-ID: <5EE90F24E37BE443840A91C6E684C30C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc9b0162-4c6f-40d0-6e5c-08d9da59b7e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2022 08:08:32.0387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XlByD0ppN3fskYwnTSxGdTg1ZbaZrMrVbRTiFlX574j23XoS94DfRdgjAMy1gv9Njjh0gyLPYW6SxvDLe3oeUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2570 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-01-17 at 09:12 -0300, James Almer wrote: > On 1/17/2022 7:57 AM, Soft Works wrote: > > > > > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of > > > mypopy@gmail.com > > > Sent: Monday, January 17, 2022 11:36 AM > > > To: FFmpeg development discussions and patches > > > Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding > > > support > > > for VP9 > > > > > > On Mon, Jan 17, 2022 at 4:30 PM Xiang, Haihao > > > wrote: > > > > > > > > On Thu, 2022-01-13 at 13:45 +0800, Haihao Xiang wrote: > > > > > Add -tile_rows and -tile_cols options to specify the number of tile > > > > > rows and columns > > > > > > > > > > Signed-off-by: Haihao Xiang > > > > > --- > > > > > v2: add option descriptions in the doc > > > > > > > > > > doc/encoders.texi | 6 ++++++ > > > > > libavcodec/qsvenc.c | 4 ++++ > > > > > libavcodec/qsvenc.h | 1 + > > > > > libavcodec/qsvenc_vp9.c | 10 ++++++++++ > > > > > 4 files changed, 21 insertions(+) > > > > > > > > > > diff --git a/doc/encoders.texi b/doc/encoders.texi > > > > > index 7cc8be1209..a4176089d5 100644 > > > > > --- a/doc/encoders.texi > > > > > +++ b/doc/encoders.texi > > > > > @@ -3457,6 +3457,12 @@ These options are used by vp9_qsv > > > > > @item profile2 > > > > > @item profile3 > > > > > @end table > > > > > + > > > > > +@item @var{tile_cols} > > > > > +Number of columns for tiled encoding (requires libmfx >= 1.29). > > > > > + > > > > > +@item @var{tile_rows} > > > > > +Number of rows for tiled encoding (requires libmfx >= 1.29). > > > > > @end table > > > > > > > > > > @section snow > > > > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > > > > > index 4e7a15f060..4cbc9ff4dc 100644 > > > > > --- a/libavcodec/qsvenc.c > > > > > +++ b/libavcodec/qsvenc.c > > > > > @@ -939,6 +939,10 @@ static int init_video_param(AVCodecContext > > > > > *avctx, > > > > > QSVEncContext *q) > > > > > q->extvp9param.Header.BufferId = MFX_EXTBUFF_VP9_PARAM; > > > > > q->extvp9param.Header.BufferSz = sizeof(q->extvp9param); > > > > > q->extvp9param.WriteIVFHeaders = MFX_CODINGOPTION_OFF; > > > > > +#if QSV_HAVE_EXT_VP9_TILES > > > > > + q->extvp9param.NumTileColumns = q->tile_cols; > > > > > + q->extvp9param.NumTileRows = q->tile_rows; > > > > > +#endif > > > > > q->extparam_internal[q->nb_extparam_internal++] = > > > > > (mfxExtBuffer > > > > > > *)&q- > > > > > > extvp9param; > > > > > > > > > > } > > > > > #endif > > > > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > > > > > index 31516b8e55..00ee52a5d1 100644 > > > > > --- a/libavcodec/qsvenc.h > > > > > +++ b/libavcodec/qsvenc.h > > > > > @@ -41,6 +41,7 @@ > > > > > > > > > > #define QSV_HAVE_EXT_HEVC_TILES QSV_VERSION_ATLEAST(1, 13) > > > > > #define QSV_HAVE_EXT_VP9_PARAM QSV_VERSION_ATLEAST(1, 26) > > > > > +#define QSV_HAVE_EXT_VP9_TILES QSV_VERSION_ATLEAST(1, 29) > > > > > > > > > > #define QSV_HAVE_TRELLIS QSV_VERSION_ATLEAST(1, 8) > > > > > #define QSV_HAVE_MAX_SLICE_SIZE QSV_VERSION_ATLEAST(1, 9) > > > > > diff --git a/libavcodec/qsvenc_vp9.c b/libavcodec/qsvenc_vp9.c > > > > > index 9329990d11..1168ddda0e 100644 > > > > > --- a/libavcodec/qsvenc_vp9.c > > > > > +++ b/libavcodec/qsvenc_vp9.c > > > > > @@ -73,6 +73,16 @@ static const AVOption options[] = { > > > > > { "profile2", NULL, 0, AV_OPT_TYPE_CONST, { > > > > > .i64 > > > > > > = > > > > > MFX_PROFILE_VP9_2 }, INT_MIN, INT_MAX, VE, "profile" }, > > > > > { "profile3", NULL, 0, AV_OPT_TYPE_CONST, { > > > > > .i64 > > > > > > = > > > > > MFX_PROFILE_VP9_3 }, INT_MIN, INT_MAX, VE, "profile" }, > > > > > > > > > > +#if QSV_HAVE_EXT_VP9_TILES > > > > > + /* The minimum tile width in luma pixels is 256, set maximum > > > > > > tile_cols to > > > > > 32 for 8K video */ > > > > > + { "tile_cols", "Number of columns for tiled > > > > > encoding", OFFSET(qsv.tile_cols), AV_OPT_TYPE_INT, { .i64 = 0 }, > > > > > 0, > > > > > > 32, > > > > > VE }, > > > > > + /* Set maximum tile_rows to 4 per VP9 spec */ > > > > > + { "tile_rows", "Number of rows for tiled > > > > > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 > > > > > }, > > > > > > 0, 4, > > > > > VE }, > > > > > +#else > > > > > + { "tile_cols", "(not > > > > > supported)", OFFSET(qsv.tile_cols), > > > > > > AV_OPT_TYPE_INT, > > > > > { .i64 = 0 }, 0, 0, VE }, > > > > > + { "tile_rows", "(not > > > > > supported)", OFFSET(qsv.tile_rows), > > > > > > AV_OPT_TYPE_INT, > > > > > { .i64 = 0 }, 0, 0, VE }, > > > > > +#endif > > > > > + > > > > > > perfer one option like "-tile rows x cols" than two options like > > > > The example is invalid. (spaces) > > > > > "-tile_rows row -tile_cols col" > > > > This way, the options are typed, have min, max and default values, > > without needing any code to write and maintain. > > > > if you mean "-tile rowsxcols", there's no option type for this, > > unless you would want to mis-use the video size type for it. > > Otherwise you'd need to make it string and write all the parsing > > and checking code for it. > > We already have code for this. see libaomenc. Thanks for the comments. There are -tile_rows and -tile_cols options for hevc_qsv encoder, I'd like to keep the style consistent in qsv encoders and prefer to add the two options for vp9 encoder too. BRs Haihao > > > Do you think that it would be worth the effort? > > > > Also, in most use cases, you will probably have rows or cols, > > rather than both.. > > > > sw > > > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".