[FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge

[FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge

[Matthias Dressel]

From: Matthias Dressel <code@deadcode.eu>

check_func() might return NULL, in which case the function is not to be
benched. Introduced in cc679054c715acda9438e566b8de3a9eba421ac3.

Signed-off-by: Matthias Dressel <code@deadcode.eu>
---
 tests/checkasm/hevc_sao.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
index cfee2ddf50..94aa1942e1 100644
--- a/tests/checkasm/hevc_sao.c
+++ b/tests/checkasm/hevc_sao.c
@@ -134,8 +134,8 @@ static void check_sao_edge(HEVCDSPContext *h, int bit_depth)
                     if (memcmp(dst0 + j*stride, dst1 + j*stride, w*SIZEOF_PIXEL))
                         fail();
                 }
+                bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
             }
-            bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
         }
     }
 }
-- 
2.41.0




_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge

[Martin Storsjö via ffmpeg-devel]

On Thu, 24 Aug 2023, Matthias Dressel wrote:

> From: Matthias Dressel <code@deadcode.eu>
>
> check_func() might return NULL, in which case the function is not to be
> benched. Introduced in cc679054c715acda9438e566b8de3a9eba421ac3.
>
> Signed-off-by: Matthias Dressel <code@deadcode.eu>
> ---
> tests/checkasm/hevc_sao.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
> index cfee2ddf50..94aa1942e1 100644
> --- a/tests/checkasm/hevc_sao.c
> +++ b/tests/checkasm/hevc_sao.c
> @@ -134,8 +134,8 @@ static void check_sao_edge(HEVCDSPContext *h, int bit_depth)
>                     if (memcmp(dst0 + j*stride, dst1 + j*stride, w*SIZEOF_PIXEL))
>                         fail();
>                 }
> +                bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
>             }
> -            bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
>         }
>     }
> }
> -- 
> 2.41.0

LGTM, pushed.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".