From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A744144AB9 for ; Wed, 2 Nov 2022 21:36:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4194268BED0; Wed, 2 Nov 2022 23:36:44 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A32D668BE9A for ; Wed, 2 Nov 2022 23:36:37 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 2A2LaZUn027305-2A2LaZUo027305 for ; Wed, 2 Nov 2022 23:36:35 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 45A9FA146A for ; Wed, 2 Nov 2022 23:36:34 +0200 (EET) Date: Wed, 2 Nov 2022 23:36:34 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20221102213127.GJ1814017@pb2> Message-ID: <32e59941-b3e-6595-ebc4-b2111d218ac@martin.st> References: <20221102210239.1689-1-michael@niedermayer.cc> <20221102210239.1689-2-michael@niedermayer.cc> <20221102210714.GI1814017@pb2> <20221102213127.GJ1814017@pb2> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 2/2] swscale/output: Bias 16bps output calculations to improve non overflowing range for GBRP16/GBRPF32 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2 Nov 2022, Michael Niedermayer wrote: > On Wed, Nov 02, 2022 at 10:16:57PM +0100, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Wed, Nov 02, 2022 at 10:02:39PM +0100, Michael Niedermayer wrote: >>>> Fixes: integer overflow >>>> Signed-off-by: Michael Niedermayer >>>> --- >>>> libswscale/output.c | 25 +++++++++++-------------- >>>> libswscale/x86/output.asm | 16 +++++++++++++++- >>>> 2 files changed, 26 insertions(+), 15 deletions(-) >>> >>> Note, these corner case overflows could affect some of the similary >>> implemented cases that are not depth 16 too >>> >>> ill fix them if issues are replicated >>> >> >> The checkasm-sw_gbrp runs into many overflows (when run under UBSan); >> e.g. fate.ffmpeg.org tells me of an issue in line 2289. Said line is not >> touched in your commits. > > checkasm-sw_gbrp feeds random data widely outside sane ranges in. > the test certainly makes no sense for testing asm. There is no point > in matching C for widely invalid cases. Of cousre we shouldnt overflow > if any of this can be triggered with valid and real input (which probably > can be done in some cases) Patches for the checkasm tests, to make them produce sane input values in the correct ranges, are very much welcome! // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".