From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ECD7A46F49 for ; Sun, 23 Jul 2023 11:48:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EAB0168C5E2; Sun, 23 Jul 2023 14:48:54 +0300 (EEST) Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 93C0868C28B for ; Sun, 23 Jul 2023 14:48:48 +0300 (EEST) Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-55e1a9ff9d4so2756351eaf.1 for ; Sun, 23 Jul 2023 04:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690112926; x=1690717726; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=wugGgvnmXFcox2P9OMennqGXmmXpfl25dK/LlHThzws=; b=BD1TH+cB32puGxOMJUx+gW84hvtGjVK8ODAnAQQ+QRrHsyjoxwulSapzqo4JTOl2bH yjvYLBQEmm32hfAO14jzA04BRJVdG3XsbtIt95rMcJu4oQMr8B48zYg9OmHsT12JCiwT vNXRs5FB7g5ll8my3h/IvzHSEoUgIxh+cbTWJaudyFdKjHX6gX92ttdlWsDxkqJjj4bd CH5eXOZY6jYB+IIsnOUK/zPC0iVqqpl1u+gy8Oa5E6CvBFwEAc+2h8nBzhc+lzswNiJN 9cy4Dp+l1Q5TGWzHwATAsEQOkdvHH2gMyVjnGhqDm7/ajCOSEMb37rREXyvYudfg6/3n XzpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690112926; x=1690717726; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wugGgvnmXFcox2P9OMennqGXmmXpfl25dK/LlHThzws=; b=hcyhzOk03kIe9IBvFLNxTUtulqNUjBo0IhNOhPf5Gcin12Qjgzu2C8LTWDMUezzaHQ yQHmCSFUac3YQ6trD4l1XBoEx95RLkYfehJB5H9U838QyM3XKrXCaijRFcDvknid2bNu I5pMN3cZEzxCaJU3TETjIiTmenzUUyK0Ps010OOGgiUyJoKBwZLu+68qcWU+rjhQNf8k xkZIjdoa/2jKYk9Q5Z2CskOI41CbWYBo3uExrYhjY5/4HjgNG9wzaFBSiHGjBfzj/ynO BkfBtDUyKDCT9RIRueLxIu0vroaL2W6ChW/yo7+rW3FaNyY1VyoSS+umdb6r0LiRHnb6 iOJw== X-Gm-Message-State: ABy/qLaVCmz0sXLNfvAJLJpF86L4rQdwUHuVeIuyVJIbCgozv1OGg8qE cukVNlDlkTKu9D4k6IeRf2zSWyJr4s4= X-Google-Smtp-Source: APBJJlF+Nh8PW2pbE6V+ifgeMzlKGQfFFljSbjXj+aZSuuLf0saP7IxNO2xlK4EjcjRNuOPHrqxMmg== X-Received: by 2002:a05:6808:181a:b0:3a0:4a7c:ca4e with SMTP id bh26-20020a056808181a00b003a04a7cca4emr5471546oib.21.1690112925795; Sun, 23 Jul 2023 04:48:45 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id bj39-20020a05680819a700b003a478233094sm3121236oib.56.2023.07.23.04.48.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jul 2023 04:48:45 -0700 (PDT) Message-ID: <3223f60f-258d-6ebc-6f6a-cf7cb4cd8a2d@gmail.com> Date: Sun, 23 Jul 2023 08:48:57 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: ffmpeg-devel@ffmpeg.org References: <20230720203415.41757-1-jamrial@gmail.com> <20230720203415.41757-7-jamrial@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 07/13] avcodec/hevcdec: check for DOVI configuration record in AVCodecContext side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/23/2023 5:40 AM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> libavcodec/hevcdec.c | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c >> index fcf19b4eb6..0d659e4c55 100644 >> --- a/libavcodec/hevcdec.c >> +++ b/libavcodec/hevcdec.c >> @@ -3403,8 +3403,12 @@ static int hevc_decode_frame(AVCodecContext *avctx, AVFrame *rframe, >> } >> >> sd = av_packet_get_side_data(avpkt, AV_PKT_DATA_DOVI_CONF, &sd_size); >> - if (sd && sd_size > 0) >> + if (sd && sd_size > 0) { >> + av_log(avctx, AV_LOG_WARNING, >> + "passing a DOVI configuration record through packet side data is " >> + "deprecated and will stop working soon. Use AVCodecContext side data\n"); > > Doesn't this remove functionality that might be useful to some users > (namely the functionality to send new DOVI metadata)? Is this a valid scenario? lavf only exports this side data during read_header(). A change in DOVI profile would mean a brand new CVS, and afaik we require a new decoder to be fired up for this. > >> ff_dovi_update_cfg(&s->dovi_ctx, (AVDOVIDecoderConfigurationRecord *) sd); >> + } >> >> s->ref = NULL; >> ret = decode_nal_units(s, avpkt->data, avpkt->size); >> @@ -3707,12 +3711,18 @@ static av_cold int hevc_decode_init(AVCodecContext *avctx) >> atomic_init(&s->wpp_err, 0); >> >> if (!avctx->internal->is_copy) { >> + AVPacketSideData *sd; >> + >> if (avctx->extradata_size > 0 && avctx->extradata) { >> ret = hevc_decode_extradata(s, avctx->extradata, avctx->extradata_size, 1); >> if (ret < 0) { >> return ret; >> } >> } >> + >> + sd = av_packet_get_side_data_from_set(&avctx->side_data_set, AV_PKT_DATA_DOVI_CONF); >> + if (sd && sd->size > 0) >> + ff_dovi_update_cfg(&s->dovi_ctx, (AVDOVIDecoderConfigurationRecord *) sd->data); >> } >> >> return 0; > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".