From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 785D14365A for ; Mon, 20 Jun 2022 21:44:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A82868B60C; Tue, 21 Jun 2022 00:44:35 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AA2C768B1AE for ; Tue, 21 Jun 2022 00:44:28 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 085D7E71FA for ; Mon, 20 Jun 2022 23:44:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uryLLCML0Vff for ; Mon, 20 Jun 2022 23:44:27 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 33F63E6FA6 for ; Mon, 20 Jun 2022 23:44:27 +0200 (CEST) Date: Mon, 20 Jun 2022 23:44:27 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20220613210455.31216-1-cus@passwd.hu> Message-ID: <31ce27b1-fabd-eec9-24b5-7336c67c31b2@passwd.hu> References: <20220613210455.31216-1-cus@passwd.hu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: report avio errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 13 Jun 2022, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > fftools/ffprobe.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) Will apply. Regards, Marton > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index 4e2fdbaec8..5020ba484c 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -545,12 +545,13 @@ static const AVClass writer_class = { > .child_next = writer_child_next, > }; > > -static void writer_close(WriterContext **wctx) > +static int writer_close(WriterContext **wctx) > { > int i; > + int ret = 0; > > if (!*wctx) > - return; > + return -1; > > if ((*wctx)->writer->uninit) > (*wctx)->writer->uninit(*wctx); > @@ -562,9 +563,10 @@ static void writer_close(WriterContext **wctx) > av_opt_free(*wctx); > if ((*wctx)->avio) { > avio_flush((*wctx)->avio); > - avio_close((*wctx)->avio); > + ret = avio_close((*wctx)->avio); > } > av_freep(wctx); > + return ret; > } > > static void bprint_bytes(AVBPrint *bp, const uint8_t *ubuf, size_t ubuf_size) > @@ -4145,7 +4147,9 @@ int main(int argc, char **argv) > } > > writer_print_section_footer(wctx); > - writer_close(&wctx); > + ret = writer_close(&wctx); > + if (ret < 0) > + av_log(NULL, AV_LOG_ERROR, "Writing output failed: %s\n", av_err2str(ret)); > } > > end: > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".