From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5ED09430C0 for ; Thu, 13 Jan 2022 22:01:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5328A68B522; Fri, 14 Jan 2022 00:01:34 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44ACD68B443 for ; Fri, 14 Jan 2022 00:01:27 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 20DM1Q6v029861-20DM1Q6w029861; Fri, 14 Jan 2022 00:01:26 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id A96EEA1428; Fri, 14 Jan 2022 00:01:26 +0200 (EET) Date: Fri, 14 Jan 2022 00:01:26 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <1642070709-3104-3-git-send-email-lance.lmwang@gmail.com> Message-ID: <315cd4-dfb-caa9-6f51-a5e1f7eefcfb@martin.st> References: <1642070709-3104-1-git-send-email-lance.lmwang@gmail.com> <1642070709-3104-3-git-send-email-lance.lmwang@gmail.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 13 Jan 2022, lance.lmwang@gmail.com wrote: > From: Limin Wang > > ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc -frames:v 1 -bsf trace_headers -f null - > > before the patch: > entropy_coding_mode_flag 0 = 1 > > after the patch: > entropy_coding_mode_flag 0 = 0 I don't understand what this bit in the commit message tries to say? Doesn't this patch have the effect, that if I only specify "-profile high", I'll end up with CAVLC unless I specifically pass "-coder cabac" too? If coder wasn't specified, I think we should still default to CABAC for main/high. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".