Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

[Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 2648 bytes --]

On 20/05/2024 01:19, Michael Niedermayer wrote:
> On Sun, May 19, 2024 at 06:54:44PM +0200, Lynne via ffmpeg-devel wrote:
>> This commit adds a decoder for the frequency-domain part of USAC.
>>
>> What works:
>>   - Mono
>>   - Stereo (no prediction)
>>   - Stereo (mid/side coding)
>>   - Stereo (complex prediction)
>>
>> What's left:
>>   - Speech coding
>>
>> Known issues:
>>   - Desync with certain sequences
>>   - Preroll crossover missing (shouldn't matter, bitrate adaptation only)
>> ---
>>   libavcodec/aac/Makefile              |    3 +-
>>   libavcodec/aac/aacdec.c              |  188 +--
>>   libavcodec/aac/aacdec.h              |  187 +++
>>   libavcodec/aac/aacdec_ac.c           |  208 ++++
>>   libavcodec/aac/aacdec_ac.h           |   54 +
>>   libavcodec/aac/aacdec_dsp_template.c |    4 +-
>>   libavcodec/aac/aacdec_latm.h         |   14 +-
>>   libavcodec/aac/aacdec_lpd.c          |  198 ++++
>>   libavcodec/aac/aacdec_lpd.h          |   33 +
>>   libavcodec/aac/aacdec_usac.c         | 1587 ++++++++++++++++++++++++++
>>   libavcodec/aac/aacdec_usac.h         |   39 +
>>   libavcodec/aactab.c                  |   42 +
>>   libavcodec/aactab.h                  |   10 +
>>   13 files changed, 2491 insertions(+), 76 deletions(-)
>>   create mode 100644 libavcodec/aac/aacdec_ac.c
>>   create mode 100644 libavcodec/aac/aacdec_ac.h
>>   create mode 100644 libavcodec/aac/aacdec_lpd.c
>>   create mode 100644 libavcodec/aac/aacdec_lpd.h
>>   create mode 100644 libavcodec/aac/aacdec_usac.c
>>   create mode 100644 libavcodec/aac/aacdec_usac.h
> 
> seems to break fate
> 
> make  -j32 fate-source
> TEST    source
> --- ./tests/ref/fate/source	2024-05-20 01:14:59.407222202 +0200
> +++ tests/data/fate/source	2024-05-20 01:17:32.661142354 +0200
> @@ -23,6 +25,7 @@
>   compat/djgpp/math.h
>   compat/float/float.h
>   compat/float/limits.h
> +libavcodec/aac/aacdec_ac.h
>   libavcodec/bitstream_template.h
>   tools/decode_simple.h
>   Use of av_clip() where av_clip_uintp2() could be used:
> Test source failed. Look at tests/data/fate/source.err for details.
> make: *** [tests/Makefile:311: fate-source] Error 1
> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Fixed:
-#ifndef AVCODEC_AACDEC_AC_H
-#define AVCODEC_AACDEC_AC_H
+#ifndef AVCODEC_AAC_AACDEC_AC_H
+#define AVCODEC_AAC_AACDEC_AC_H

Thanks

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".