From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
Date: Fri, 5 Jul 2024 14:37:49 -0300
Message-ID: <31319c97-348f-4c9e-bc9f-8884ad40c3ec@gmail.com> (raw)
In-Reply-To: <da6068-428b-05d-bdc3-aae0942d1211@martin.st>
On 7/5/2024 2:18 PM, Martin Storsjö wrote:
> On Fri, 5 Jul 2024, James Almer wrote:
>
>> On 7/5/2024 2:38 AM, Anton Khirnov wrote:
>>> Quoting James Almer (2024-07-04 22:45:28)
>>>> On 7/4/2024 4:04 PM, Anton Khirnov wrote:
>>>>> Filter output is not bitexact.
>>>>> ---
>>>>> Reference file at https://up.khirnov.net/7r.pcm, please put it in
>>>>> filter-reference/atempo.pcm
>>>>
>>>> How did you create it? x86_32 uses x87 floats which are a lot more
>>>> precise than sse ones, for example, so it's best to create a ref file
>>>> using such a build.
>>>
>>> Does it matter when the result is s16 anyway?
>>
>> Eh, who knows. Just in case i generated it on x86_32 with -cpuflags 0,
>> and uploaded it. Confirm it's fine on your end too, otherwise I'll
>> replace it with your file.
>
> The sample you uploaded seems to work fine for me, on aarch64 with
> clang, where the test was failing before.
>
> FWIW, re x86_32 and x87 - some compilers default to SSE2 math even for
> x86_32 targets these days, so depending on how you build, you may still
> get similar behaviour as to x86_64.
I used gcc 14 and -march=i686 at configure time, so it should not have
sse enabled.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-05 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240703094815.28640412658@natalya.videolan.org>
2024-07-04 9:44 ` [FFmpeg-devel] [FFmpeg-cvslog] tests/fate/filter-audio.mak: add test for atempo audio filter Martin Storsjö
2024-07-04 19:04 ` [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff Anton Khirnov
2024-07-04 20:33 ` Martin Storsjö
2024-07-04 20:45 ` James Almer
2024-07-05 5:38 ` Anton Khirnov
2024-07-05 16:04 ` James Almer
2024-07-05 17:18 ` Martin Storsjö
2024-07-05 17:37 ` James Almer [this message]
2024-07-05 0:00 ` Andreas Rheinhardt
2024-07-05 5:40 ` Anton Khirnov
2024-07-05 18:46 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31319c97-348f-4c9e-bc9f-8884ad40c3ec@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git