From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id A31044691F
	for <ffmpegdev@gitmailbox.com>; Thu, 24 Aug 2023 19:11:22 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3635C68C668;
	Thu, 24 Aug 2023 22:11:19 +0300 (EEST)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 14AE168C3BD
 for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Aug 2023 22:11:13 +0300 (EEST)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 37OJBC9B026769-37OJBC9C026769
 for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Aug 2023 22:11:12 +0300
Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144])
 by mail9.parnet.fi (Postfix) with ESMTPS id F3719A146A
 for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Aug 2023 22:11:11 +0300 (EEST)
Date: Thu, 24 Aug 2023 22:11:10 +0300 (EEST)
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <3317084.44csPzL39Z@naoise>
Message-ID: <3129c645-928-e7d7-b377-bd1ffbd92f2@martin.st>
References: <3317084.44csPzL39Z@naoise>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in
 hevc_sao_edge
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
From: =?utf-8?q?Martin_Storsj=C3=B6_via_ffmpeg-devel?=
 <ffmpeg-devel@ffmpeg.org>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/3129c645-928-e7d7-b377-bd1ffbd92f2@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Thu, 24 Aug 2023, Matthias Dressel wrote:

> From: Matthias Dressel <code@deadcode.eu>
>
> check_func() might return NULL, in which case the function is not to be
> benched. Introduced in cc679054c715acda9438e566b8de3a9eba421ac3.
>
> Signed-off-by: Matthias Dressel <code@deadcode.eu>
> ---
> tests/checkasm/hevc_sao.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
> index cfee2ddf50..94aa1942e1 100644
> --- a/tests/checkasm/hevc_sao.c
> +++ b/tests/checkasm/hevc_sao.c
> @@ -134,8 +134,8 @@ static void check_sao_edge(HEVCDSPContext *h, int bit_depth)
>                     if (memcmp(dst0 + j*stride, dst1 + j*stride, w*SIZEOF_PIXEL))
>                         fail();
>                 }
> +                bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
>             }
> -            bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
>         }
>     }
> }
> -- 
> 2.41.0

LGTM, pushed.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".