* [FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge
@ 2023-08-24 14:58 Matthias Dressel
2023-08-24 19:11 ` Martin Storsjö via ffmpeg-devel
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Dressel @ 2023-08-24 14:58 UTC (permalink / raw)
To: ffmpeg-devel
From: Matthias Dressel <code@deadcode.eu>
check_func() might return NULL, in which case the function is not to be
benched. Introduced in cc679054c715acda9438e566b8de3a9eba421ac3.
Signed-off-by: Matthias Dressel <code@deadcode.eu>
---
tests/checkasm/hevc_sao.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
index cfee2ddf50..94aa1942e1 100644
--- a/tests/checkasm/hevc_sao.c
+++ b/tests/checkasm/hevc_sao.c
@@ -134,8 +134,8 @@ static void check_sao_edge(HEVCDSPContext *h, int bit_depth)
if (memcmp(dst0 + j*stride, dst1 + j*stride, w*SIZEOF_PIXEL))
fail();
}
+ bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
}
- bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
}
}
}
--
2.41.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge
2023-08-24 14:58 [FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge Matthias Dressel
@ 2023-08-24 19:11 ` Martin Storsjö via ffmpeg-devel
0 siblings, 0 replies; 2+ messages in thread
From: Martin Storsjö via ffmpeg-devel @ 2023-08-24 19:11 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Martin Storsjö
On Thu, 24 Aug 2023, Matthias Dressel wrote:
> From: Matthias Dressel <code@deadcode.eu>
>
> check_func() might return NULL, in which case the function is not to be
> benched. Introduced in cc679054c715acda9438e566b8de3a9eba421ac3.
>
> Signed-off-by: Matthias Dressel <code@deadcode.eu>
> ---
> tests/checkasm/hevc_sao.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
> index cfee2ddf50..94aa1942e1 100644
> --- a/tests/checkasm/hevc_sao.c
> +++ b/tests/checkasm/hevc_sao.c
> @@ -134,8 +134,8 @@ static void check_sao_edge(HEVCDSPContext *h, int bit_depth)
> if (memcmp(dst0 + j*stride, dst1 + j*stride, w*SIZEOF_PIXEL))
> fail();
> }
> + bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
> }
> - bench_new(dst1, src1 + offset, stride, offset_val, eo, block_size, block_size);
> }
> }
> }
> --
> 2.41.0
LGTM, pushed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-24 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-24 14:58 [FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge Matthias Dressel
2023-08-24 19:11 ` Martin Storsjö via ffmpeg-devel
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git