From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D5BC5402DE for ; Wed, 19 Jan 2022 14:28:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8AE6168B0A8; Wed, 19 Jan 2022 16:28:01 +0200 (EET) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9466768AFA4 for ; Wed, 19 Jan 2022 16:27:55 +0200 (EET) Received: by mail-ed1-f47.google.com with SMTP id m11so12678373edi.13 for ; Wed, 19 Jan 2022 06:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=JO33cvNjSVg7O5ukK2EpFkIjwxHISbKboOglQV5ZuzQ=; b=Uy5d2Qm7S3ueaJzv6nehJCg2BuqAd15Z3pJFPaq7Fvr3cs8riY80q4Tk07MJxs8QFO 1qoDSnA+ocd3oZioL6StipEua3aiB/s46vsIyNvt55JKAZMfbRIiHP/JUJcUijBp7x7U Id8U76IhtpcJP/jmYKoQShOZ0TM0/9U5zjVI4JdTQ9D1sjR+eZrOI2EFQsYUkYKys8Ed mSunDjctLf1RnLxAAa3fIqsTKckFSWtTXRoSiFDxy0k82LLLN3+cpin/hbdFrA9x524c 6wYOE57EryQupdvW229nrDYdJoaI+m0vHSiBDywkVgrfoih8IdW7kK4Ebf51SM3V2Rqf m7ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=JO33cvNjSVg7O5ukK2EpFkIjwxHISbKboOglQV5ZuzQ=; b=qx8lGTv3oV7gWM/puIVLlGyWw9lMEOw1+WQ4N/JOK0frulAJClTYihb/YcE0fbB5ro NxXSzyx/LK5oCHu7gcaQgACR4GLXBexHeNdv5mznz5F8YF69J+EZj30V9yzF3aU0JM8f e72oHhWHL9J7oGXqO+MGHkrpUidFPRISuFJQGrvllcuuJE4zz88OarD3NxY6enDptXeB yEeRi15d8e/mYYyOQeebt665BSbxEsvlqAo5I8b6n5TJA23bN66P2Zj35pZUfGVMYvlJ 7Tf3f+zbC9EVO7KOeB8Owk8wEtsAuHTrqn4TjUl/CjkTNAThzl06CF4+7DizxyIV3iiz o8FA== X-Gm-Message-State: AOAM532wgYfjemnUUdXkSZF8Hsoj74EvegeGu3pq3t26eIGsAT8/1xFo zG4glGoeA6AgNyRV4zGTVBB5ae77UEA= X-Google-Smtp-Source: ABdhPJxjgq+Kcr6dpURJdOTkzdVehPJGcGxN5RuUXJcd/oILxj17kDOb9E40YZokOmyvJu0yOSmX8g== X-Received: by 2002:a17:907:7b99:: with SMTP id ne25mr21078428ejc.769.1642602475045; Wed, 19 Jan 2022 06:27:55 -0800 (PST) Received: from [10.10.10.172] (84-112-75-55.cable.dynamic.surfer.at. [84.112.75.55]) by smtp.gmail.com with ESMTPSA id z16sm1463849edm.49.2022.01.19.06.27.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jan 2022 06:27:54 -0800 (PST) From: "Marvin Scholz" To: "Romain Beauxis" Date: Wed, 19 Jan 2022 15:27:53 +0100 X-Mailer: MailMate (1.13.2r5673) Message-ID: <31126DA9-1D87-4BB2-B520-447FF4B7B7E6@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/5] libavdevice/avfoundation.m: use setAudioSettings, extend supported formats X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Thilo Borgmann , FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 19 Jan 2022, at 15:23, Romain Beauxis wrote: > This patch switches the logic around audio settings to let the caller > drive the format. Hi, just a quick technical feedback, with the patch sent as attachment it now finally applies fine for me, thanks! > > After experimenting with the AudioConverter, we realized that, even > when adhering to a strict implementation of the documented API, we > were still getting errors during conversions. The input device would > randomly change from e.g. s32le to s24le between restarts and error > out on conversion (using a freshly initialized converter). > > Using setAudioSettings allow the OS to drive audio conversion > internally and pick whatever appropriate settings for the audio > device. This has been working very well and is also the way > AVFoundation audio input is setup in videolan. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".