From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] configure: Include objbase.h when checking for CoTaskMemFree
Date: Mon, 21 Aug 2023 23:16:42 +0300 (EEST)
Message-ID: <309bad95-4c90-add1-06-83c5dcc5d02@martin.st> (raw)
In-Reply-To: <5e113de6-7ffc-2854-dfa0-6655b46c884a@gyani.pro>
On Sun, 20 Aug 2023, Gyan Doshi wrote:
>
>
> On 2023-08-20 02:42 am, Martin Storsjö wrote:
>> ddc1cd5cdd2570bf3d6ab807ee0ecfacdf09431d defined WIN32_LEAN_AND_MEAN
>> globally, which makes for much fewer transitive includes from
>> windows.h. With that define, CoTaskMemFree no longer gets
>> implicitly declared by just including windows.h, but one has to
>> include the right header objbase.h too.
>>
>> That commit caused ole32 to no longer get detected, which caused
>> dxva2 to no longer be enabled. This gets fixed by this patch.
>>
>> Signed-off-by: Martin Storsjö <martin@martin.st>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index ff6a5c3600..04bb9fe9dd 100755
>> --- a/configure
>> +++ b/configure
>> @@ -6488,7 +6488,7 @@ done
>> check_lib advapi32 "windows.h" RegCloseKey -ladvapi32
>> check_lib bcrypt "windows.h bcrypt.h" BCryptGenRandom -lbcrypt
> &&
>> check_cpp_condition bcrypt bcrypt.h "defined BCRYPT_RNG_ALGORITHM"
>> -check_lib ole32 "windows.h" CoTaskMemFree -lole32
>> +check_lib ole32 "windows.h objbase.h" CoTaskMemFree -lole32
>> check_lib shell32 "windows.h shellapi.h" CommandLineToArgvW -lshell32
>> check_lib psapi "windows.h psapi.h" GetProcessMemoryInfo -lpsapi
>>
>
> Tested; LGTM.
Thanks, pushed now.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-08-21 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 21:12 Martin Storsjö
2023-08-20 7:57 ` Gyan Doshi
2023-08-21 20:16 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309bad95-4c90-add1-06-83c5dcc5d02@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git