From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C0C2A40E66 for ; Wed, 9 Feb 2022 03:39:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DA7A568B1FB; Wed, 9 Feb 2022 05:39:07 +0200 (EET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 27F5A68B1F1 for ; Wed, 9 Feb 2022 05:39:00 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644377946; x=1675913946; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=AoB88H5OuFFyCEQnQ6zpQu8+dVu4+pZWt48+f6uYbUM=; b=fVtFfAiKXhxUkUZvgrP4QufLEZ6y/h76oQBcNmayrK/OkjvkiGscnnqX CNCO/XOXxi0VjmDH338pb+iJErn1GeX6wNIAqbsE9xXKHidz+Z04QreDD xTSJy3/qMrWc8A3owq6FpXUD6BYO0VPKwnSWzr5xsDpAVuOvtLHhXyYq/ uEQjkNgksY7wTForNNEX8QtMwM+2Y63BY86J+27y0weTpjmowDrf5zH49 AFuxYg8hyy/6xPqPUZ+HLptXqAiQJEIG2jx0VFBFu4kPEOufgJAceBkg2 0CP31nLvXQGTNwD6OH4tRg5QSNHLrznMI9CT+Et7Ix9S9+NWTPQ/WqTSb w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="312407422" X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="312407422" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 19:38:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="771204729" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 08 Feb 2022 19:38:59 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 19:38:58 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 19:38:58 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 19:38:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YLOr54TBIiqDV0/rpvYtpzqnM1E63COJqqjKgx0yF49jwqlC4VOd5EjofQKlVbUCOlELWHIL1JTCB2QdM+YPnpYOx+Zr76nxC2Hv5s6n96M71KSOcXI8TXmDhmqpBsyjv2q323cTNlOMbXOfYtwFs8Uoa8TFhU17EYJaAhic02cfVaF0Xdn9Si076qziya2TBcwBUuwLg7Y7J47mtNMcL8nM9kBd2xlpLKwbCD2PNIXiZj1VVP69jY4gfaeGbQ6aXaYWucD3Zqf+tmvPHLSDEGtLnqeJBKDqqXkI/+ikVAYfha+moHW3dpWMs6KGJ3J5M3sSkravUFDspl7wT2nghg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AoB88H5OuFFyCEQnQ6zpQu8+dVu4+pZWt48+f6uYbUM=; b=M8TsTlTZhJVbOS++XqjPOqjqbRTqzq+4zpsgGqLlSfL3J+TZYIv1T6hjxAcVdyMZx9irQAFPSHBBL7kD1+OA3f+ACRGf/o4zGrd/iryOG0LYGpiDbMg6LUPSNYg+Aihq7a9REQvwA4gD7ceFA5ZLmwxW2aiYk4hqOk6JNHfM3RVISLEei2YSmxncp9//Glzd8Iirai7p+G3/DN1/cC/1y1qK44pWjLjuk3xlJyQ71KTKK8ho71+AADi/ShR3i55HWkpM1cUwpQz0yfQkw6FZ2y2NXvn3ppew68e3rwQtlq4IpzOvMaa+23VSl4SIBvtzLLbbeqmp1qYRwlc68pRpzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MWHPR11MB1279.namprd11.prod.outlook.com (2603:10b6:300:2a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 9 Feb 2022 03:38:56 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022 03:38:56 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" , "Eoff, Ullysses A" Thread-Topic: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression Thread-Index: AQHYHRQYkjYr9rnJRkysRuSxchw6IKyKkvYA Date: Wed, 9 Feb 2022 03:38:56 +0000 Message-ID: <30441d9f441a3e8d045e39ea695b0933d582d6ef.camel@intel.com> References: <20220208054734.14166-1-haihao.xiang@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 89dee329-6bff-4f36-098a-08d9eb7db37f x-ms-traffictypediagnostic: MWHPR11MB1279:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:269; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vxG1TKx0oHwPyj3LRusTPoXO6lIpXRo04HZ6ZdtYgoj39q6SwpyZ4yqZxFC8gWqrnlhNmRfrUz2OfuBCwZ8NwgxVFVwfYsIBJx8EC0ZrIszlpwx2rDVlZFPyEqhXZCFWoqIeXaHSd8Xnxl/CSJf7QIWI3CVtOsvvhX6MzRhCgOUtXqtBmUR/FpwGlkjvNZL9CtYfEkxSUzbyEAKjBilXbCO5/RqIwO0GqnX+PmtPF5aRr1doeEMgjm7djfLm/VdR83KO07sijIWbnM2gCJrS0MPITCaxYY0YOqNcvA9fmQh32dO4Y4YLXsuHFP1safJPkgSP/mPltCES4bVrRd96yoPwnthsq5tkTIIMdRlFdHZqEDLYQp7zFXpc1rrqGfPAkgZx5gl5NPnKbrdQ5LmQcLLuBEtCMqvdserb/3MMQ7LIQWVal63pDp0ntrbFpcsuyyCcMtBB30fGLFIB1hfXS9WMo7firupylBxqsYqdF7HT5D864Y+SZ0MEi1arPw7ADI8g8n3EW/avOk2hpIrxlRAUDMgVv1yrf7QqY3AhKBviwlJhM5/LAmgmKCmeRqbhtjWvEWdm4JODzvSSsvRJw+QKw4aqxc4mqGcNPe4oK9uoRjG3+BlxMLi3UtIq1zM7yaYppuzCauNXrdz/WrHOjPtnQlcUmgOGNDRFFYxPZD+sUQV+xcRk7f/4WuCu6x31rNWlRaT2p3yePKoWBmy25K+9wXCo9/jsKHEJs19aa4Kt+oOSJeAVq5eS3L6w3jesOJDEfsSlng60/HslCFIKf/8lvU2nA4A02MSYSzrncUWmX0zHkcYGmYTwTl5Ker3O x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(508600001)(66946007)(6486002)(6506007)(2616005)(76116006)(64756008)(38070700005)(53546011)(186003)(8676002)(2906002)(26005)(8936002)(966005)(66476007)(6636002)(91956017)(316002)(36756003)(71200400001)(38100700002)(82960400001)(6512007)(86362001)(66446008)(110136005)(66556008)(83380400001)(122000001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SDJOdjhnOW5LVURkZmpWdS9SUjluRGtsMEczR3ViRkVEbUF2SzNGbFFQQ2cw?= =?utf-8?B?b1NLRldtbUs2dExEVXl3TmZKMWVQdU8yeGVjZmtGVkd0NkZrRUNnNEVJSzRB?= =?utf-8?B?MXcxVkNFWGxYMzJCME9jeXB6MzYvdjdIbDdyYkh5eEhlcXFIQVFEUVdBelZY?= =?utf-8?B?Q1pzekZvSXhmeHM1MmNKNnc0WUFCY0pZUGdCT0xxVVJ0bkV3ZFVZZThYS0hk?= =?utf-8?B?eTRxZFNQczVyazEzRjJZUG5Cc282QXRVTFR6U3MzSVU3Y3pkNzQyZTFrdmdM?= =?utf-8?B?S0FQUDFUbTNmMG1rUXpUNFMwUXFVc1Y3MEw0eEtJZnpxZmVMYkRjamVILy9Z?= =?utf-8?B?RCtBckFVRkJlNmFTVmcxd0RaZlRpZFlNbmRNVXZMY1ZOcWhjNk9PZ1h5d0lW?= =?utf-8?B?aEZ5bmd1ajd6QjZrVm5scDRZeXU3d0dOb0V4MWpQNnY3R0hHYldJc2dzaVBs?= =?utf-8?B?TW1DdEttOTk5TkdJTnRra2d4UU9LNklVdHk0N24rWTNkS2FJK080RGU4eXBQ?= =?utf-8?B?eGo5VUJNd2puSzdMZENBSmZMM2lhUkY4T3MwMUlPUldiSTFEZmZNaUMwMWtZ?= =?utf-8?B?bk9WZktlTmNzdGNQZTFFNVRrSHQ0S09MMllMa2s5ZkZMSmRnUWMxWStIVHB6?= =?utf-8?B?a2dsTUxJWVJFcGx4V3gzRUZ3SHI2UHZyNjRsREx2TjhsSXhmWGFkZi83MVIv?= =?utf-8?B?bGM1M0FUQ3RLQW16bjVENUNSODBLM2pTRnYxMVBuSTdSUEl4TlBPYkI4RGc3?= =?utf-8?B?Qk5EekdIa1huUWpSN0xod2hvWHNza2JRNUhmNEFBa1ltODBtSEhFZ3lITUVW?= =?utf-8?B?M3J0UlZXamJtZ3JzMjVTQWtLRWU1UW1MZGRCbHQvSS93L0NnMGhnak1CMnRR?= =?utf-8?B?dmx1Tm5GYk1oSUJ0d1ZHSnk3ZlZUc2RDQUkwU2x0VjBZY041Z2N1OWc0Tjc4?= =?utf-8?B?dys2RjJKUGt5clhXOFhOY0ZkOVNmS3V5UEpPQys3ODhuUEpCRFkrNWR2UnpK?= =?utf-8?B?RXdnWnRLZGpJRndaOFJzMEZ3WmRsNlpnSkJIRGFSMTB1dzEwZXVuSWphQ3Fk?= =?utf-8?B?VGVMNXFpUXo4VmNMTE1raTBmelE3RUdGUE9IZUEzZWZVOUpJV1ZiNXRFMFVn?= =?utf-8?B?VStvSHRXM3VnaHFlQkhHUm5nUHowZWhrSnNmK0d6a1k4YmRneGRRS3Vpd0lZ?= =?utf-8?B?aHIwbytNeHRoTmFxSkxNUGFSNUlnTzhTN2tkV1k4UjVKb2N4Y1FXRFdRcFZL?= =?utf-8?B?WHZGa2hhdWpabW1ZbGZ5NG1yV24zRFFUd0wzU25mdVlXV2pkeWxJRWFrb3E3?= =?utf-8?B?NjFGbVZteHZxa1F3UTFhaU1jc2pjQ1BFY1M1UU1iTEpWaEVDVHVDaHdTVU5O?= =?utf-8?B?RW1McFNYMmp1MmtQbTFSbDFOemhYd2dkUEQ4dG5IKzBvUUFYdkN0bGt2eWk4?= =?utf-8?B?NE93Rnh1cFJuWkF1b1ZvSUVqWlRlSUhJd2F0c2IycDNwUHREQmVwVUoxZU81?= =?utf-8?B?TWkwMEJOVzA1MWwzTGxQa3ZDOUxqR25EUzdpeGh3a3QvL1N6YjVweU91dGJV?= =?utf-8?B?bis3T1JUTGFJRjZXMXY5Wkd0RWN0MWE4VWk2Y1VXVWNzS0pCa0J1OUs3c0da?= =?utf-8?B?WUdod2R1VlR5UVExd09uUDZHNWduR3dxZlRvWUI5bUV0aW9wMElsUThFUlBI?= =?utf-8?B?UUdwQWZaL3EwcWhDdUQ0UnUvN29EaUx1SkwyOXFTWGd0MUh2VWNiNk0wWGZn?= =?utf-8?B?a0JYaHAxakJRLzF3WnRrS0RlM201U01kZXRIYTVhM1Bodk9YaktvQUJ4QTdj?= =?utf-8?B?L2xEejEwc0IyZGdRb3poRFMrcWw0dWdRTXBqbHl2QmJqdjRJRTRSaDcxN215?= =?utf-8?B?SDNHY3ltSEJwMjhVYjhBVWJ4WE82cGxxVkRueWsvd1ovcjlmLzlVMDgxRE1D?= =?utf-8?B?ZjlVbUtvVnRKNTRzTlBuWmMwMUVNNXhRVW5WbWdBUFQ2SGpURkFpVm5NT1Vp?= =?utf-8?B?UDBCcThnWktTRmdKK3pKWkJYemZHdVVWelcvNi9DSmZ5VkV4TWxOeE5iUWZO?= =?utf-8?B?SWNJSHZ0TEZUY2VEdFgxMnp5cUFvcnV5cC9lRjVOZWZ3bWJCZkN6bkl6YUls?= =?utf-8?B?NDJoMXFncm5XVTUvblo1NXd3RHBJTWlyYVN2TklsN00wdmlncldtTHpXTDJk?= =?utf-8?Q?TbMC/eN8QUjcziqY1Ph+3iE=3D?= Content-ID: <37CF541D8BEE6844AFE1239474C522E9@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89dee329-6bff-4f36-098a-08d9eb7db37f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 03:38:56.3741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vzupRGie1D93tDlwLw+QxsCDodtb6puSMehCwqah/5Q0YnSgfKUmK7XOEuOgW1aj/OsVYuA+ZdXuigd4zvm9TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1279 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-02-08 at 17:48 +0000, Eoff, Ullysses A wrote: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Xiang, > > Haihao > > Sent: Monday, February 7, 2022 9:48 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Xiang, Haihao > > Subject: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression > > > > From: Haihao Xiang > > > > offset_w might be updated after growing the FIFO > > > > Fix ticket #9630 > > > > Tested-by: U. Artie Eoff > > Reviewed-by: mkver > > Reviewed-by: U. Artie Eoff > > Signed-off-by: Haihao Xiang > > --- > > libavutil/fifo.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavutil/fifo.c b/libavutil/fifo.c > > index 0af0154945..02e0ec3f0d 100644 > > --- a/libavutil/fifo.c > > +++ b/libavutil/fifo.c > > @@ -147,13 +147,15 @@ static int fifo_write_common(AVFifo *f, const uint8_t > > *buf, size_t *nb_elems, > > AVFifoCB read_cb, void *opaque) > > { > > size_t to_write = *nb_elems; > > - size_t offset_w = f->offset_w; > > + size_t offset_w; > > int ret = 0; > > > > ret = fifo_check_space(f, to_write); > > if (ret < 0) > > return ret; > > > > + offset_w = f->offset_w; > > + > > while (to_write > 0) { > > size_t len = FFMIN(f->nb_elems - offset_w, to_write); > > uint8_t *wptr = f->buffer + offset_w * f->elem_size; > > -- > > 2.17.1 > > > > LGTM > Applied, thx > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".