From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D23E542A16 for ; Tue, 11 Jan 2022 02:35:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A1B6868ADDC; Tue, 11 Jan 2022 04:35:40 +0200 (EET) Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 71A0B687FCE for ; Tue, 11 Jan 2022 04:35:34 +0200 (EET) Received: by mail-vk1-f178.google.com with SMTP id w206so8532826vkd.10 for ; Mon, 10 Jan 2022 18:35:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=olm5lTpJNPdVFLl0TvoPM44XOHZUY4K2JEo5rd7fXls=; b=qJs4QWv9WjoDXNHf0E25qM6LILxW/cUHAPhkmINRFu4+djFNlUtffJ/Gb524EHcJVj 3d53/E3frA6mi9ZWS3xgdPbdx9rB9Ux5h5Z6ac2y59ayfxnUA+hE6iXQF+j1N50EIp/x E4KGEjap5gwHonStP/9eMo4ajOyj6VPcN1DjiHycSCC7BkXz5xHoYYlX3oU6GpIih4ka tDTyKdtLZtmLxwDrKTqgOUORM8d1Dc7hSJKXxFnLQmX0NvHGMAPfW9gS29nKJmcI3D+x CvV8lcHP2deODSJ1zl47o3iLtSQIIQkB9mCsI+TNgSkX4nW8hP6PPcVJEQKr9aCs197j HUpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=olm5lTpJNPdVFLl0TvoPM44XOHZUY4K2JEo5rd7fXls=; b=BoWPg5VSVkqyPBzZsXDIuO/g/qWosc3pKP8kPA+Nop3ysAwxnIx1Kmaba5q65uWRYp 3uMEz2sI2d926FZBO/GxNTglMP2oyOjgl2P7DMZxT0AHYKXOTP+FkN3USq3/dw3iqCeq RClXn81INauFtv5qsyxns6ASOpRxKtmNmPa0veI93noZjEZjkqSx4z8aMJHJ1nQ5sKYX tqfqTirQ7x3PuD8q6ut1FEYDZl85e5bB6cQV3KVWnxYhS65BmLgwam5W1hdGFh5bWe9T xtkqHzvoy9g8M8/TOXtUGXVVCWBB5LG5iOfygarTSCqpLIW7ORM9swR9UtWzuZhUSxFy 1D1g== X-Gm-Message-State: AOAM532Ve3BdL6tA7fE24DWYWjAIy2XDYB0Y0mHjILNOYb7DsMhHEvLw xxJEx9UP+KOsFPs+Ml8zuhXFEeKfx6k= X-Google-Smtp-Source: ABdhPJyCMDCijYqWFjdH+KA32+1moxUW3oh8bbhG+oWABRfi9vo7A5cbom4Kn9IsUDIgtBeScWP4bw== X-Received: by 2002:a1f:234f:: with SMTP id j76mr1267731vkj.13.1641868532709; Mon, 10 Jan 2022 18:35:32 -0800 (PST) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id o12sm4820340uae.1.2022.01.10.18.35.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 18:35:32 -0800 (PST) Message-ID: <303aea2b-0b25-50ce-6009-a8fc55fa6d38@gmail.com> Date: Mon, 10 Jan 2022 23:35:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220111023025.72632-1-13102179620@163.com> From: James Almer In-Reply-To: <20220111023025.72632-1-13102179620@163.com> Subject: Re: [FFmpeg-devel] [PATCH] avformat/asfdec: init avpacket by av_packet_alloc() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/10/2022 11:30 PM, 13102179620@163.com wrote: > From: Yang Xiao > > This commit fixed a crash when seeking wma frames, asf decoder will try to demux in function asf_read_pts(). > Pointer member side_data of AVPacket that allocated by stack may be wild pointer. > Prevent releasing wild pointers in AVPacket when some functions try to call av_packet_unref, example av_read_frame(). > --- > libavformat/asfdec_f.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c > index a8f36ed286..8cf953830e 100644 > --- a/libavformat/asfdec_f.c > +++ b/libavformat/asfdec_f.c > @@ -1433,7 +1433,7 @@ static int64_t asf_read_pts(AVFormatContext *s, int stream_index, > { > FFFormatContext *const si = ffformatcontext(s); > ASFContext *asf = s->priv_data; > - AVPacket pkt1, *pkt = &pkt1; > + AVPacket *pkt = av_packet_alloc(); You're not checking pkt for allocation failure, and you're never freeing it after using it, so it will leak. > ASFStream *asf_st; > int64_t pts; > int64_t pos = *ppos; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".