From: "Ignacy Gawędzki" <bugs@qult.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 1/1] avfilter/f_mix: disable fast on discontinuities Date: Sun, 6 Jul 2025 20:30:14 +0200 Message-ID: <2zwrno7dlcw23sloreb2souwb6fd6z4rcj4ywodm3mwbsmb2zw@gwponcvhmut4> (raw) FAST_TMIX_SLICE can work properly only in the case the filter is run from the start and has never been disabled. Therefore, once s->fast is set to 0, it shall never be set back to 1. Signed-off-by: Ignacy Gawędzki <bugs@qult.net> --- libavfilter/vf_mix.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_mix.c b/libavfilter/vf_mix.c index 517bb2450f..c996cdd9fb 100644 --- a/libavfilter/vf_mix.c +++ b/libavfilter/vf_mix.c @@ -88,7 +88,6 @@ static int parse_weights(AVFilterContext *ctx) char *p, *arg, *saveptr = NULL; int i, last = 0; - s->fast = 1; s->wfactor = 0.f; p = s->weights_str; for (i = 0; i < s->nb_inputs; i++) { @@ -150,6 +149,8 @@ static av_cold int init(AVFilterContext *ctx) } } + s->fast = 1; + return parse_weights(ctx); } @@ -295,6 +296,7 @@ static int process_frame(FFFrameSync *fs) } if (ctx->is_disabled) { + s->fast = 0; out = av_frame_clone(s->frames[0]); if (!out) return AVERROR(ENOMEM); @@ -506,6 +508,7 @@ static int tmix_filter_frame(AVFilterLink *inlink, AVFrame *in) } if (ctx->is_disabled) { + s->fast = 0; out = av_frame_clone(s->frames[0]); if (!out) return AVERROR(ENOMEM); -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-07-06 19:14 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2zwrno7dlcw23sloreb2souwb6fd6z4rcj4ywodm3mwbsmb2zw@gwponcvhmut4 \ --to=bugs@qult.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git