From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] movenc: Allow writing timed ID3 metadata
Date: Wed, 10 Apr 2024 11:27:25 +0300 (EEST)
Message-ID: <2fd3a48-88fa-6926-104f-9cbfc8b9168@martin.st> (raw)
In-Reply-To: <d043e0cb-ed48-4014-9e37-774126bac229@gmail.com>
On Tue, 9 Apr 2024, James Almer wrote:
> On 4/4/2024 7:29 AM, Martin Storsjö wrote:
>> This is based on a spec at https://aomediacodec.github.io/id3-emsg/,
>> further based on ISO/IEC 23009-1:2019.
>>
>> Within libavformat, timed ID3 metadata (already supported by the
>> mpegts demuxer and muxer) is handled as a separate data AVStream
>> with codec type AV_CODEC_ID_TIMED_ID3. However, it doesn't
>> have a corresponding track in the mov file - instead, these events
>> are written as separate toplevel 'emsg' boxes.
>> ---
>> libavformat/movenc.c | 49 ++++++++++++++++++++++++++++++++-
>> libavformat/tests/movenc.c | 55 +++++++++++++++++++++++++++++++++-----
>> tests/ref/fate/movenc | 8 ++++++
>> 3 files changed, 104 insertions(+), 8 deletions(-)
>
> Should be ok.
Thanks for the review, pushed now.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-04-10 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 10:29 Martin Storsjö
2024-04-09 15:04 ` James Almer
2024-04-10 8:27 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fd3a48-88fa-6926-104f-9cbfc8b9168@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git