From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1527942540 for ; Tue, 24 May 2022 09:29:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 09B9E68B246; Tue, 24 May 2022 12:29:28 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E2CC168A1FE for ; Tue, 24 May 2022 12:29:20 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 24O9TKM3021148-24O9TKM4021148 for ; Tue, 24 May 2022 12:29:20 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 563DAA142D for ; Tue, 24 May 2022 12:29:20 +0300 (EEST) Date: Tue, 24 May 2022 12:29:20 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <2f168e51-5eb1-44a4-fb1e-f6df4bbe55ee@martin.st> References: <20220520211254.47116-1-martin@martin.st> <517c2dda-35fc-9361-b5ee-9a41826ad931@martin.st> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 23 May 2022, Soft Works wrote: > Great. I rebased and resubmitted both patchsets. The primary long-path > patchset didn't need any change. > > Considerations for the latter were: > > - Should the file wchar_filename.h be renamed as it is now containing > the path prefixing code? I guess we could do that later at some point, but I don't see it as urgent. > - I have kept the path functions in the same way like .NET does it, > just for easy reference and following. Compilers will inline > them anyway (my pov). Maybe others don't like that. I can change > if it's got to be. Having the individual functions inline compared to merging it all in one big function doesn't matter to me. But the amount of code in this inline header is growing a bit big, to the point that I think it is measurable when multiple files within the same library use these functions. Longer term, it would probably make sense to make them more shared in some way. If C would have the C++ style deduplication feature for non-static inline functions, this wouldn't be an issue. One could consider making them ff_ functions and carry a copy in each library too, maybe. (But that also makes it trickier to use in fftools.) Not entirely urgent yet anyway. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".