From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8
Date: Tue, 24 May 2022 12:29:20 +0300 (EEST)
Message-ID: <2f168e51-5eb1-44a4-fb1e-f6df4bbe55ee@martin.st> (raw)
In-Reply-To: <DM8P223MB03653D246AA3F229AF9E19A3BAD49@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
On Mon, 23 May 2022, Soft Works wrote:
> Great. I rebased and resubmitted both patchsets. The primary long-path
> patchset didn't need any change.
>
> Considerations for the latter were:
>
> - Should the file wchar_filename.h be renamed as it is now containing
> the path prefixing code?
I guess we could do that later at some point, but I don't see it as
urgent.
> - I have kept the path functions in the same way like .NET does it,
> just for easy reference and following. Compilers will inline
> them anyway (my pov). Maybe others don't like that. I can change
> if it's got to be.
Having the individual functions inline compared to merging it all in one
big function doesn't matter to me. But the amount of code in this inline
header is growing a bit big, to the point that I think it is measurable
when multiple files within the same library use these functions. Longer
term, it would probably make sense to make them more shared in some way.
If C would have the C++ style deduplication feature for non-static inline
functions, this wouldn't be an issue. One could consider making them ff_
functions and carry a copy in each library too, maybe. (But that also
makes it trickier to use in fftools.) Not entirely urgent yet anyway.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-24 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 21:12 Martin Storsjö
2022-05-20 21:12 ` [FFmpeg-devel] [PATCH 2/3] libavutil: Deprecate av_fopen_utf8, provide an avpriv version Martin Storsjö
2022-05-20 21:12 ` [FFmpeg-devel] [PATCH 3/3] Switch uses of av_fopen_utf8 to avpriv_fopen_utf8 Martin Storsjö
2022-05-21 5:07 ` [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8 Soft Works
2022-05-23 10:53 ` Martin Storsjö
2022-05-23 10:55 ` Soft Works
2022-05-23 10:58 ` Martin Storsjö
2022-05-23 11:06 ` Soft Works
2022-05-23 11:11 ` Martin Storsjö
2022-05-23 11:44 ` Soft Works
2022-05-24 9:29 ` Martin Storsjö [this message]
2022-05-24 19:45 ` Soft Works
2022-05-24 20:21 ` Martin Storsjö
2022-05-24 20:50 ` Soft Works
2022-05-24 20:55 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f168e51-5eb1-44a4-fb1e-f6df4bbe55ee@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git