From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4943F405B3 for ; Sun, 27 Mar 2022 21:41:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E23E68B264; Mon, 28 Mar 2022 00:41:03 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 530B568A7E9 for ; Mon, 28 Mar 2022 00:40:57 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 32565E6D7A for ; Sun, 27 Mar 2022 23:40:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aENmVtFZWIUs for ; Sun, 27 Mar 2022 23:40:52 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id CEBB8E4F69 for ; Sun, 27 Mar 2022 23:40:51 +0200 (CEST) Date: Sun, 27 Mar 2022 23:40:51 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20220327060800.3732289-1-wangcao@google.com> Message-ID: <2ec3971d-f698-1369-1ace-eac613afc980@passwd.hu> References: <20220327060800.3732289-1-wangcao@google.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/alimiter: Add "flush_buffer" option to flush the remaining valid data to the output X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 26 Mar 2022, Wang Cao wrote: > The change in the commit will add some samples to the end of the audio > stream. The intention is to add a "zero_delay" option eventually to not > have the delay in the begining the output from alimiter due to > lookahead. I was very much suprised to see that the alimiter filter actually delays the audio - as in extra samples are inserted in the beginning and some samples are cut in the end. This trashes A-V sync, so it is a bug IMHO. So unless somebody has some valid usecase for the legacy way of operation I'd just simply change it to be "zero delay" without any additional user option, in a single patch. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".