From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7D914469E9 for ; Sat, 1 Jul 2023 19:41:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 69D2768C049; Sat, 1 Jul 2023 22:41:43 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B271368BD8E for ; Sat, 1 Jul 2023 22:41:36 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 361JfZq9010228-361JfZqA010228 for ; Sat, 1 Jul 2023 22:41:35 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 26985A146B for ; Sat, 1 Jul 2023 22:41:34 +0300 (EEST) Date: Sat, 1 Jul 2023 22:41:34 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20230701144442.GD1093384@pb2> Message-ID: <2e90ba71-f56f-974d-d76d-a750c480c09c@martin.st> References: <20230628212504.2522567-1-michael@niedermayer.cc> <20230630140838.GA1093384@pb2> <4f0dc1-fb9b-a532-05a-6e8e1debfe91@martin.st> <20230701144442.GD1093384@pb2> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 1 Jul 2023, Michael Niedermayer wrote: > On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsj=F6 wrote: >> On Fri, 30 Jun 2023, Michael Niedermayer wrote: >> >>> On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: >>>> If you apply this I will apply my pending libswresample commits and al= so >>>> remove sonic decoder from libavcodec. >>> >>> ok, if you plan to fix the bugs in the libswresample patches >>> >>> ill wait a bit, so others can object and if no objections will >>> apply the current SDR patch with the probe function disabled. >>> That ensures it will not be used without the user explicitly >>> selecting it. >> >> I object to merging this patch. >> >> As numerous others have said already, this is at the wrong level of >> abstraction, even if it happens to work for you for the current use case. >> >> Even if it is disabled by default, git master isn't a playground for >> personal projects. > > If you belive this is implemented at the wrong level, > can you please elaborately explain the implementation which is > in your oppinion at the correct level ? As there are talks about receiving DAB/DVB from the same source, those = would definitely be on a different level than libavformat, since the = output of them would be an mpegts stream (or multiple), or whatever = transport format DAB uses. As for purely AM/FM, I'm not quire sure what = the right level for that is though. In any case, I disagree with the procedure of stating to push the patch if = there's no objections, when there has been numerous objections from = essentially most of the active community already. As for what you asked in another thread, whether the objection is personal = and not related to content - I wholeheartedly disagree. I would have = expected the same response to a similar patchset from anybody else. The amount of response only varies a bit depending on the position in the = community of the person proposing the feature. A more senior community = member has easier to push a feature forward than a less known community = member. Thus, objections to such things also trigger more voices to show = the widespread disagreement on the matter. > > Even if it is disabled by default, git master isn't a playground for > > personal projects. > = > This is in no way intended as a "personal project" My point was that one can't use the argument of "let's merge it but keep = it disabled for now, then you surely can't object to it", as a backdoor to = merge disapproved things. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".