From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C6A2247500 for ; Thu, 9 May 2024 20:37:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A84C468D5F2; Thu, 9 May 2024 23:37:53 +0300 (EEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 63A7D68D423 for ; Thu, 9 May 2024 23:37:46 +0300 (EEST) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-34da04e44a2so863163f8f.1 for ; Thu, 09 May 2024 13:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1715287065; x=1715891865; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b1fdYSTZYAl9ZFe6sLZrBjYyZXMoe0MjiHt2wyxuWNU=; b=CeIw08FyhnwJv4cTmZA9joN0slQLNwnwIm40AwcYJjaBW/yFJBZfSV6ZUk5aFlwijg mp1fPyET+5bVEw+uYT1IFjZyFGGCjZGAJuE4r1JZaLezSV3OYdZ1dYc9Yn+RPTRzbds9 2R2DBZnEAHVP+eO+UFqRN8rHHXtTiAHdA5yRPdwbKHtcIJF7MuYlDWR/J6VL6hSk0Hjz 3NCt9y4HLtYLGeC/VQ+k8afsIMohxuzkYfdril7PSoNL3DFBhwieLAOIK9xZFq0pHg8V X57PE/kbODFPIFijg9wBOL/1HSBPO5pekTlk0ykbJmvMA0AWI0wlZ+0lcjW3N58zNBLz VrtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715287065; x=1715891865; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b1fdYSTZYAl9ZFe6sLZrBjYyZXMoe0MjiHt2wyxuWNU=; b=JuA+54mV4sSGp28LQ1JJW3pXhO2E0Ed5PQ/slwbXEv+azjN7Tg6kfmebLmwsaqgP9z NDvQIhEOFn/FzlqErv2e6oaXUOXnbi7camrhd/EmhI8KtumMtqQvezqVE9JbKa6iofrt FEqW7V4+qt0YlNnScslV1Yl3XbZauHr6HV+fPfyS16h4EfEE83jKTBNQ16MYD1A5nlo6 iJeaF7EJZsyaJbIkiprmVjK1J83rG6jokbo79xUgeyAsimJa7iOKHKrTuG2r/yvCHioQ jY10M4fPbACGZ9s+3YC/XhTmitR4S9BKC58B2cWm6qIjXT60ypF4YfZVYZJEonHnHMNX 0IZA== X-Gm-Message-State: AOJu0YyavFhk2CUZyFkYchd4F2gi/pNOpF81av18ET1GqCVAavMcQyva 35nHlWdzmv3j/HYXB3ZMx5wZQynfl5/azKIez6DqtfGJFUK2SQImKmzuYRhmhgnbzU5TiydSZR/ k X-Google-Smtp-Source: AGHT+IEfmA+4oNhtdjkpIRNLNExGkXBJuc9+Imr1KcHl+4rJUqGErlE57lHtjpdSKD8UNb6m4FQXfQ== X-Received: by 2002:adf:e981:0:b0:34c:f5d2:528d with SMTP id ffacd0b85a97d-3504a9580demr418946f8f.43.1715287065390; Thu, 09 May 2024 13:37:45 -0700 (PDT) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccce2449sm37492075e9.16.2024.05.09.13.37.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 May 2024 13:37:45 -0700 (PDT) Message-ID: <2e38efa4-5716-4d33-8e07-05d47b0896a8@jkqxz.net> Date: Thu, 9 May 2024 21:38:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240509151042.8D70B411AC8@natalya.videolan.org> From: Mark Thompson In-Reply-To: <20240509151042.8D70B411AC8@natalya.videolan.org> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/cbs_av1: Avoid shift overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 09/05/2024 16:10, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Wed May 1 21:44:33 2024 +0200| [d7924a4f60f2088de1e6790345caba929eb97030] | committer: Michael Niedermayer > > avcodec/cbs_av1: Avoid shift overflow > > Fixes: CID1465488 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=d7924a4f60f2088de1e6790345caba929eb97030 > --- > > libavcodec/cbs_av1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c > index 1d9ac5ab44..fb82996022 100644 > --- a/libavcodec/cbs_av1.c > +++ b/libavcodec/cbs_av1.c > @@ -301,7 +301,7 @@ static int cbs_av1_write_increment(CodedBitstreamContext *ctx, PutBitContext *pb > return AVERROR(ENOSPC); > > if (len > 0) > - put_bits(pbc, len, (1 << len) - 1 - (value != range_max)); > + put_bits(pbc, len, (1U << len) - 1 - (value != range_max)); > > CBS_TRACE_WRITE_END_NO_SUBSCRIPTS(); > What syntax element can call this with range_max - range_min == 31? (Do you have a stream?) Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".