From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D203C42320 for ; Mon, 17 Jan 2022 08:30:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D73C68AFAB; Mon, 17 Jan 2022 10:30:17 +0200 (EET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3107D68AEEC for ; Mon, 17 Jan 2022 10:30:10 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642408215; x=1673944215; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=qw3D7oqcYWCwTYgwTcwWmINU/LOwHsvMEzJIkIST5+g=; b=RtvAAOkeWCIePAbkSRMNToPoTOxOcngR7WHNnpbAzPDGkZXxY8I8ANzj Oz4tuiOI6sZPq/nZGeWmTTPcrWWGKz6FGwQ77QxUtvI1SFVvUnmhPjpVN zi8Xsd8hUIVF89bjHVUtweh4FfNpa3nGzhYjNygcyvx34bmzv/xueXBsI qA1U74zu1yJGmXijz77iNAVPnOqdCeep5mzfAzl7hG8ZPDNmYvkEtEuLQ bBkOdM5VTNz2krA08x7++7/N006Y9FbWtz4m/fo2VNhWVNaBrW3x7VkLU hAm+eNjEfBEcPC/KUkKPUbjxunuZviMBMQ+JJPEFCOsnRRSglKXk/EGbm Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10229"; a="242137829" X-IronPort-AV: E=Sophos;i="5.88,295,1635231600"; d="scan'208";a="242137829" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2022 00:30:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,295,1635231600"; d="scan'208";a="577976456" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 17 Jan 2022 00:30:05 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 17 Jan 2022 00:30:05 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 17 Jan 2022 00:30:04 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 17 Jan 2022 00:30:04 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 17 Jan 2022 00:30:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TDdz9wp1+4Lzl1SCkrROmuHBW7dW68QZHloTZ+tljMtk76jL/BBGGd3Gdo87C5+rXrksR1O+L7TGMMFN1MNiJahmAI22TdQRrBa2ONV+9e1FjMgyP6gVjAdjqMFf3dOja74FDgwfhqvrKRuzuKF2n57G0DaNVohRtRFvmfffCVHPYGwn2XFWHY3tdNXJ+qDCSMy7cr9NP2cb1qKkBwb4D9DHUD/kwP2MOi61qg9pf8P7JEllC69zJYSMHx8Hp4bZYLENzpZsyTa5L/MlE4mx6kaCim3iPtXTSKHajlxow4vdzf+rw8+RrVfc6dSEZO4hm3OIKPnZD4UsuZ6u9mgWTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qw3D7oqcYWCwTYgwTcwWmINU/LOwHsvMEzJIkIST5+g=; b=WiYS2tyF2lGDG9DIQGqmfk9GQiR9Cb3Wupp9a9+7kxKRvlsxWh74kbonJevdyySmWA55JaA4PBlFOxD81RtsylDL2np38p4VyDlhn+h4/bM7K1Bm7BMfQaZMwNEx2pkUYnK8wkQDAfFtlo7+hMXQm5LZ1Fh4+FNagCsOESo311co6zx6A7McJwbKjB4SkBpv+2dBmcCzEYlvGCPheEArrL3TS4uU04HM3nkFB4dmNgQkINxpJ1RDmr6WPJ9TC5Q0Fvijh0bm4DPWQCbBL6TsIxb0EgUbThi3+lFFTh3DMAGljQZmE/URI+iSnxHP3L8wfkMjz2nHAaV4bWwIm51RBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BYAPR11MB3717.namprd11.prod.outlook.com (2603:10b6:a03:b0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Mon, 17 Jan 2022 08:30:00 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%5]) with mapi id 15.20.4888.013; Mon, 17 Jan 2022 08:30:00 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9 Thread-Index: AQHYCEDYbxvbrcgxykCDVV/OtIl66qxm6FKA Date: Mon, 17 Jan 2022 08:30:00 +0000 Message-ID: <2de74c97e30007697825af8d68df3fdf5270350c.camel@intel.com> References: <20220113054525.14057-1-haihao.xiang@intel.com> In-Reply-To: <20220113054525.14057-1-haihao.xiang@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ed92460-d7a3-423d-55c3-08d9d9938d57 x-ms-traffictypediagnostic: BYAPR11MB3717:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ke6X/zPwXTYRKt4EI53+QgjjTI7PX+MnwE/g4an9NlIwNIOgr26/GHEPedtcWmnhma/c8TbCT3nKGEAQ4s7ighg5MfIqpx8RQrdhmxpuIjMtcTNGzCBeZpD4gGFEA6VOqNKbZ6yRjyJLuuzWUAiHKWQWMNbgJHfi6IEEEqaXkFzV2WonpW6ksDD8hBV6Rn2Mf4BIo1r/+EY4wI6kA7TcbcvOhxMD4I/9U0lgsV15FK9Ft3UG/nh2IjQz0/fMz3slC5r9g6aJ/DIG2HENa1BTW5r6fqwAQvSfamhMs8BxzxIFzVXR0/JsC4hRrfaKVQ2jydVI0K+di6XXAIO3ixAgxCAnm8Tg5CCWK2Ad7ZugT7ejqqolg+UdDWX84cyBlhrmsESK0h2xBJn7iB8c7k+YcYfHwrQx8hLHL3MPRdwcj/A6vm4cSYXgcPXsdSeshfWpPkD2xIb+VtgK7SOARGfqs8U98M4yOo0NDioxsrAkBKVxrbPkcDQC1SDaKiQaUt/qm5/akO28+Do3j1UxVpseObq6HNHCgJexz0fUUb5ey0x07LK0lXtXMwhM4oau0ETQ4yHYqfTtiYSj5aE0MWBcPbze1Kt35Lc2a35R+g7pUE2U4wPiyZ/z93qzscDLtss9IjXZL+5KTpE4E0pIsaCho2oOWzM+IUShqdaE9XAJtmF7zoHpOP54IH2Cj2ZLvmqlWlPzVnTsUp3ngypNO8krMV9CzhILAPnEip4CCEqYg4E= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(66446008)(2616005)(66556008)(122000001)(36756003)(82960400001)(71200400001)(76116006)(66476007)(6486002)(316002)(2906002)(38100700002)(6512007)(5660300002)(8936002)(6506007)(86362001)(26005)(508600001)(91956017)(6916009)(38070700005)(8676002)(64756008)(66946007)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?emZucGJVUHJVMWg5V3RuUHAxeDZGWmV5SHd4TFIyRkh0NUZwUjVKSVFhQ0ly?= =?utf-8?B?Ym8xaURaVE5QaG56aDZOLzEySVZMWmc2UDRFcElvN0V3R3krRkgxb0ZYNnpk?= =?utf-8?B?QytQdkNsc3hSZWtoU3B4QmFhcXI3YjI2L0NDcDUzM2cyakxFQnNuSC91WmFV?= =?utf-8?B?MENEczRVazA3TmZmN2ZtRERTNGg1S2MyTVhJZGlXcUtsd3EyMm01T2p1SldM?= =?utf-8?B?bGUxbFNOVm9UY0phNVVVc2NiWjVwRno0SFNVRlRwa0IxSlQyeEhWSW0zOVBL?= =?utf-8?B?TDBKbU9OdDVEMUZ3RUZMQzV4SEhqdS9ZaW5jaU5xeEYwWC93a2NZclhtMTl6?= =?utf-8?B?YkNOUXJIRDMwbXVzNWZlM21iNVBqNnlpMmhrcDFzdDUrN05DNStJR3FrZUtR?= =?utf-8?B?VHdCN0ZuaVpSVTcxNC9Ma2hFNUhzZEZoSWw1WnJoYUFpTFBFVlFma3QxL09u?= =?utf-8?B?Z29OenQ2ZkpqNzNyYzExSm92dGNsRllIUXJ4UnovZ2ViVWVMcXlwbjZtb1Rw?= =?utf-8?B?UVpDT09mVTR2R2FBeU1mSHh2YVdhbC9UOHlPaHNBWm9oczdyZHVIWXFMSGpt?= =?utf-8?B?d3BnV3BYVlI0RlR6bGFmSHRQZFFNWVJvYmRhcCswL3JCeHRXUXgvZXBaUzJz?= =?utf-8?B?dVRZd3lYdW45R3FxcWp1VmQ0Z3BOU1dGOXZpOGlhcWd4RTlQWGM1bkhtU1Iw?= =?utf-8?B?R1R5Q1NNeitTVjdSZmdUWVlML1IyeEVOdkFmU0V1cFZiZ3lnNW1KWEFwRFRR?= =?utf-8?B?T1B0R0FXY1dtYmY2cmRXZFBCOHFvQWMrM2dWcE96NmNpV0F5UDNIdFlvQUhx?= =?utf-8?B?M2dUazNOeUU4N0dyaG8wTzNKZlBLRDYzODJoK3F1NVNTTFBlWU5IVzJhMTlT?= =?utf-8?B?N1FFOVV3cHVyN3hiTituMFlyYkRidjhHRlhMb1M4bGxtSVN1T3ZtUW1DU2sy?= =?utf-8?B?aUJwNCsvNEZvZHRuUXZ3cEl1a3J4ZUxlWEo2bEpBeDJCYVdpb243WHBzQWdO?= =?utf-8?B?ek4zVllvMi90NWprNmdhQXl1MWE0aVRSR2hOd2k4MTRFYURhZGlCNml4MVJl?= =?utf-8?B?dEprQXVjeVJ5NjdqT3lua0VOSHRxMlRmUzM1ZzNjTHJieTN0Lzk3YmpLWVZC?= =?utf-8?B?WWxjUU8wYktJeTg4azE0NXIvejhyTFg0dE16bnVIdXNHWDNFSUlwL2R1Tmsv?= =?utf-8?B?RG51SzJlQXdjVDdXR2o1UTRaNU5HOGg4RktjNm5vK2dvUDhCQ2VJaFNCN1J2?= =?utf-8?B?Qnk5ZDRuNlo4eWRyV0dZUU9NVkl4L1MvVTNZbmdHSVdkZDQrWTZYVXNjOWtY?= =?utf-8?B?Wk5tOUpFWW1KL2RIM3JkVW9qV0xvVU9tamdNK01zMGNHSDhBSHkwS0pHWjVn?= =?utf-8?B?Y1JNZVBIeWNLaWtHRmQyUVB2LzJ5Y2ZtdmxoaWJVbXhwekdvejZqTTJrbVpK?= =?utf-8?B?WTJDa1JvdGxtQ2dUMUFnZ0RyVk1ydWQ4VExoc29sWHEyd0EzaXE4SFpCdU05?= =?utf-8?B?aStBKzBwakd0NUNMUjFOWHNCNmFmZ2JDTGdmN3Npc21qbEJNSEVEcGgvMk9j?= =?utf-8?B?SzhFRHFOQ2F1Vk9RUkxOR3RpUThhMld5UWtaOVNZOUg0am8wbDlZRlA4bTZp?= =?utf-8?B?UllJTVNXMUJyeUlFOTRPZ3Jjek9KeWpQWEM2UjB2aVArOGo5NURHR3dqd3hk?= =?utf-8?B?MWNQZVdKQTl6WnJIU2NIVVYxSCtGeHRXWC9WZ240eUVtYTljY1RzL0NUVFoz?= =?utf-8?B?WnBPWEQ1VVZuQmFXOTF0bDgxMTJSKzV4K3Rnb1BIaDY4WnRjOGhiYVhNTFgw?= =?utf-8?B?UmpuaUZ0S1I0TCtjV01qVUNaOVJYUEhPQjNJR0ZhUnpnU2U3cEJFL3p5QVl3?= =?utf-8?B?S1M0ZHR0Tk16YVRUOHZUZmh5K3FaQ0U4a3ZMaERHR0JIU3BuaURndU1vNERV?= =?utf-8?B?cnNCSzNtaE5LNXhpb01reitYNGxRL2JmZ2dJRGRTWEJiUURwbnRoY3dMVm9v?= =?utf-8?B?M2ZET3FDU0NqQzV6UHk2U2UvaWNtc3FLMW1FTUJjWU53S3hHZWE4SzhZVFJF?= =?utf-8?B?UkNyWkpTNXBaaUt0Mm8zUERyOGM1SjltdG52aFBiMmF2cXBVc2xBZGRGU0I4?= =?utf-8?B?NUJWTTFOUnp6SGVXYjNFMElSbGVWNkYzNm05d0FUSzNKelNmcWhaeGQwSk03?= =?utf-8?Q?VsfI3jJpX+NyVSts9K4rp8I=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ed92460-d7a3-423d-55c3-08d9d9938d57 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2022 08:30:00.4054 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RCV0SfkBMTiZG5F8ldGnJt/sLRKiGrni3pqw76Tv/FZDuvLfZl0Kqq22R4lj6taRoVWbUE58O33cXr03xVntPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3717 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-01-13 at 13:45 +0800, Haihao Xiang wrote: > Add -tile_rows and -tile_cols options to specify the number of tile > rows and columns > > Signed-off-by: Haihao Xiang > --- > v2: add option descriptions in the doc > > doc/encoders.texi | 6 ++++++ > libavcodec/qsvenc.c | 4 ++++ > libavcodec/qsvenc.h | 1 + > libavcodec/qsvenc_vp9.c | 10 ++++++++++ > 4 files changed, 21 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 7cc8be1209..a4176089d5 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -3457,6 +3457,12 @@ These options are used by vp9_qsv > @item profile2 > @item profile3 > @end table > + > +@item @var{tile_cols} > +Number of columns for tiled encoding (requires libmfx >= 1.29). > + > +@item @var{tile_rows} > +Number of rows for tiled encoding (requires libmfx >= 1.29). > @end table > > @section snow > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index 4e7a15f060..4cbc9ff4dc 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -939,6 +939,10 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extvp9param.Header.BufferId = MFX_EXTBUFF_VP9_PARAM; > q->extvp9param.Header.BufferSz = sizeof(q->extvp9param); > q->extvp9param.WriteIVFHeaders = MFX_CODINGOPTION_OFF; > +#if QSV_HAVE_EXT_VP9_TILES > + q->extvp9param.NumTileColumns = q->tile_cols; > + q->extvp9param.NumTileRows = q->tile_rows; > +#endif > q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer *)&q- > >extvp9param; > } > #endif > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index 31516b8e55..00ee52a5d1 100644 > --- a/libavcodec/qsvenc.h > +++ b/libavcodec/qsvenc.h > @@ -41,6 +41,7 @@ > > #define QSV_HAVE_EXT_HEVC_TILES QSV_VERSION_ATLEAST(1, 13) > #define QSV_HAVE_EXT_VP9_PARAM QSV_VERSION_ATLEAST(1, 26) > +#define QSV_HAVE_EXT_VP9_TILES QSV_VERSION_ATLEAST(1, 29) > > #define QSV_HAVE_TRELLIS QSV_VERSION_ATLEAST(1, 8) > #define QSV_HAVE_MAX_SLICE_SIZE QSV_VERSION_ATLEAST(1, 9) > diff --git a/libavcodec/qsvenc_vp9.c b/libavcodec/qsvenc_vp9.c > index 9329990d11..1168ddda0e 100644 > --- a/libavcodec/qsvenc_vp9.c > +++ b/libavcodec/qsvenc_vp9.c > @@ -73,6 +73,16 @@ static const AVOption options[] = { > { "profile2", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = > MFX_PROFILE_VP9_2 }, INT_MIN, INT_MAX, VE, "profile" }, > { "profile3", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = > MFX_PROFILE_VP9_3 }, INT_MIN, INT_MAX, VE, "profile" }, > > +#if QSV_HAVE_EXT_VP9_TILES > + /* The minimum tile width in luma pixels is 256, set maximum tile_cols to > 32 for 8K video */ > + { "tile_cols", "Number of columns for tiled > encoding", OFFSET(qsv.tile_cols), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 32, > VE }, > + /* Set maximum tile_rows to 4 per VP9 spec */ > + { "tile_rows", "Number of rows for tiled > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 4, > VE }, > +#else > + { "tile_cols", "(not > supported)", OFFSET(qsv.tile_cols), AV_OPT_TYPE_INT, > { .i64 = 0 }, 0, 0, VE }, > + { "tile_rows", "(not > supported)", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, > { .i64 = 0 }, 0, 0, VE }, > +#endif > + > { NULL }, > }; > Will apply, -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".