From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit
Date: Thu, 05 Jan 2023 18:14:57 +0100
Message-ID: <2dbbd168480d4a50468a29c8c9b5451e40c0c488.camel@haerdin.se> (raw)
In-Reply-To: <20230105104151.2055-1-Dmitriy.Ovchinnikov@amd.com>
tor 2023-01-05 klockan 11:41 +0100 skrev Dmitrii Ovchinnikov:
> From: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com>
>
> This change improves the performance and multicore
> scalability of the vp9 codec for streaming single-pass encoded
> videos. The
> current thread limit for ffmpeg codecs is 16 (MAX_AUTO_THREADS in
> pthread_internal.h) due to a limitation in H.264 codec that prevents
> more
> than 16 threads being used.
This limitation should be restricted to H.264 IMO, not applied to all
codecs wholesale. I ran into this issue with jpeg2000dec.
>
> Increasing the thread limit to 64 for vp9 improves
> the performance for encoding 4K raw videos for streaming by up to 47%
> compared to 16 threads, and from 20-30% for 32 threads, with the same
> quality
> as measured by the VMAF score.
>
> Did not need to add a check for limit in libvpx as it is already
> present
> in libvpx/vp9/vp9_cx_iface.c:
> RANGE_CHECK_HI(cfg, g_threads, 64);
Perhaps we should have a table of known max number of threads per
codec?
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-01-05 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 10:41 Dmitrii Ovchinnikov
2023-01-05 17:14 ` Tomas Härdin [this message]
2023-01-10 3:06 ` James Zern
2023-01-10 10:47 ` mypopy
2023-01-11 1:23 ` James Zern
2023-01-17 22:06 ` James Zern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dbbd168480d4a50468a29c8c9b5451e40c0c488.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git