From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E4B143599 for ; Fri, 17 Jun 2022 09:41:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCEB168B8A1; Fri, 17 Jun 2022 12:41:06 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9614568B887 for ; Fri, 17 Jun 2022 12:41:00 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 22D3D26EB38 for ; Fri, 17 Jun 2022 11:41:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1655458860; bh=VEyeXKX+/odV1yKC7XCR0lWfjR0ksWLA449lbS5+BAo=; h=Date:Subject:To:References:From:In-Reply-To; b=R2QJYGDam4F2zixcatq7GIJbzLZTPt0GPf4zstp4NISCV/79fHLtE0NuLuGlCQolX 91DSv+/RHd+hbqSdRbMc6v2hlEnnbIs+joMB3GiDe6UZh+9VJffBU9d5+k+XIJPt1h qS6qQVLtAhhPpajpQIS10AY4HPuFPf0V7LD46vPKEsLyLg3iOH5EbxfpxppkpOXr99 TgGRubZvvwhsTeNrdNDL7m99ZXWf9SmunoRNemItXCw1L7+vWsuxq21Oq0owk+tOg8 ZONPbmZukyIkONYgZhwqZobDlFHsAJoqn6us0vTiaJhEEMO7/4DCA+IWGQa34CRlAy YypsRezbgQ+NA== Message-ID: <2d163f70-25e5-27d6-fc6a-a5a8084a03d7@rothenpieler.org> Date: Fri, 17 Jun 2022 11:40:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <9642852e9da11714c8643833562b6e86133ce1a1.camel@amazon.it> <0215838ca87728a7e2742ab19af7fe1d5c3f9abc.camel@amazon.it> From: Timo Rothenpieler In-Reply-To: <0215838ca87728a7e2742ab19af7fe1d5c3f9abc.camel@amazon.it> Subject: Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 17.06.2022 10:41, Carotti, Elias wrote: > Hi all, > any chance someone could possibly have a look at this patch, please? > Thanks in advance > > > > On Fri, 2022-06-10 at 10:11 +0000, Carotti, Elias wrote: >> Hi, >> patch attached to add support for passing down to libx264 information >> about which macroblock could be eligible for being coded as P_SKIP. >> > > > > NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico > There's a stray printf in the patch. Also, what if a frame with such side data is passed to not-x264? Won't it leak the memory? From the looks if it, this entirely relies on x264 to free it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".