Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO
Date: Fri, 17 Jun 2022 11:40:57 +0200
Message-ID: <2d163f70-25e5-27d6-fc6a-a5a8084a03d7@rothenpieler.org> (raw)
In-Reply-To: <0215838ca87728a7e2742ab19af7fe1d5c3f9abc.camel@amazon.it>

On 17.06.2022 10:41, Carotti, Elias wrote:
> Hi all,
> any chance someone could possibly have a look at this patch, please?
> Thanks in advance
> 
> 
> 
> On Fri, 2022-06-10 at 10:11 +0000, Carotti, Elias wrote:
>> Hi,
>> patch attached to add support for passing down to libx264 information
>> about which macroblock could be eligible for being coded as P_SKIP.
>>
> 
> 
> 
> NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico
> 

There's a stray printf in the patch.

Also, what if a frame with such side data is passed to not-x264? Won't 
it leak the memory?
 From the looks if it, this entirely relies on x264 to free it.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-06-17  9:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 10:11 Carotti, Elias
2022-06-17  8:41 ` Carotti, Elias
2022-06-17  9:40   ` Timo Rothenpieler [this message]
2022-06-17 10:15     ` Carotti, Elias
2022-06-17 10:34       ` Timo Rothenpieler
2022-06-17 10:59         ` Carotti, Elias
2022-06-17 15:10           ` Timo Rothenpieler
2022-06-17 15:30             ` Carotti, Elias
2022-06-17 23:41             ` Stefano Sabatini
2023-05-03 12:27             ` Carotti, Elias
2023-05-05  8:03               ` Carotti, Elias
2022-06-18 15:06   ` Anton Khirnov
2022-06-21  8:48     ` Carotti, Elias
2022-06-23 13:29       ` Anton Khirnov
2022-06-23 14:21         ` Andreas Rheinhardt
2022-06-23 14:48         ` Anton Khirnov
2022-06-24  9:14           ` Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d163f70-25e5-27d6-fc6a-a5a8084a03d7@rothenpieler.org \
    --to=timo@rothenpieler.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git