Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix memory leak when using "reinit" runtime command

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix memory leak when using "reinit" runtime command

[Steven Zhou]

> Bump

A quick way to demonstrate the memleak:
```
./configure --enable-libfreetype --enable-libfribidi --enable-libfontconfig --enable-libharfbuzz make -j `nproc valgrind --leak-check=full ./ffmpeg -nostdin -y -f lavfi \ -i testsrc=size=640x360:rate=10 -filter_complex \
"[0:v]format=yuv420p,sendcmd=c='0.5 drawtext reinit \\\'text=five\\\'',drawtext=text=zero:\
x=(w-text_w)/2:y=(h-text_h)/2:fontsize=30:fontcolor=white@0.8[vout]" \ -map "[vout]" -t 1 output.y4m ``` -StevenZ

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix memory leak when using "reinit" runtime command

[James Almer]

[-- Attachment #1.1.1: Type: text/plain, Size: 789 bytes --]

On 11/22/2024 10:20 PM, Steven Zhou wrote:
> Free AVOption in drawtext private context when freeing old copy of drawtext
> private context during processing of "reinit" runtime command.
> 
> Signed-off-by: Steven Zhou <steven.zhou@netint.ca>
> ---
>   libavfilter/vf_drawtext.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
> index 8de24625d6..038646b112 100644
> --- a/libavfilter/vf_drawtext.c
> +++ b/libavfilter/vf_drawtext.c
> @@ -1226,6 +1226,7 @@ static int command(AVFilterContext *ctx, const char *cmd, const char *arg, char
>   
>           ctx->priv = old;
>           uninit(ctx);
> +        av_opt_free(old);
>           av_freep(&old);
>   
>           ctx->priv = new;

Will apply.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".