From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix memory leak when using "reinit" runtime command
Date: Fri, 17 Jan 2025 20:35:47 -0300
Message-ID: <2d00d7c3-8b83-4f45-ae4b-c13da475a36d@gmail.com> (raw)
In-Reply-To: <YT3P288MB0329C50F0BC8B773573868C1E32C2@YT3P288MB0329.CANP288.PROD.OUTLOOK.COM>
[-- Attachment #1.1.1: Type: text/plain, Size: 789 bytes --]
On 11/22/2024 10:20 PM, Steven Zhou wrote:
> Free AVOption in drawtext private context when freeing old copy of drawtext
> private context during processing of "reinit" runtime command.
>
> Signed-off-by: Steven Zhou <steven.zhou@netint.ca>
> ---
> libavfilter/vf_drawtext.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
> index 8de24625d6..038646b112 100644
> --- a/libavfilter/vf_drawtext.c
> +++ b/libavfilter/vf_drawtext.c
> @@ -1226,6 +1226,7 @@ static int command(AVFilterContext *ctx, const char *cmd, const char *arg, char
>
> ctx->priv = old;
> uninit(ctx);
> + av_opt_free(old);
> av_freep(&old);
>
> ctx->priv = new;
Will apply.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-01-17 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YT3P288MB0329C50F0BC8B773573868C1E32C2@YT3P288MB0329.CANP288.PROD.OUTLOOK.COM>
[not found] ` <YT3P288MB032913E67B0D3D3DA0DA4826E32C2@YT3P288MB0329.CANP288.PROD.OUTLOOK.COM>
2025-01-17 22:35 ` Steven Zhou
2025-01-17 23:35 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d00d7c3-8b83-4f45-ae4b-c13da475a36d@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git