From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavf/srtdec: Permit streaming input
Date: Mon, 01 Apr 2024 16:34:28 +0200
Message-ID: <2ceec7e04186f1b9e0b6e84eb64ebb0f5d97dc78.camel@haerdin.se> (raw)
In-Reply-To: <GV1P250MB0737BC01860AAA755ADDA8DE8F392@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
lör 2024-03-30 klockan 17:02 +0100 skrev Andreas Rheinhardt:
> If you force reordering on our users, then this is a breaking change
Another thing that bears keeping in mind: sorting isn't consistent even
across demuxers that sort. Most sort by timestamp (SUB_SORT_TS_POS),
but vobsub sorts by byte position (SUB_SORT_POS_TS). It does this so as
to be able to merge split subtitles later, but it does then not sort by
timestamp after merging, as far as I can tell.
I'm a bit busy with other stuff in the coming days, but hopefully I
should be able to knock out a prototype by the end of the week that
still provides sorted subs when possible, except when the input is a
stream (which doesn't work now anyways).
This kind of nonsense is why being strict with input is a good idea.
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-01 14:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 22:55 [FFmpeg-devel] [PATCH 1/3] lavf/subtitles: Do not eat \n\n Tomas Härdin
2024-03-28 22:56 ` [FFmpeg-devel] [PATCH 2/3] lavf/srtdec: Permit streaming input Tomas Härdin
2024-03-28 22:57 ` Tomas Härdin
2024-03-29 23:35 ` Michael Niedermayer
2024-03-30 0:03 ` Tomas Härdin
2024-03-30 8:31 ` Tomas Härdin
2024-03-30 11:36 ` Paul B Mahol
2024-03-30 11:44 ` Nicolas George
2024-03-30 14:44 ` Tomas Härdin
2024-03-30 14:49 ` Nicolas George
2024-03-30 15:23 ` Tomas Härdin
2024-03-30 15:34 ` Nicolas George
2024-03-30 16:02 ` Andreas Rheinhardt
2024-03-30 16:28 ` Tomas Härdin
2024-04-01 13:15 ` arch1t3cht
2024-04-01 14:34 ` Tomas Härdin [this message]
2024-03-28 22:57 ` [FFmpeg-devel] [PATCH 1/3] lavf/subtitles: Do not eat \n\n Tomas Härdin
2024-03-28 23:06 ` [FFmpeg-devel] [PATCH 3/3] lavf/subtitles: Unfix ticket #5032 Tomas Härdin
2024-03-29 12:29 ` Tomas Härdin
2024-03-30 0:08 ` [FFmpeg-devel] [PATCH 1/2] lavf/subtitles: Add ff_text_peek_r16(), only accept \r, \n, \r\n and \r\r\n line endings Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ceec7e04186f1b9e0b6e84eb64ebb0f5d97dc78.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git