From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 60FE74B0C9 for ; Mon, 29 Jul 2024 02:03:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3181168D275; Mon, 29 Jul 2024 05:03:28 +0300 (EEST) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D54468D1C1 for ; Mon, 29 Jul 2024 05:03:21 +0300 (EEST) Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3db192667f5so336677b6e.2 for ; Sun, 28 Jul 2024 19:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722218599; x=1722823399; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=kiQISaUcZP83Aanwi+HUZwxZYrMMQhNADyPgxlY49PA=; b=bP7GzFN4QwOaIrGuTkT0umOi0jgzljgXgQeBm3+pcbHzb1SkVL6Z502JD/CiQj3uXg oSz550rWEmW9fBPXY1myHlbABCrtCxiJHD3sTNaKHq9UDNmEXrlqg8iu7MkuLgLYuQd6 18FOnGEUo4O7Hc6J6pj8H/6iFNy110xQyCcaV5ZXb+nFtNjqKpsJDXc7UnONWwwepvyr a3gVAx6OZijeP/wR4Gbnz2Yz01YNzO0U0rXob8eOhBdb63pUsZtj7EQfQkNiANJ7C7Ol qDz8+QZfqf9wUhINyMDhtFjK1sLEEgqkQit66iRYMpMoFDLxHFN6GbfRDQidL49q32QQ e+pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722218599; x=1722823399; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kiQISaUcZP83Aanwi+HUZwxZYrMMQhNADyPgxlY49PA=; b=PdyV3wZnZ/0+ela07BHexGUWuPWDxbrBdfmNLuFAoeM2UurhdCnsnDOrEcDVATBzl3 e7ihIIRutBZCtFvU5T5dZq5HmBjHyjd9nhnewqjiXPrKPPB6UVo+s/IWQJxUw0Eg3sTE yKsJIt1o1KxGrQ+2g6LCim2g1xJhJezasKXWyTvtUcWrD5aFLlaLQowK9vlgWkzRmsqI qUwFDW3I0saEYwFZs0Kp9ULiPOWheiCXUisipOa5OYRUxsG0bOC302hyANaae2gFckXA 60JkRALmGIBWx10gqQguZFPoeuXNeHKZ3XiIh4T8twnCGnF/1R19XHeOdgibCfqnvADl 8NjQ== X-Gm-Message-State: AOJu0Yymsi/9lQTw1s+1WX0wgt+Fir16TAhQmEcjIpMuNXrBEIKwjyM+ G08LxLDebKA+yjFkGU6ntebC3G8NK5eIdwqlOg3R8g0Ec1afrt/zStAE7A== X-Google-Smtp-Source: AGHT+IFbMffFL3or27sLYmYnVZXC6w308qwGHzBfJ54VaF/GhrcFBoweH6yN+bxR6PcZvkVq8l0dow== X-Received: by 2002:a05:6358:430e:b0:1ac:2b8b:a185 with SMTP id e5c5f4694b2df-1acfac8eddbmr748548355d.2.1722218599090; Sun, 28 Jul 2024 19:03:19 -0700 (PDT) Received: from [192.168.1.35] (c-68-56-149-176.hsd1.mi.comcast.net. [68.56.149.176]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bb3f943352sm47308896d6.73.2024.07.28.19.03.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jul 2024 19:03:18 -0700 (PDT) Message-ID: <2ce5717c-36ac-40f7-a660-a98a6a9bab82@gmail.com> Date: Sun, 28 Jul 2024 22:03:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240714050035.2007332-1-marth64@proxyid.net> Content-Language: en-US-large From: Leo Izen Autocrypt: addr=leo.izen@gmail.com; keydata= xjMEZZw8HxYJKwYBBAHaRw8BAQdAgcfI+LbtjWarA7LQu6/WAPlKkn9tn4HalmHgGVhMUdzN KkxlbyBJemVuIChUcmFuZXB0b3JhKSA8bGVvLml6ZW5AZ21haWwuY29tPsKTBBMWCgA7FiEE HYMKC85GcJ4gOyb8dk5I6kgiGDMFAmWcPB8CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcC F4AACgkQdk5I6kgiGDOnGAEA+oJFwblAblnhK+T5a5EuEbXMTZG4FkYTYz0VmjJ0NHIA/Rn9 ZE9+EEsH8fmT0hRJSiM3+zbkwQJA9gVVYAek9kMKzjgEZZw8HxIKKwYBBAGXVQEFAQEHQDes 4thejF9AU2rkGuDuut3CQYwB4SVpI4EzU8uvPJgfAwEIB8J4BBgWCgAgFiEEHYMKC85GcJ4g Oyb8dk5I6kgiGDMFAmWcPB8CGwwACgkQdk5I6kgiGDOv3QD+PLXrL0Ihk675Ip5FG+VJOodN 6e+5n3iYC6wJ75eqG3EA/1nCywoGXlCYuzXgq3el6NOn+8awwaXcTVJFzZCRbe8M In-Reply-To: <20240714050035.2007332-1-marth64@proxyid.net> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacenc: Correct option description for aac_coder fast X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/14/24 1:00 AM, Marth64 wrote: > The description advertises fast as "Default fast search", but > this has not been the default for a long time (current default > is twoloop). > > Signed-off-by: Marth64 > --- > libavcodec/aacenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c > index 163598e938..88037c7f87 100644 > --- a/libavcodec/aacenc.c > +++ b/libavcodec/aacenc.c > @@ -1392,7 +1392,7 @@ static const AVOption aacenc_options[] = { > {"aac_coder", "Coding algorithm", offsetof(AACEncContext, options.coder), AV_OPT_TYPE_INT, {.i64 = AAC_CODER_TWOLOOP}, 0, AAC_CODER_NB-1, AACENC_FLAGS, .unit = "coder"}, > {"anmr", "ANMR method", 0, AV_OPT_TYPE_CONST, {.i64 = AAC_CODER_ANMR}, INT_MIN, INT_MAX, AACENC_FLAGS, .unit = "coder"}, > {"twoloop", "Two loop searching method", 0, AV_OPT_TYPE_CONST, {.i64 = AAC_CODER_TWOLOOP}, INT_MIN, INT_MAX, AACENC_FLAGS, .unit = "coder"}, > - {"fast", "Default fast search", 0, AV_OPT_TYPE_CONST, {.i64 = AAC_CODER_FAST}, INT_MIN, INT_MAX, AACENC_FLAGS, .unit = "coder"}, > + {"fast", "Fast search", 0, AV_OPT_TYPE_CONST, {.i64 = AAC_CODER_FAST}, INT_MIN, INT_MAX, AACENC_FLAGS, .unit = "coder"}, > {"aac_ms", "Force M/S stereo coding", offsetof(AACEncContext, options.mid_side), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, AACENC_FLAGS}, > {"aac_is", "Intensity stereo coding", offsetof(AACEncContext, options.intensity_stereo), AV_OPT_TYPE_BOOL, {.i64 = 1}, -1, 1, AACENC_FLAGS}, > {"aac_pns", "Perceptual noise substitution", offsetof(AACEncContext, options.pns), AV_OPT_TYPE_BOOL, {.i64 = 1}, -1, 1, AACENC_FLAGS}, This LGTM, I will apply it soon. - Leo Izen (Traneptora) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".