From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4B298430E5 for ; Fri, 20 May 2022 16:51:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 158B268AF3B; Fri, 20 May 2022 19:51:55 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1009268B2C4 for ; Fri, 20 May 2022 19:51:47 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 24KGpkuX026367-24KGpkuY026367 for ; Fri, 20 May 2022 19:51:46 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 6158BA150B for ; Fri, 20 May 2022 19:51:46 +0300 (EEST) Date: Fri, 20 May 2022 19:51:44 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <8bbee5d6-9705-58bb-ba06-59340094d5b1@gmail.com> Message-ID: <2ce05681-f99f-a93e-1c40-19c7c33223@martin.st> References: <6aa08dec-4d80-298b-7d98-11a88e74bcff@gmail.com> <8bbee5d6-9705-58bb-ba06-59340094d5b1@gmail.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/libx264: allow to disable definition of X264_API_IMPORTS macro X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 20 May 2022, Derek Buitenhuis wrote: > On 5/20/2022 5:37 PM, Soft Works wrote: >> But if Matt's patch would be agreeable, then that would surely be >> the best outcome. >> >> I can rebase and resubmit his patch if you would find it agreeable. > > Ah - that was not clear to me. > > If Ubuntu LTS does indeed ship such an old x264, the fallback discussed there > may be indeed needed, but it's pretty simple to add. It does seem a tad silly > given that the define only affects Windows, but I get where Michael is coming > from. > > I think Matt's patch + fallback for older versions seems reasonable, if, in fact > needed. Ideally we'd just drop support for older x264, though. Not sure which most > people would prefer. Maybe just drop support for older versions when on Windows? That should cover those cases (even if ffmpeg is built with msvc but x264 with mingw, or vice versa) quite well, while still not bothering other platforms at all. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".