From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07D4D48862 for ; Mon, 18 Dec 2023 22:15:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2CE7F68D0BD; Tue, 19 Dec 2023 00:15:38 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 04CBF68CF86 for ; Tue, 19 Dec 2023 00:15:31 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 3BIMFUL5027493-3BIMFUL6027493; Tue, 19 Dec 2023 00:15:30 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id C1773A146B; Tue, 19 Dec 2023 00:15:30 +0200 (EET) Date: Tue, 19 Dec 2023 00:15:29 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20231209210731.201099-1-klember@redhat.com> Message-ID: <2ce013ac-25de-1bb4-2870-949d30cb056@martin.st> References: <20231209210731.201099-1-klember@redhat.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Kalev Lember Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 9 Dec 2023, Kalev Lember wrote: > With the way the runtime checks are currently set up, every single > openh264 release, no matter how minor, is considered an ABI break and > requires ffmpeg recompilation. This is unnecessarily strict because it > doesn't allow downstream distributions to ship any openh264 bug fix > version updates without breaking ffmpeg's openh264 support. > > Years ago, at the time when ffmpeg's openh264 support was merged, > openh264 releases were done without a versioned soname (the library was > just libopenh264.so, unversioned). Since then, starting with version > 1.3.0, openh264 has started using versioned sonames and the intent has > been to bump the soname every time there's a new release with an ABI > change. > > This patch drops the exact version check and instead adds a minimum > requirement on 1.3.0 to the configure script. > > Signed-off-by: Kalev Lember > --- Thanks, pushed now! // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".