From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 22F7E40C96 for ; Wed, 8 Jun 2022 20:27:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BCDA868B6C2; Wed, 8 Jun 2022 23:26:59 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 46F3E68B546 for ; Wed, 8 Jun 2022 23:26:53 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id ADC8EE736E for ; Wed, 8 Jun 2022 22:26:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UoMzn-i5Fb03 for ; Wed, 8 Jun 2022 22:26:51 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id CC191E7281 for ; Wed, 8 Jun 2022 22:26:50 +0200 (CEST) Date: Wed, 8 Jun 2022 22:26:50 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <2ccfb34-e4e4-647b-948-f5c0b3cb389e@passwd.hu> References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v4] libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 28 May 2022, softworkz wrote: > From: softworkz > > Those are always showing up on Patchwork when FATE tests are failing, > covering some possibly more useful information. > > The volatile keyword was used as a workaround for an eight year old > clang version. > > Signed-off-by: softworkz > --- > libavutil/tests/md5: Avoid warnings Will apply. Thanks, Marton > > Those are always showing up on Patchwork when FATE tests are failing, > covering some possibly more useful information. > > v4: > > * The problem still exists: > https://patchwork.ffmpeg.org/check/62130/ > * as was suggested, this patch removes the volatile keyword altogether > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v4 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v4 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20 > > Range-diff vs v3: > > 1: e54769c621 ! 1: 21fdf3eba2 libavutil/tests/md5: Avoid warnings > @@ Metadata > Author: softworkz > > ## Commit message ## > - libavutil/tests/md5: Avoid warnings > + libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings > > - Those are always showing up on Patchwork > - when FATE tests are failing, covering > - some possibly more useful information. > + Those are always showing up on Patchwork when FATE tests are failing, > + covering some possibly more useful information. > + > + The volatile keyword was used as a workaround for an eight year old > + clang version. > > Signed-off-by: softworkz > > @@ libavutil/tests/md5.c: int main(void) > - volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > - // FIXME remove volatile once it has been fixed and all fate clients are updated > + > -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 > -+ volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > -+#endif > + uint8_t in[1000]; > > for (i = 0; i < 1000; i++) > > > libavutil/tests/md5.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c > index 42e4538e0a..0ac8f2834e 100644 > --- a/libavutil/tests/md5.c > +++ b/libavutil/tests/md5.c > @@ -33,8 +33,8 @@ int main(void) > { > uint8_t md5val[16]; > int i; > - volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > - // FIXME remove volatile once it has been fixed and all fate clients are updated > + > + uint8_t in[1000]; > > for (i = 0; i < 1000; i++) > in[i] = i * i; > > base-commit: 9fba0b8a8c754a012fc74c90ffb7c26a56be8ca0 > -- > ffmpeg-codebot > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".