Re: [FFmpeg-devel] [PATCH v11 06/13] qsvenc: support multi-frame encode when MFX_VERSION < 2.0

["Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>]

On Thu, 2022-07-21 at 00:45 +0200, Andreas Rheinhardt wrote:
> Xiang, Haihao:
> > From: Haihao Xiang <haihao.xiang@intel.com>
> > 
> > Multi-frame encode isn't supported for MFX_VERSION >= 2.0[1][2]. This is
> > in preparation for oneVPL support
> > 
> > [1] 
> > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_intel_media_sdk.html#msdk-full-name-feature-removals
> > [2] https://github.com/oneapi-src/oneVPL
> > ---
> >  libavcodec/qsvenc.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h
> > index 4cadc38a59..40e2f65eff 100644
> > --- a/libavcodec/qsvenc.h
> > +++ b/libavcodec/qsvenc.h
> > @@ -44,7 +44,7 @@
> >  #else
> >  #define QSV_HAVE_AVBR   0
> >  #define QSV_HAVE_VCM    0
> > -#define QSV_HAVE_MF     1
> > +#define QSV_HAVE_MF     !QSV_ONEVPL
> >  #endif
> >  
> >  #define QSV_COMMON_OPTS \
> 
> "support multi-frame encode when MFX_VERSION < 2.0" sounds as if you
> were adding support for multi-frame encode. But the remaining commit
> message makes it clear that you are actually restricting multi-frame
> encode to MFX_VERSION < 2.0. So maybe you should reword the commit title
> accordingly (some other commits in this patchset suffer from the same
> defect).
> 

Thanks, I'll update the log in the next version.

-Haihao

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".