From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 334794B455 for ; Mon, 10 Jun 2024 19:45:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23C0368D7BD; Mon, 10 Jun 2024 22:45:10 +0300 (EEST) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 78B2A68D4C7 for ; Mon, 10 Jun 2024 22:45:04 +0300 (EEST) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a6ef8e62935so33998166b.3 for ; Mon, 10 Jun 2024 12:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718048703; x=1718653503; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=nUKWHVEg+n0PE3Kj1IRhpM/dFppk1/e+bRLWgVIf5T0=; b=e9+Zu825KKVUoBAa+530aMC7mrnrhG5HrWjEGBpiHdRKtRXL0e0WBJFrkzg7xLbeJK M2ong2IV4/J42tgU4HJGx7ZUiVesnDvdTT0aSgKr76OTgR2A4hZ4KiOMgr47ZOOkYfkK uoDQeP1RRfGmXkOVQ3tB+yI6WMzw/EatHsqF8Ggp+w28+YOfy78w7VaX6UqS00KidGZD DiygWk9PtPrcJg4r/uNcCLY8/kImlBthWEiFSCV3MH+3cuON4TTz9sBfTEVqF7Ulx3+N Bm8uSxtmhwuAWU9i3mn+xTjNr8yBpagezby7xWMVDNyXD6TBbQdVIojyFP8/kl4z8RFc KSGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718048703; x=1718653503; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nUKWHVEg+n0PE3Kj1IRhpM/dFppk1/e+bRLWgVIf5T0=; b=WhMNQtcd/920OVhwMRxkfp/oxlH3t82Uoc8wEubAQOb0cV8Zuhr5/YBKVmUnqvY7+o ACJnpPJeKq6TsNjJrnBxRVv2/L/XJGBhake3qtvFploUIYNQybIphHWLSCtTn7s0ig57 ZRyga2CUVXjGpNP8zSerreFnW2nWTysTncpn7mgYdO4yOL3h85pPp9xpYSNfTjXvvgu2 59OFwmFeng7sXahJMSZp1TALbc+g6PLwJwCceohWa6/I/TzmfJgA6SN5oZc/MpSo9jFE sFGRm4f842d7z4idPPTsHjFt8ecXd2Ax/b+XXOCNqtOrq18v40tVidSJwpM1Wkn6sKaa fWiA== X-Gm-Message-State: AOJu0YxbUZdFU0bg2+NwLw4LgiXUArbujOwuATL+MdF1cnrWtVBEmkee NROZMm8BnCpr3qVrXfNWZa8ooiDfF32WHGc7Um9KW/G4mHEdUR+UNvBMhA== X-Google-Smtp-Source: AGHT+IGgFHXEU1GBv90N+XU4NVR3WouP+tGab9jA3f1bNGV6g0glLOtt0RF4kLsgnJ72vvY9b0BxFQ== X-Received: by 2002:a17:906:f191:b0:a6f:37b7:52e6 with SMTP id a640c23a62f3a-a6f37b75431mr893166b.2.1718048702581; Mon, 10 Jun 2024 12:45:02 -0700 (PDT) Received: from [192.168.1.106] ([51.191.0.41]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a6f1c69b15csm203777666b.168.2024.06.10.12.45.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 12:45:01 -0700 (PDT) Message-ID: <2c659726-950d-4415-9d9b-c4158cb0fd54@gmail.com> Date: Mon, 10 Jun 2024 20:45:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240610184408.68171-1-derek.buitenhuis@gmail.com> <20240610184408.68171-5-derek.buitenhuis@gmail.com> <15365cbb-22fe-4bde-ae2b-13bf2e8b0411@gmail.com> Content-Language: en-GB From: Derek Buitenhuis In-Reply-To: <15365cbb-22fe-4bde-ae2b-13bf2e8b0411@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 4/5] avformat/mov: Add support for exporting Video Extension Usage info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/10/2024 8:38 PM, James Almer wrote: >> + remaining = atom.size; >> + while (remaining > 0) { > > Maybe this loop should call mov_read_default, with proj and eyes added > to mov_default_parse_table[]. Although i don't know if eyes may show up > as child for other parent boxes or not. > At least with proj, i see it can be a child for sv3d, where only prhd is > expected as a child box in turn. But it shouldn't a problem to add a > mov_read_proj that handles both prhd and prji for this purpose. Well, the proj box that that's in sv3d and this proj box are unrelated - they both exist because Apple and Google don't play nice with eachother, and both defined their own incompatible projection boxes, which exist in entirely different parts of the file, so it seemed kind of wrong to handle it that way... The other reason I left it this way is because it left it easier for us to implement the 'must' box if we wanted to, which needs to keep track of what boxes have been seen inside the 'vexu' box, and its inner boxes. To my knowledge eyes (and indeed all the other boxes inside the 'vexu' box besides the 'proj' box) only appear in the 'vexu' box. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".